Page MenuHomePhabricator
Create Task
Maniphest T245315

Insert_comment is missing name(aria-label)
Closed, ResolvedPublicBUG REPORT
Actions

Description

Steps to Reproduce:

  1. Navigate to VisualEditor
  2. Navigate till "Edit " and hit enter
  3. Navigate till "Insert" and navigate till "More" dropdown, hit enter.
  4. Navigate till "Comment" control, hit enter.

Actual Results:
textarea in comment inspector doesn't have an aria-label

Expected Results:
textarea in comment must have an aria-label.

Details

SubjectRepoBranchLines +/-
Update VE core submodule to master (a5f81e9fb)mediawiki/extensions/VisualEditormaster+1 -1
Fix: Add aria-label to comment inspectorVisualEditor/VisualEditormaster+1 -0
Customize query in gerrit

Related Objects

Event Timeline

Akinwale-microsoft created this task.Feb 14 2020, 10:35 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptFeb 14 2020, 10:35 PM
gerritbot added a comment.Feb 14 2020, 10:37 PM

Change 572361 had a related patch set uploaded (by Akinwale-microsoft; owner: Akinwale-microsoft):
[VisualEditor/VisualEditor@master] Fix: Add aria-label to comment inspector

https://gerrit.wikimedia.org/r/572361

gerritbot added a project: Patch-For-Review.Feb 14 2020, 10:37 PM
gerritbot added a comment.Feb 17 2020, 8:11 PM

Change 572361 merged by jenkins-bot:
[VisualEditor/VisualEditor@master] Fix: Add aria-label to comment inspector

https://gerrit.wikimedia.org/r/572361

gerritbot added a comment.Feb 17 2020, 8:39 PM

Change 572743 had a related patch set uploaded (by Bartosz Dziewoński; owner: Bartosz Dziewoński):
[mediawiki/extensions/VisualEditor@master] Update VE core submodule to master (a5f81e9fb)

https://gerrit.wikimedia.org/r/572743

matmarex added a project: Editing-team (Q3 2019-2020 Kanban Board).Feb 17 2020, 8:44 PM
matmarex moved this task from Needs Discussion / Investigation to Code Review on the Editing-team (Q3 2019-2020 Kanban Board) board.Feb 17 2020, 8:46 PM
gerritbot added a comment.Feb 17 2020, 8:53 PM

Change 572743 merged by jenkins-bot:
[mediawiki/extensions/VisualEditor@master] Update VE core submodule to master (a5f81e9fb)

https://gerrit.wikimedia.org/r/572743

matmarex moved this task from Code Review to Ready for Sign Off on the Editing-team (Q3 2019-2020 Kanban Board) board.Feb 17 2020, 8:56 PM
ReleaseTaggerBot added a project: MW-1.35-notes (1.35.0-wmf.20; 2020-02-18).Feb 17 2020, 9:00 PM
Maintenance_bot removed a project: Patch-For-Review.Feb 17 2020, 9:10 PM
JTannerWMF reassigned this task from Akinwale-microsoft to • marcella.Feb 20 2020, 5:25 PM
JTannerWMF subscribed.

Assigning this to Marcella for close out

Akinwale-microsoft closed this task as Resolved.Feb 21 2020, 7:58 PM
Restricted Application added a project: User-Ryasmeen. · View Herald TranscriptFeb 21 2020, 7:58 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits