Maniphest T245532

2017WTE + highlighting (CodeMirror) text layout is off by 1.5em on desktop Minerva
Closed, ResolvedPublicBUG REPORT
Actions

Description

Steps to Reproduce:

enable "New wikitext mode"
https://www.mediawiki.org/w/index.php?title=Manual:Varnish_caching&action=edit&useskin=minerva
Enable highlighting in hamburger menu if it's not already
Select first line of text: SHIFT-DOWN. The first visible line of text should be highlighted.
Select all text: CTRL-A. All lines should be highlighted.

Actual Results:

The highlights are 1.5em above and to the left of the text which it's supposed to highlight.

Expected Results:

Highlights are placed at the same location as the text.

Solution:

Unset padding: .skin-minerva .ve-init-mw-desktopArticleTarget .CodeMirror { padding: unset; }

The task that revealed this bug: T245476: [SPIKE] How to make source editors' font-size responsive

Screenshot

Note the text selection with light blue background is 1.5em above and left from the text.

WTE2017-minerva-selection-misalignment-T245532.png (771×1 px, 120 KB)

Details

	Subject	Repo	Branch	Lines +/-
	Remove the unnecessary 1.5em padding in MinervaNeue skin that misaligns highlights.	mediawiki/extensions/CodeMirror	master	+1 -0

Customize query in gerrit

Related Objects
Search...

		Status	Subtype	Assigned	Task
		Open	Goal	None	T245690 WikiTextEditor font, misalignment (umbrella task)
		Resolved	BUG REPORT	• Demian	T245532 2017WTE + highlighting (CodeMirror) text layout is off by 1.5em on desktop Minerva

Event Timeline

• Demian created this task.Feb 18 2020, 4:23 PM

Restricted Application added a project: VisualEditor. · View Herald TranscriptFeb 18 2020, 4:23 PM

Restricted Application added subscribers: Masumrezarock100, Aklapper. · View Herald Transcript

• Demian updated the task description. (Show Details)Feb 18 2020, 4:24 PM

Change 572876 had a related patch set uploaded (by Aron Manning; owner: Aron Manning):
[mediawiki/extensions/CodeMirror@master] Fix the font-family: monospace; caused font-size mess-up and remove the unnecessary padding in MinervaNeue skin.

https://gerrit.wikimedia.org/r/572876

gerritbot added a project: Patch-For-Review.Feb 18 2020, 4:27 PM

• Demian added projects: MediaWiki-extensions-CodeMirror, CSS.Feb 18 2020, 4:38 PM

Restricted Application added a project: Community-Tech. · View Herald TranscriptFeb 18 2020, 4:38 PM

• Demian moved this task from Backlog to Change CSS on the CSS board.Feb 18 2020, 4:39 PM

• Demian added a project: Editing-team.Feb 19 2020, 12:05 AM

Change 573018 had a related patch set uploaded (by Aron Manning; owner: Aron Manning):
[mediawiki/extensions/CodeMirror@master] Remove the unnecessary 1.5em padding in MinervaNeue skin that misaligns highlights.

https://gerrit.wikimedia.org/r/573018

Esanders renamed this task from 2017WTE + highlighting (CodeMirror) text layout is off by 1.5em to 2017WTE + highlighting (CodeMirror) text layout is off by 1.5em on desktop Minerva.Feb 19 2020, 3:37 PM

Change 573018 merged by jenkins-bot:
[mediawiki/extensions/CodeMirror@master] Remove the unnecessary 1.5em padding in MinervaNeue skin that misaligns highlights.

https://gerrit.wikimedia.org/r/573018

• Demian closed this task as Resolved.Feb 19 2020, 4:46 PM

• Demian triaged this task as Medium priority.

Restricted Application added a project: User-Ryasmeen. · View Herald TranscriptFeb 19 2020, 4:46 PM

• Demian added a parent task: T245690: WikiTextEditor font, misalignment (umbrella task).Feb 19 2020, 11:45 PM

• Demian updated the task description. (Show Details)Feb 19 2020, 11:50 PM

• Demian updated the task description. (Show Details)

• Demian mentioned this in T245568: Highlighting (CodeMirror) changes the editor font from the user preference (sans/serif) to monospace in the 2017 editor.Feb 20 2020, 12:28 PM

TheDJ moved this task from Backlog to Done on the MediaWiki-extensions-CodeMirror board.Feb 26 2020, 10:10 AM