Page MenuHomePhabricator

Edits while solving a conflict trigger broken conflict
Closed, ResolvedPublic5 Estimated Story PointsBUG REPORT

Description

Steps to Reproduce:

  • Create an edit conflict by editing the same page at the same place on the same revision with two different accounts/browsers/in private mode.
  • While resolving the conflict do another edit on the page at the same place with a different accounts/browsers/in private mode.
  • Submit the resolved first conflict

Actual Results:

  • You'll see a second conflict resolution screen to resolve the conflict between the first resolved version and the third edit
  • The other side of the conflict does not show the content of the third edit
  • The your side of the conflict does not show the content of the resolved version
  • The selection for one of the sides is remembered from the first interface

Expected Results:

  • The other side of the conflict shows the content of the third edit
  • The your side of the conflict shows the content of the resolved version
  • The selection is set to default

Note: If the third edit does not conflict with any part of the resolved conflict the situation is resolved automatically.

Event Timeline

Change 573314 had a related patch set uploaded (by WMDE-Fisch; owner: WMDE-Fisch):
[mediawiki/extensions/TwoColConflict@master] Browser test for third conflicting edit

https://gerrit.wikimedia.org/r/573314

Change 573314 merged by jenkins-bot:
[mediawiki/extensions/TwoColConflict@master] Consider third conflicting edits

https://gerrit.wikimedia.org/r/573314

Change 573983 had a related patch set uploaded (by Thiemo Kreuz (WMDE); owner: Thiemo Kreuz (WMDE)):
[mediawiki/extensions/TwoColConflict@master] Remove more unused code from SplitTwoColConflictHelper

https://gerrit.wikimedia.org/r/573983

Change 573983 merged by jenkins-bot:
[mediawiki/extensions/TwoColConflict@master] Remove more unused code from SplitTwoColConflictHelper

https://gerrit.wikimedia.org/r/573983

thiemowmde moved this task from Demo to Done on the WMDE-QWERTY-Sprint-2020-02-19 board.