Mediaviewer is still providing the wrong date
Closed, DuplicatePublicBUG REPORT
Actions

Assigned To

None

Authored By

	Magog_the_Ogre
	Feb 22 2020, 4:33 PM

Description

Steps to Reproduce:

Set your system time zone to US Eastern.
Click on this link and observe the creation date as 2011-11-10: File:Monkey Hill.jpg.
Click on this link and observe the creation date as 2011-11-09: https://es.wikipedia.org/wiki/Monkey_Hill?debug=true#/media/Archivo:Monkey_Hill.jpg

Actual Results: Creation date is 9 de noviembre de 2011

Expected Results: Creation date is 10 de noviembre de 2011

Cause: the fix for T58794 doesn't take into account time zones.

Fix: Add the following line before mmv.ui.metadataPanel.js Line 815:

date.setMinutes(date.getMinutes() + date.getTimezoneOffset());

FYI I plan to insert a custom patch on English Wikipedia. It should be forward compatible with any changes you make. Feel free to let me know on my talk page when this is in production and I will remove my own patch.

Thank you!

Related Objects

Mentioned In: T243160: Extension:Media Viewer shows the date before as the date "Created"
Mentioned Here: T58794: False specificity in vague dates for Media Viewer (as moment.js does not support partial dates)

Event Timeline

Magog_the_Ogre created this task.Feb 22 2020, 4:33 PM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptFeb 22 2020, 4:33 PM

that should say "add the following line" not "edit"

In T245919#5909528, @Magog_the_Ogre wrote:

that should say "add the following line" not "edit"

I've edited the description with that and a github link to the line.

• Demian updated the task description. (Show Details)Feb 22 2020, 4:42 PM

In an embarrassing twist, I didn't properly test the code I fixed before I added it here.

Line 815 should read:

date.setMinutes(date.getMinutes() + date.getTimezoneOffset());

Thanks, @Demian

Ammarpad closed this task as a duplicate of T243160: Extension:Media Viewer shows the date before as the date "Created".Feb 22 2020, 5:00 PM

• Demian updated the task description. (Show Details)Feb 22 2020, 5:08 PM

• Demian mentioned this in T243160: Extension:Media Viewer shows the date before as the date "Created".Feb 22 2020, 5:10 PM

In T245919#5909593, @Magog_the_Ogre wrote:

Thanks, @Demian

https://www.mediawiki.org/wiki/User_talk:Magog_the_Ogre

See https://www.mediawiki.org/wiki/Gerrit/Tutorial/tl;dr if you want to patch it. If you don't want the trouble, I'll do it for you.

Tip: run the basic tests before submitting the patch. In MediaViewer:

npm install grunt
grunt test

Stylelint will ask you to add spaces inside the parenthesis... it's quite strict on following the style guide.
Like so:

date.setMinutes( date.getMinutes() + date.getTimezoneOffset() );

Hope I saved you a patch-round ;-)

Mediaviewer is still providing the wrong dateClosed, DuplicatePublicBUG REPORTActions

Description

Related Objects

Event Timeline

Mediaviewer is still providing the wrong date
Closed, DuplicatePublicBUG REPORT
Actions