interwiki map API shouldn't add language parameter when InterwikiMagic is false
Closed, ResolvedPublic
Actions

Assigned To

Authored By

	Urbanecm
	Feb 22 2020, 10:37 PM

Description

Wiki admins set wgInterwikiMagic=false when they do not want any interwikis displayed in the sidebar as interlanguage links. It is reasonable to expect they might add some interwikis that looks like a language interwiki, linking to another wiki. If that's done, MediaWiki incorrectly reports them as language interwiki, which isn't correct. This causes unexpected things like T130381.

Related Objects
Search...

		Status	Subtype	Assigned	Task
		Open		None	T130381 wiki.musicbrainz.org has started reporting multiple languages
		Resolved		Urbanecm	T245931 interwiki map API shouldn't add language parameter when InterwikiMagic is false

Event Timeline

Urbanecm created this task.Feb 22 2020, 10:37 PM

Restricted Application added projects: User-Urbanecm, Platform Engineering. · View Herald TranscriptFeb 22 2020, 10:37 PM

Restricted Application added a subscriber: Aklapper. · View Herald Transcript

Change 574201 had a related patch set uploaded (by Urbanecm; owner: Urbanecm):
[mediawiki/core@master] [api] InterwikiMap shouldn't report any interwikis as language ones when InterwikiMagic=false

https://gerrit.wikimedia.org/r/574201

gerritbot added a project: Patch-For-Review.Feb 22 2020, 10:37 PM

Urbanecm mentioned this in T130381: wiki.musicbrainz.org has started reporting multiple languages.Feb 22 2020, 10:38 PM

Urbanecm added a parent task: T130381: wiki.musicbrainz.org has started reporting multiple languages.

Urbanecm edited projects, added Platform Team Workboards (Clinic Duty Team); removed Platform Engineering.

Urbanecm updated the task description. (Show Details)

Urbanecm moved this task from Unsorted to Needs Review on the MediaWiki-Action-API board.Feb 22 2020, 10:40 PM

Urbanecm moved this task from Inbox to External Code Review Needed on the Platform Team Workboards (Clinic Duty Team) board.

DannyS712 subscribed.Feb 22 2020, 10:43 PM

Urbanecm moved this task from Backlog to Waiting on review on the User-Urbanecm board.Feb 22 2020, 11:01 PM

Note this won't currently help with T130381: wiki.musicbrainz.org has started reporting multiple languages as https://wiki.musicbrainz.org/api.php?action=query&meta=siteinfo&siprop=general&format=jsonfm&formatversion=2 indicates that wiki.musicbrainz.org has $wgInterwikiMagic set to true.