Page MenuHomePhabricator
Create Task
Maniphest T247068

Make SearchEntities use a batched title lookup
Closed, ResolvedPublic
Actions

Description

To avoid the API module making 1 API call per title being looked up it should request the titles in a batch and then add them to the result.
EntityTitleLookup already has a getTitlesForIds method that we can use here.

Details

SubjectRepoBranchLines +/-
Make SearchEntities use a batched title lookupmediawiki/extensions/Wikibasemaster+63 -12
SearchEntitiesIntegrationTest remove getTitleForId in lookup mockmediawiki/extensions/WikibaseCirrusSearchmaster+0 -1
SearchEntitiesIntegrationTest allow use of getTitlesForIds in lookupmediawiki/extensions/WikibaseCirrusSearchmaster+11 -0
Customize query in gerrit

Related Objects
Search...

Event Timeline

Addshore created this task.Mar 6 2020, 11:21 AM
Addshore claimed this task.Mar 6 2020, 12:02 PM
Addshore moved this task from To do to Doing on the Wikibase - Federated Properties (Sprint 1/6 (Hike 1)) board.
Restricted Application added a project: User-Addshore. · View Herald TranscriptMar 6 2020, 12:02 PM
gerritbot added a comment.Mar 6 2020, 4:20 PM

Change 577605 had a related patch set uploaded (by Addshore; owner: Addshore):
[mediawiki/extensions/Wikibase@master] Make SearchEntities use a batched title lookup

https://gerrit.wikimedia.org/r/577605

gerritbot added a project: Patch-For-Review.Mar 6 2020, 4:20 PM
gerritbot added a comment.Mar 8 2020, 5:24 PM

Change 578053 had a related patch set uploaded (by Addshore; owner: Addshore):
[mediawiki/extensions/WikibaseCirrusSearch@master] SearchEntitiesIntegrationTest allow use of getTitlesForIds in lookup

https://gerrit.wikimedia.org/r/578053

gerritbot added a comment.Mar 8 2020, 5:26 PM

Change 578054 had a related patch set uploaded (by Addshore; owner: Addshore):
[mediawiki/extensions/WikibaseCirrusSearch@master] SearchEntitiesIntegrationTest remove getTitleForId in lookup mock

https://gerrit.wikimedia.org/r/578054

Addshore moved this task from Doing to Peer Review on the Wikibase - Federated Properties (Sprint 1/6 (Hike 1)) board.Mar 8 2020, 6:00 PM
gerritbot added a comment.Mar 9 2020, 3:20 PM

Change 578053 merged by jenkins-bot:
[mediawiki/extensions/WikibaseCirrusSearch@master] SearchEntitiesIntegrationTest allow use of getTitlesForIds in lookup

https://gerrit.wikimedia.org/r/578053

Addshore mentioned this in rEWCSe66d957c0a7a: SearchEntitiesIntegrationTest allow use of getTitlesForIds in lookup.Mar 9 2020, 3:39 PM
ReleaseTaggerBot added a project: MW-1.35-notes (1.35.0-wmf.23; 2020-03-10).Mar 9 2020, 4:01 PM
gerritbot added a comment.Mar 10 2020, 11:46 AM

Change 577605 merged by jenkins-bot:
[mediawiki/extensions/Wikibase@master] Make SearchEntities use a batched title lookup

https://gerrit.wikimedia.org/r/577605

gerritbot added a comment.Mar 10 2020, 11:47 AM

Change 578054 merged by jenkins-bot:
[mediawiki/extensions/WikibaseCirrusSearch@master] SearchEntitiesIntegrationTest remove getTitleForId in lookup mock

https://gerrit.wikimedia.org/r/578054

Addshore mentioned this in rEWCSf04c06652015: SearchEntitiesIntegrationTest remove getTitleForId in lookup mock.Mar 10 2020, 11:49 AM
Maintenance_bot removed a project: Patch-For-Review.Mar 10 2020, 12:10 PM
Jakob_WMDE moved this task from Peer Review to Verification on the Wikibase - Federated Properties (Sprint 1/6 (Hike 1)) board.Mar 11 2020, 11:01 AM
Jakob_WMDE moved this task from Verification to Peer Review on the Wikibase - Federated Properties (Sprint 1/6 (Hike 1)) board.
Jakob_WMDE moved this task from Peer Review to Verification on the Wikibase - Federated Properties (Sprint 1/6 (Hike 1)) board.
Addshore closed this task as Resolved.Apr 1 2020, 8:52 AM
Addshore moved this task from Unsorted 💣 to Closing ✔️ on the User-Addshore board.
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits