Page MenuHomePhabricator

Make SearchEntities use a batched title lookup
Closed, ResolvedPublic

Description

To avoid the API module making 1 API call per title being looked up it should request the titles in a batch and then add them to the result.
EntityTitleLookup already has a getTitlesForIds method that we can use here.

Event Timeline

Change 577605 had a related patch set uploaded (by Addshore; owner: Addshore):
[mediawiki/extensions/Wikibase@master] Make SearchEntities use a batched title lookup

https://gerrit.wikimedia.org/r/577605

Change 578053 had a related patch set uploaded (by Addshore; owner: Addshore):
[mediawiki/extensions/WikibaseCirrusSearch@master] SearchEntitiesIntegrationTest allow use of getTitlesForIds in lookup

https://gerrit.wikimedia.org/r/578053

Change 578054 had a related patch set uploaded (by Addshore; owner: Addshore):
[mediawiki/extensions/WikibaseCirrusSearch@master] SearchEntitiesIntegrationTest remove getTitleForId in lookup mock

https://gerrit.wikimedia.org/r/578054

Change 578053 merged by jenkins-bot:
[mediawiki/extensions/WikibaseCirrusSearch@master] SearchEntitiesIntegrationTest allow use of getTitlesForIds in lookup

https://gerrit.wikimedia.org/r/578053

Change 577605 merged by jenkins-bot:
[mediawiki/extensions/Wikibase@master] Make SearchEntities use a batched title lookup

https://gerrit.wikimedia.org/r/577605

Change 578054 merged by jenkins-bot:
[mediawiki/extensions/WikibaseCirrusSearch@master] SearchEntitiesIntegrationTest remove getTitleForId in lookup mock

https://gerrit.wikimedia.org/r/578054