Make search work with remote properties (wbsearchentities)
Closed, ResolvedPublic5 Estimated Story Points
Actions

Assigned To

None

Authored By

	• Samantha_Alipio_WMDE
	Feb 27 2020, 3:26 PM

Description

We need to make it possible to search for a federated property in the property input field when adding new statements.

BDD
Scenario: Federated properties are enabled and I am manually adding a statement to a local item
Given I have selected +add statement on the item page
When I enter the federated property label or Pxx in property input field
Then federated properties appear in the results list for me to select from

The url field in the wbsearchentities response will for now contain the url of the property on the source wiki, but we make this configurable in case we want to change it to the url of the local representation of the federated property (= "shadow page") in the future.

Related Objects
Search...

Status	Assigned	Task
Resolved	None	T246124 [EPIC ] Use Wikidata properties to manually add statements about local items
Resolved	None	T246349 Make search work with remote properties (wbsearchentities)
Invalid	Rosalie_WMDE	T246800 Abstraction layer in SearchEntities API module
Resolved	Jakob_WMDE	T246802 Service / http client to communicate with remote API (first version)
Invalid	Jakob_WMDE	T246803 Implement new way of abstraction to call remote wbsearchentities API
Resolved	Jakob_WMDE	T247067 Decouple SearchEntities from PropertyDataTypeLookup
Resolved	Addshore	T247068 Make SearchEntities use a batched title lookup
Resolved	Addshore	T247069 Override services for getting a federated property's "title", "url" and "articleId"
Resolved	Rosalie_WMDE	T247070 Implement an EntitySearchHelper that is backed by an API
Resolved	Addshore	T247071 Override the services used in SearchEntities for properties when federation is enabled
Resolved	Addshore	T248455 Create & Override service for getting a federated property's "conceptUri" in SearchEntities
Resolved	Addshore	T248458 Remove "repositories" response from SearchEntities for Federated Property calls

Event Timeline

• Samantha_Alipio_WMDE created this task.Feb 27 2020, 3:26 PM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptFeb 27 2020, 3:26 PM

• Samantha_Alipio_WMDE added a parent task: T246124: [EPIC ] Use Wikidata properties to manually add statements about local items.Feb 27 2020, 3:26 PM

Addshore mentioned this in T246766: [TRACKING] Changes to Wikibase API modules when it comes to federated properties.Mar 3 2020, 1:24 PM

• Samantha_Alipio_WMDE renamed this task from Make search work with remote properties (wbsearch entities) to Make search work with remote properties (wbsearchentities).Mar 3 2020, 1:51 PM

• Samantha_Alipio_WMDE updated the task description. (Show Details)

Jakob_WMDE updated the task description. (Show Details)Mar 3 2020, 1:55 PM

Addshore updated the task description. (Show Details)Mar 3 2020, 1:58 PM

Addshore updated the task description. (Show Details)Mar 3 2020, 2:05 PM

• Samantha_Alipio_WMDE updated the task description. (Show Details)Mar 3 2020, 2:27 PM

• Samantha_Alipio_WMDE moved this task from Backlog to Ready to estimate on the Wikibase - Federated Properties board.

• Samantha_Alipio_WMDE updated the task description. (Show Details)Mar 3 2020, 4:58 PM

• Samantha_Alipio_WMDE moved this task from Ready to estimate to Backlog on the Wikibase - Federated Properties board.Mar 3 2020, 5:22 PM

Change 577318 had a related patch set uploaded (by Jakob; owner: Jakob):
[mediawiki/extensions/Wikibase@master] Decouple SearchEntities from PropertyDataTypeLookup

https://gerrit.wikimedia.org/r/577318

gerritbot added a project: Patch-For-Review.Mar 6 2020, 9:36 AM

So, we had a call today and decided to split this up in a slightly different way using an abstraction that already exists in WIkibase, EntitySearchHelper.

The new tasks will roughly be:

Remove the property data type "stuff" that shouldn't be in SearchEntities, directly, and put it somewhere else.
Alter SearchEntities to use EntityTitleLookup::getTitlesForIds (batched lookup) insead of getTitleForId
Implement an EntityTitleLookup that is backed by an API
Implement an EntitySearchHelper that is backed by an API
Override the entity services for property with those written here and it should "just work" (tm)