Page MenuHomePhabricator

Forward port Python2 files to Python3 in Puppet Repository
Open, MediumPublic

Description

This will be an essential project to make our systems future safe against Python2 going away.

This is intended to be a tracking task, each file or set of files may be its own complicated project depending. Many may just work as-is also.

statuscommentfile
erbportmodules/beta/templates/wmf-beta-autoupdate.py.erb
erbportmodules/profile/templates/hadoop/net-topology.py.erb
erbportmodules/profile/templates/hive/client/beeline_wrapper.py.erb
nochangedoes not pass python3 pep8modules/openstack/files/designate/designatemakedomain.py
nochangepasses python3 pep8modules/openstack/files/monitor/fullstack/check_nova_fullstack_leaks.py
nochangedoes not pass python3 pep8modules/openstack/files/puppet/master/instance-info-dumper.py
nochangedoes not pass python3 pep8modules/openstack/files/util/wmcs-updateproxies.py
nochangedoes not pass python3 pep8modules/profile/files/toolforge/portgrabber_cli.py
nochangedoes not pass python3 pep8modules/profile/files/toolforge/portreleaser.py
nochangedoes not pass python3 pep8modules/prometheus/files/usr/local/bin/prometheus-gdnsd-stats.py
nochangedoes not pass python3 pep8modules/puppetmaster/files/validatelabsfqdn.py
nochangedoes not pass python3 pep8modules/swift/files/SwiftMedia/wmf/rewrite_integration_test.py
nochangepasses python3 pep8utils/vcl_ec2_nets.py
nochange/reviewedpasses python3 pep8 and reviewed but untestedmodules/etcd/files/etcd-backup.py
nochange/reviewedpasses python3 pep8 and reviewed but untestedmodules/graphite/files/archive-instances.py
nochange/reviewedpasses python3 pep8 and reviewed but untestedmodules/mediawiki/files/mediawiki-firejail-convert.py
nochange/reviewedpasses python3 pep8 and reviewed but untestedmodules/mediawiki/files/mediawiki-firejail-ffmpeg.py
nochange/reviewedpasses python3 pep8 and reviewed but untestedmodules/mediawiki/files/mediawiki-firejail-ghostscript.py
nochange/untestedpasses python3 pep8modules/cassandra/files/cassandra-ca-manager.py
nochange/untestedpasses python3 pep8modules/cdh/files/hadoop/check_hdfs_active_namenode.py
nochange/untestedpasses python3 pep8modules/ldap/files/scripts/add-ldap-group.py
nochange/untestedpasses python3 pep8modules/letsencrypt/files/acme-setup.py
nochange/untestedpasses python3 pep8 / already python3 compatmodules/letsencrypt/files/acme_tiny.py
patchout/removemoritz has indicated that it probably will be removedmodules/base/files/monitoring/check-fresh-files-in-dir.py
patchoutmodules/beta/files/wmf-beta-update-databases.py
patchoutmodules/burrow/files/check_kafka_consumer_lag.py
patchoutmodules/confd/files/confd-lint-wrap.py
portedmodules/interface/files/interface-rps.py
patchoutmodules/ircecho/files/ircecho.py
patchoutmodules/mw_rc_irc/files/udpmxircecho.py
neededmodules/openldap/files/offboard-user.py
patchoutmodules/openstack/files/monitor/keystone/check_keystone_roles.py
patchoutmodules/openstack/files/monitor/wmcs-spreadcheck.py
patchoutmodules/openstack/files/util/wmcs-webproxy.py
patchoutmodules/phabricator/files/phab_epipe.py
removedmodules/profile/files/labs/db/views/maintain-meta_p.py
patchoutmodules/profile/files/toolforge/proxylistener.py
patchoutmodules/pybal/files/check_pybal_ipvs_diff.py
patchoutmodules/pybal/files/pybal-eval-check.py
patchoutmodules/rabbitmq/files/rabbitmqadmin.py
portedmodules/raid/files/check-raid.py
patchoutmodules/raid/files/get-raid-status-megacli.py
willnoportowners are portingmodules/scap/files/mwgrep.py
patchoutmodules/sslcert/files/update-ocsp.py
patchoutmodules/sslcert/files/x509-bundle.py
patchoutmodules/swift/files/swift-account-stats.py
patchoutmodules/swift/files/swift-container-stats.py
patchoutmodules/swift/files/swift-dispersion-stats.py
patchoutmodules/swift/files/swift-drive-audit.py
portedmodules/tcpircbot/files/tcpircbot.py
patchoutmodules/tlsproxy/files/utils/cipher_sim.py
patchoutmodules/varnish/files/cachestats.py
patchoutmodules/zuul/files/zuul-gearman.pya
portedmodules/base/files/apt-upgrade-activity.py
portedmodules/base/files/check_systemd_state.py
portedmodules/base/files/firewall/check_conntrack.py
portedmodules/base/files/phaste.py
portedmodules/elasticsearch/files/es-tool.py
portedmodules/icinga/files/check_legal_html.py
portedmodules/icinga/files/check_ripe_atlas.py
portedmodules/icinga/files/purge-nagios-resources.py
portedmodules/icinga/files/raid_handler.py
portedmodules/labstore/files/logcleanup.py
portedmodules/ldap/files/rewrite-group-for-memberof.py
portedmodules/nagios_common/files/check_commands/check_grafana_alert.py
portedmodules/nagios_common/files/check_commands/check_graphite_freshness.py
portedmodules/nagios_common/files/check_commands/check_graphite.py
porteddone by kunalmodules/openldap/files/cross-validate-accounts.py
portedported by Andrew Bogottmodules/openstack/files/nova/fullstack/nova_fullstack_test.py
porteddone by someone elsemodules/openstack/files/util/wmcs-wikireplica-dns.py
portedmodules/service/files/logstash_checker.py
portedkunal ported thismodules/zuul/files/zuul-test-repo.py
ported/externalmodules/base/files/labs/puppet_alert.py
ported/externalbrook did thiswork modules/base/files/labs/notify_maintainers.py
removedported, later removed as unusedmodules/admin/data/nda_audit.py
removedported, later rewritten by jbond in python3modules/diffscan/files/diffscan.py
removedported, later removed as replaced by cookbookmodules/drac/files/drac.py
removedmodules/librenms/files/purge.py
removedremoved in f90ba7e7e6modules/openstack/files/monitor/keystone/check_keystone_projects.py
removedmodules/openstack/files/queens/admin_scripts/wmcs-cold-migrate.py
removeddoes not pass python3 pep8modules/openstack/files/queens/admin_scripts/wmcs-cold-nova-migrate.py
removeddoes not pass python3 pep8modules/openstack/files/queens/admin_scripts/wmcs-live-migrate.py
removedmodules/openstack/files/queens/admin_scripts/wmcs-logstat.py
removeddoes not pass python3 pep8modules/openstack/files/queens/admin_scripts/wmcs-makedomain.py
removedmodules/openstack/files/queens/admin_scripts/wmcs-novastats/wmcs-novastats-capacity.py
removedmodules/openstack/files/queens/admin_scripts/wmcs-novastats/wmcs-novastats-dnsleaks.py
removedmodules/openstack/files/queens/admin_scripts/wmcs-novastats/wmcs-novastats-flavorreport.py
removedmodules/openstack/files/queens/admin_scripts/wmcs-novastats/wmcs-novastats-imagestats.py
removedmodules/openstack/files/queens/admin_scripts/wmcs-novastats/wmcs-novastats-proxyleaks.py
removedmodules/openstack/files/queens/admin_scripts/wmcs-novastats/wmcs-novastats-puppetleaks.py
removedmodules/openstack/files/queens/admin_scripts/wmcs-region-migrate.py
removedmodules/openstack/files/queens/admin_scripts/wmcs-region-migrate-quotas.py
removedmodules/openstack/files/queens/admin_scripts/wmcs-region-migrate-security-groups.py
removedmodules/openstack/files/queens/admin_scripts/wmcs-wikitech-grep.py
removedmodules/openstack/files/rocky/admin_scripts/wmcs-cold-migrate.py
removeddoes not pass python3 pep8modules/openstack/files/rocky/admin_scripts/wmcs-cold-nova-migrate.py
removeddoes not pass python3 pep8modules/openstack/files/rocky/admin_scripts/wmcs-live-migrate.py
removedmodules/openstack/files/rocky/admin_scripts/wmcs-logstat.py
removeddoes not pass python3 pep8modules/openstack/files/rocky/admin_scripts/wmcs-makedomain.py
removedmodules/openstack/files/rocky/admin_scripts/wmcs-novastats/wmcs-novastats-capacity.py
removedmodules/openstack/files/rocky/admin_scripts/wmcs-novastats/wmcs-novastats-dnsleaks.py
removedmodules/openstack/files/rocky/admin_scripts/wmcs-novastats/wmcs-novastats-imagestats.py
removedmodules/openstack/files/rocky/admin_scripts/wmcs-novastats/wmcs-novastats-proxyleaks.py
removedmodules/openstack/files/rocky/admin_scripts/wmcs-novastats/wmcs-novastats-puppetleaks.py
removedmodules/openstack/files/rocky/admin_scripts/wmcs-region-migrate.py
removedmodules/openstack/files/rocky/admin_scripts/wmcs-region-migrate-quotas.py
removedmodules/openstack/files/rocky/admin_scripts/wmcs-region-migrate-security-groups.py
removedmodules/openstack/files/rocky/admin_scripts/wmcs-wikitech-grep.py
removedmodules/profile/files/toolforge/gridscripts/runninggridjobsmail.py
removedmodules/profile/files/toolforge/gridscripts/runninggridtasks.py
removedmodules/sentry/files/sentry-auth.py
removedmodules/shinken/files/shinkengen.py
willnotporttargets jessie specificallymodules/graphite/files/graphite-auth.jessie.py
willnotporttargets stretch specificallymodules/graphite/files/graphite-auth.stretch.py
willnotporttargets jessie specificallymodules/graphite/files/graphite-index.jessie.py
willnotporttargets stretch specificallymodules/graphite/files/graphite-index.stretch.py
willnotportport work done, deprecated since 2015 T114063modules/ldap/files/scripts/ldaplist.py
willnotportport work done, deprecated since 2015 T114063modules/ldap/files/scripts/ldapsupportlib.py
willnotporttargets python2 specificallymodules/ldap/files/scripts/ssh-key-ldap-lookup-python2.py

Details

ProjectBranchLines +/-Subject
operations/puppetproduction+11 -12
operations/puppetproduction+1 -1
operations/puppetproduction+3 -4
operations/puppetproduction+5 -4
operations/puppetproduction+2 -2
operations/puppetproduction+3 -4
operations/puppetproduction+365 -171
operations/puppetproduction+7 -5
operations/puppetproduction+7 -7
operations/puppetproduction+13 -11
operations/puppetproduction+11 -13
operations/puppetproduction+4 -4
operations/puppetproduction+4 -4
operations/puppetproduction+40 -40
operations/puppetproduction+5 -5
operations/puppetproduction+1 -1
operations/puppetproduction+1 -1
operations/puppetproduction+4 -5
operations/puppetproduction+6 -7
operations/puppetproduction+21 -10
operations/puppetproduction+8 -7
operations/puppetproduction+9 -11
operations/puppetproduction+18 -15
operations/puppetproduction+10 -11
operations/puppetproduction+5 -5
operations/puppetproduction+8 -7
operations/puppetproduction+8 -9
operations/puppetproduction+5 -5
operations/puppetproduction+3 -3
operations/puppetproduction+4 -4
operations/puppetproduction+12 -12
operations/puppetproduction+8 -8
operations/puppetproduction+9 -13
operations/puppetproduction+8 -7
operations/puppetproduction+2 -2
operations/puppetproduction+29 -29
operations/puppetproduction+6 -6
operations/puppetproduction+14 -21
operations/puppetproduction+5 -9
operations/puppetproduction+6 -11
operations/puppetproduction+6 -6
operations/puppetproduction+6 -6
operations/puppetproduction+29 -28
operations/puppetproduction+75 -76
operations/puppetproduction+1 -3
operations/puppetproduction+5 -5
operations/puppetproduction+4 -4
operations/puppetproduction+15 -15
operations/puppetproduction+70 -71
operations/puppetproduction+36 -35
operations/puppetproduction+3 -4
operations/puppetproduction+10 -13
operations/puppetproduction+8 -8
operations/puppetproduction+2 -2
operations/puppetproduction+1 -1
operations/puppetproduction+1 -1
operations/puppetproduction+13 -11
operations/puppetproduction+3 -7
operations/puppetproduction+0 -172
operations/puppetproduction+7 -205
operations/puppetproduction+8 -9
operations/puppetproduction+4 -4
operations/puppetproduction+9 -10
operations/puppetproduction+0 -27
Show related patches Customize query in gerrit

Event Timeline

There are a very large number of changes, so older changes are hidden. Show Older Changes

Change 630697 merged by CRusnov:
[operations/puppet@production] base/phaste.py: Port to Python 3

https://gerrit.wikimedia.org/r/630697

Change 630690 merged by CRusnov:
[operations/puppet@production] base/firewall/check_conntrack.py: Port to Python3

https://gerrit.wikimedia.org/r/630690

Change 644358 had a related patch set uploaded (by CRusnov; owner: CRusnov):
[operations/puppet@production] Port drac.py to Python3

https://gerrit.wikimedia.org/r/644358

Change 644365 had a related patch set uploaded (by CRusnov; owner: CRusnov):
[operations/puppet@production] Port elasticsearch/es-tool.py to Python3

https://gerrit.wikimedia.org/r/644365

Change 644372 had a related patch set uploaded (by CRusnov; owner: CRusnov):
[operations/puppet@production] icinga/check_legal_html.py: Port to Python3

https://gerrit.wikimedia.org/r/644372

Change 644358 abandoned by CRusnov:
[operations/puppet@production] Port drac.py to Python3

Reason:
This module will be removed.

https://gerrit.wikimedia.org/r/644358

Change 644372 merged by CRusnov:
[operations/puppet@production] icinga/check_legal_html.py: Port to Python3

https://gerrit.wikimedia.org/r/644372

Change 644365 merged by CRusnov:
[operations/puppet@production] Port elasticsearch/es-tool.py to Python3

https://gerrit.wikimedia.org/r/644365

Change 644591 had a related patch set uploaded (by CRusnov; owner: CRusnov):
[operations/puppet@production] Port elasticsearch/es-tool.py to Python3

https://gerrit.wikimedia.org/r/644591

Change 646879 had a related patch set uploaded (by CRusnov; owner: CRusnov):
[operations/puppet@production] check_ripe_atlas.py: Port to Python3

https://gerrit.wikimedia.org/r/646879

Change 646884 had a related patch set uploaded (by CRusnov; owner: CRusnov):
[operations/puppet@production] purge-nagios-resources.py: Port to Python 3

https://gerrit.wikimedia.org/r/646884

Change 646890 had a related patch set uploaded (by CRusnov; owner: CRusnov):
[operations/puppet@production] modules/icinga/files/raid_handler.py: Port to Python 3

https://gerrit.wikimedia.org/r/646890

Change 646884 merged by CRusnov:
[operations/puppet@production] purge-nagios-resources.py: Port to Python 3

https://gerrit.wikimedia.org/r/646884

Change 646890 merged by CRusnov:
[operations/puppet@production] modules/icinga/files/raid_handler.py: Port to Python 3

https://gerrit.wikimedia.org/r/646890

Change 647364 had a related patch set uploaded (by CRusnov; owner: CRusnov):
[operations/puppet@production] icinga/raid.pp: Add Python3 requirements for raid_handler.py

https://gerrit.wikimedia.org/r/647364

Change 647364 merged by CRusnov:
[operations/puppet@production] icinga/raid.pp: Add Python3 requirements for raid_handler.py

https://gerrit.wikimedia.org/r/647364

Change 647369 had a related patch set uploaded (by CRusnov; owner: CRusnov):
[operations/puppet@production] modules/icinga/files/raid_handler.py: Port to Python 3

https://gerrit.wikimedia.org/r/647369

Change 652575 had a related patch set uploaded (by CRusnov; owner: CRusnov):
[operations/puppet@production] modules/interface/files/interface-rps.py: Adapt for Python3

https://gerrit.wikimedia.org/r/652575

Change 644591 merged by CRusnov:
[operations/puppet@production] Port elasticsearch/es-tool.py to Python3

https://gerrit.wikimedia.org/r/644591

Change 646879 merged by CRusnov:
[operations/puppet@production] check_ripe_atlas.py: Port to Python3

https://gerrit.wikimedia.org/r/646879

Change 647369 merged by CRusnov:
[operations/puppet@production] modules/icinga/files/raid_handler.py: Port to Python 3

https://gerrit.wikimedia.org/r/647369

Change 654336 had a related patch set uploaded (by CRusnov; owner: CRusnov):
[operations/puppet@production] ircecho: port to Python 3

https://gerrit.wikimedia.org/r/654336

Change 654339 had a related patch set uploaded (by CRusnov; owner: CRusnov):
[operations/puppet@production] labstore/files/logcleanup.py: Port to Python3

https://gerrit.wikimedia.org/r/654339

Change 654339 merged by CRusnov:
[operations/puppet@production] labstore/files/logcleanup.py: Port to Python3

https://gerrit.wikimedia.org/r/654339

Change 655731 had a related patch set uploaded (by CRusnov; owner: CRusnov):
[operations/puppet@production] check_grafana_alert.py: Port to Python 3

https://gerrit.wikimedia.org/r/655731

Change 655733 had a related patch set uploaded (by CRusnov; owner: CRusnov):
[operations/puppet@production] check_graphite_freshness.py: Port to Python 3

https://gerrit.wikimedia.org/r/655733

Change 655734 had a related patch set uploaded (by CRusnov; owner: CRusnov):
[operations/puppet@production] check_graphite.py: Port to Python 3

https://gerrit.wikimedia.org/r/655734

Change 655743 had a related patch set uploaded (by CRusnov; owner: CRusnov):
[operations/puppet@production] phabricator/phab_epipe.py: Port to Python 3

https://gerrit.wikimedia.org/r/655743

Change 658360 had a related patch set uploaded (by CRusnov; owner: CRusnov):
[operations/puppet@production] ldap/ldapsupportlib.py: Adjust for Python 3

https://gerrit.wikimedia.org/r/658360

Change 658396 had a related patch set uploaded (by CRusnov; owner: CRusnov):
[operations/puppet@production] burrow/check_kafka_consumer_lag.py: Port to Python 3

https://gerrit.wikimedia.org/r/658396

Change 658414 had a related patch set uploaded (by CRusnov; owner: CRusnov):
[operations/puppet@production] confd/confd-lint-wrap.py: Port for Python 3

https://gerrit.wikimedia.org/r/658414

Change 658415 had a related patch set uploaded (by CRusnov; owner: CRusnov):
[operations/puppet@production] ldap/rewrite-group-for-memberof.py: Port for Python 3

https://gerrit.wikimedia.org/r/658415

Change 658427 had a related patch set uploaded (by CRusnov; owner: CRusnov):
[operations/puppet@production] ldap/ldaplist.py: Port for Python 3

https://gerrit.wikimedia.org/r/658427

Change 655731 merged by CRusnov:
[operations/puppet@production] check_grafana_alert.py: Port to Python 3

https://gerrit.wikimedia.org/r/655731

Change 655733 merged by CRusnov:
[operations/puppet@production] check_graphite_freshness.py: Port to Python 3

https://gerrit.wikimedia.org/r/655733

Change 655734 merged by CRusnov:
[operations/puppet@production] check_graphite.py: Port to Python 3

https://gerrit.wikimedia.org/r/655734

Change 652575 merged by CRusnov:
[operations/puppet@production] modules/interface/files/interface-rps.py: Adapt for Python3

https://gerrit.wikimedia.org/r/652575

Change 658415 merged by CRusnov:
[operations/puppet@production] ldap/rewrite-group-for-memberof.py: Port for Python 3

https://gerrit.wikimedia.org/r/658415

Change 662764 had a related patch set uploaded (by CRusnov; owner: CRusnov):
[operations/puppet@production] mw_rc_irc/udpmxircecho.py: port to Python 3

https://gerrit.wikimedia.org/r/662764

Change 662765 had a related patch set uploaded (by CRusnov; owner: CRusnov):
[operations/puppet@production] openldap/offboard-user.py: Port to Python 3

https://gerrit.wikimedia.org/r/662765

Change 670922 had a related patch set uploaded (by CRusnov; owner: CRusnov):
[operations/puppet@production] modules/beta/files/wmf-beta-update-databases.py: Port to Python 3

https://gerrit.wikimedia.org/r/670922

Change 670925 had a related patch set uploaded (by CRusnov; owner: CRusnov):
[operations/puppet@production] check_keystone_roles.py: Port to Python 3

https://gerrit.wikimedia.org/r/670925

Change 670928 had a related patch set uploaded (by CRusnov; owner: CRusnov):
[operations/puppet@production] wmcs-spreadcheck.py: Port to Python 3

https://gerrit.wikimedia.org/r/670928

Change 670933 had a related patch set uploaded (by CRusnov; owner: CRusnov):
[operations/puppet@production] wmcs-webproxy.py: Port to Python 3

https://gerrit.wikimedia.org/r/670933

Change 670937 had a related patch set uploaded (by CRusnov; owner: CRusnov):
[operations/puppet@production] proxylistener.py: Port to Python 3

https://gerrit.wikimedia.org/r/670937

Change 670938 had a related patch set uploaded (by CRusnov; owner: CRusnov):
[operations/puppet@production] check_pybal_ipvs_diff.py: Port to Python 3

https://gerrit.wikimedia.org/r/670938

Change 670952 had a related patch set uploaded (by CRusnov; owner: CRusnov):
[operations/puppet@production] pybal-eval-check.py: Port to Python 3

https://gerrit.wikimedia.org/r/670952

Change 670970 had a related patch set uploaded (by CRusnov; owner: CRusnov):
[operations/puppet@production] rabbitmqadmin.py: Port to Python 3

https://gerrit.wikimedia.org/r/670970

Change 670972 had a related patch set uploaded (by CRusnov; owner: CRusnov):
[operations/puppet@production] check-raid.py: Port to Python 3

https://gerrit.wikimedia.org/r/670972

Change 670973 had a related patch set uploaded (by CRusnov; owner: CRusnov):
[operations/puppet@production] get-raid-status-megacli.py: Port to Python 3

https://gerrit.wikimedia.org/r/670973

Change 670975 had a related patch set uploaded (by CRusnov; owner: CRusnov):
[operations/puppet@production] mwgrep.py: Port to Python 3

https://gerrit.wikimedia.org/r/670975

Change 670977 had a related patch set uploaded (by CRusnov; owner: CRusnov):
[operations/puppet@production] update-ocsp.py: Port to Python 3

https://gerrit.wikimedia.org/r/670977

Change 670978 had a related patch set uploaded (by CRusnov; owner: CRusnov):
[operations/puppet@production] x509-bundle.py: Port to Python 3

https://gerrit.wikimedia.org/r/670978

Change 670981 had a related patch set uploaded (by CRusnov; owner: CRusnov):
[operations/puppet@production] swift-account-stats.py: Port to Python 3

https://gerrit.wikimedia.org/r/670981

Change 670982 had a related patch set uploaded (by CRusnov; owner: CRusnov):
[operations/puppet@production] swift-container-stats.py: Port to Python 3

https://gerrit.wikimedia.org/r/670982

Change 670983 had a related patch set uploaded (by CRusnov; owner: CRusnov):
[operations/puppet@production] swift-dispersion-stats.py: Port to Python 3

https://gerrit.wikimedia.org/r/670983

Change 670984 had a related patch set uploaded (by CRusnov; owner: CRusnov):
[operations/puppet@production] swift-drive-audit.py: Port to Python 3

https://gerrit.wikimedia.org/r/670984

Change 670985 had a related patch set uploaded (by CRusnov; owner: CRusnov):
[operations/puppet@production] cipher_sim.py: Port to Python 3

https://gerrit.wikimedia.org/r/670985

Change 670989 had a related patch set uploaded (by CRusnov; owner: CRusnov):
[operations/puppet@production] cachestats.py: Port to Python 3

https://gerrit.wikimedia.org/r/670989

Change 670990 had a related patch set uploaded (by CRusnov; owner: CRusnov):
[operations/puppet@production] zuul-gearman.py: Port to Python 3

https://gerrit.wikimedia.org/r/670990

Change 628436 merged by CRusnov:
[operations/puppet@production] modules/tcpircbot: Port to Python3

https://gerrit.wikimedia.org/r/628436

Change 670975 abandoned by CRusnov:
[operations/puppet@production] mwgrep.py: Port to Python 3

Reason:
Superseded by https://gerrit.wikimedia.org/r/q/I51ba05f2537b4c068a0150c22fc00920a9f70edb

https://gerrit.wikimedia.org/r/670975

Change 674684 had a related patch set uploaded (by RhinosF1; author: RhinosF1):
[operations/puppet@production] Switch firejail-convert to python3

https://gerrit.wikimedia.org/r/674684

Change 674684 merged by Jbond:
[operations/puppet@production] Switch firejail-convert to python3

https://gerrit.wikimedia.org/r/674684

Thank you for taking care of the Python 3 migration in Puppet !

I ran into this bytes-vs-strings problem with raid_handler.py (or similar/related) in T278908: Degraded RAID on logstash2022, specifically the command output has literal \n instead of newlines:

CRITICAL: State: degraded, Active: 7, Working: 7, Failed: 0, Spare: 0

$ sudo /usr/local/lib/nagios/plugins/get-raid-status-md
b'Personalities : [linear] [multipath] [raid0] [raid1] [raid6] [raid5] [raid4] [raid10] \nmd1 : active raid0 sda3[0] sdd3[3] sdc3[2] sdb3[1]\n      15432220672 blocks super 1.2 512k chunks\n      \nmd0 : active raid1 sda2[0] sdd2[3] sdb2[1]\n      48794624 blocks super 1.2 [4/3] [UU_U]\n      \nunused devices: <none>\n'

Change 676009 had a related patch set uploaded (by Jbond; author: John Bond):

[operations/puppet@production] icinga: fix string encoding on raid_handler port py3 port

https://gerrit.wikimedia.org/r/676009

Change 676009 merged by Jbond:

[operations/puppet@production] icinga: fix string encoding on raid_handler port py3 port

https://gerrit.wikimedia.org/r/676009

  • added my full working todo list for this project

@crusnov Could you please take modules/raid/files/check-raid.py with precedence? It's part of a Bullseye base install and thus affected by it's lack of Python 2.

@crusnov Could you please take modules/raid/files/check-raid.py with precedence? It's part of a Bullseye base install and thus affected by it's lack of Python 2.

Certainly, there is a patch out for it, I'll round that up in the next day or two.

Change 670990 merged by Jbond:

[operations/puppet@production] zuul-gearman.py: Port to Python 3

https://gerrit.wikimedia.org/r/670990

Change 670978 merged by Jbond:

[operations/puppet@production] x509-bundle.py: Port to Python 3

https://gerrit.wikimedia.org/r/670978

Change 670972 merged by Jbond:

[operations/puppet@production] check-raid.py: Port to Python 3

https://gerrit.wikimedia.org/r/670972

Change 683133 had a related patch set uploaded (by Jbond; author: Jbond):

[operations/puppet@production] x509-bundle.py: Port to Python 3

https://gerrit.wikimedia.org/r/683133

Change 683133 merged by Jbond:

[operations/puppet@production] x509-bundle.py: Port to Python 3

https://gerrit.wikimedia.org/r/683133

I merged a couple of changes today, just a note that subprocess.Popen (and all the functions which inturn call this) dos not support the text=True option untill python 3.7 (buster) so we need to use universal_newlines=True instead for any scripts which need to run on debian < buster

Change 662765 merged by Muehlenhoff:

[operations/puppet@production] openldap/offboard-user.py: Port to Python 3

https://gerrit.wikimedia.org/r/662765

Change 692251 had a related patch set uploaded (by Muehlenhoff; author: Muehlenhoff):

[operations/puppet@production] Revert "openldap/offboard-user.py: Port to Python 3"

https://gerrit.wikimedia.org/r/692251

Change 692251 merged by Muehlenhoff:

[operations/puppet@production] Revert "openldap/offboard-user.py: Port to Python 3"

https://gerrit.wikimedia.org/r/692251

Change 670981 abandoned by Filippo Giunchedi:

[operations/puppet@production] swift-account-stats.py: Port to Python 3

Reason:

This happened in I2bc8141e82

https://gerrit.wikimedia.org/r/670981

Change 670970 merged by Andrew Bogott:

[operations/puppet@production] rabbitmqadmin.py: Update to latest available upstream version

https://gerrit.wikimedia.org/r/670970

Change 670928 merged by Andrew Bogott:

[operations/puppet@production] wmcs-spreadcheck.py: Port to Python 3

https://gerrit.wikimedia.org/r/670928

Change 670925 merged by Andrew Bogott:

[operations/puppet@production] check_keystone_roles.py: Port to Python 3

https://gerrit.wikimedia.org/r/670925

Change 658414 merged by Jbond:

[operations/puppet@production] confd/confd-lint-wrap.py: Port for Python 3

https://gerrit.wikimedia.org/r/658414

Change 670933 merged by Andrew Bogott:

[operations/puppet@production] wmcs-webproxy.py: Port to Python 3

https://gerrit.wikimedia.org/r/670933

Change 670922 merged by Dzahn:

[operations/puppet@production] modules/beta/files/wmf-beta-update-databases.py: Port to Python 3

https://gerrit.wikimedia.org/r/670922

Change 743387 had a related patch set uploaded (by Jbond; author: jbond):

[operations/puppet@production] C:ldap::client::utils: Update to python3

https://gerrit.wikimedia.org/r/743387

Change 743387 merged by Jbond:

[operations/puppet@production] C:ldap::client::utils: Update to python3

https://gerrit.wikimedia.org/r/743387