Page MenuHomePhabricator
Create Task
Maniphest T247364

Forward port Python2 files to Python3 in Puppet Repository
Closed, DeclinedPublic
Actions

Description

This will be an essential project to make our systems future safe against Python2 going away.

This is intended to be a tracking task, each file or set of files may be its own complicated project depending. Many may just work as-is also.

statuscommentfile
erbportmodules/beta/templates/wmf-beta-autoupdate.py.erb
erbportmodules/profile/templates/hadoop/net-topology.py.erb
erbportmodules/profile/templates/hive/client/beeline_wrapper.py.erb
nochangedoes not pass python3 pep8modules/openstack/files/designate/designatemakedomain.py
nochangepasses python3 pep8modules/openstack/files/monitor/fullstack/check_nova_fullstack_leaks.py
nochangedoes not pass python3 pep8modules/openstack/files/puppet/master/instance-info-dumper.py
nochangedoes not pass python3 pep8modules/openstack/files/util/wmcs-updateproxies.py
nochangedoes not pass python3 pep8modules/profile/files/toolforge/portgrabber_cli.py
nochangedoes not pass python3 pep8modules/profile/files/toolforge/portreleaser.py
nochangedoes not pass python3 pep8modules/prometheus/files/usr/local/bin/prometheus-gdnsd-stats.py
nochangedoes not pass python3 pep8modules/puppetmaster/files/validatelabsfqdn.py
nochangedoes not pass python3 pep8modules/swift/files/SwiftMedia/wmf/rewrite_integration_test.py
nochangepasses python3 pep8utils/vcl_ec2_nets.py
nochange/reviewedpasses python3 pep8 and reviewed but untestedmodules/etcd/files/etcd-backup.py
nochange/reviewedpasses python3 pep8 and reviewed but untestedmodules/graphite/files/archive-instances.py
nochange/reviewedpasses python3 pep8 and reviewed but untestedmodules/mediawiki/files/mediawiki-firejail-convert.py
nochange/reviewedpasses python3 pep8 and reviewed but untestedmodules/mediawiki/files/mediawiki-firejail-ffmpeg.py
nochange/reviewedpasses python3 pep8 and reviewed but untestedmodules/mediawiki/files/mediawiki-firejail-ghostscript.py
nochange/untestedpasses python3 pep8modules/cassandra/files/cassandra-ca-manager.py
nochange/untestedpasses python3 pep8modules/cdh/files/hadoop/check_hdfs_active_namenode.py
nochange/untestedpasses python3 pep8modules/ldap/files/scripts/add-ldap-group.py
nochange/untestedpasses python3 pep8modules/letsencrypt/files/acme-setup.py
nochange/untestedpasses python3 pep8 / already python3 compatmodules/letsencrypt/files/acme_tiny.py
patchout/removemoritz has indicated that it probably will be removedmodules/base/files/monitoring/check-fresh-files-in-dir.py
patchoutmodules/beta/files/wmf-beta-update-databases.py
patchoutmodules/burrow/files/check_kafka_consumer_lag.py
patchoutmodules/confd/files/confd-lint-wrap.py
portedmodules/interface/files/interface-rps.py
patchoutmodules/ircecho/files/ircecho.py
patchoutmodules/mw_rc_irc/files/udpmxircecho.py
neededmodules/openldap/files/offboard-user.py
patchoutmodules/openstack/files/monitor/keystone/check_keystone_roles.py
patchoutmodules/openstack/files/monitor/wmcs-spreadcheck.py
patchoutmodules/openstack/files/util/wmcs-webproxy.py
patchoutmodules/phabricator/files/phab_epipe.py
removedmodules/profile/files/labs/db/views/maintain-meta_p.py
patchoutmodules/profile/files/toolforge/proxylistener.py
patchoutmodules/pybal/files/check_pybal_ipvs_diff.py
patchoutmodules/pybal/files/pybal-eval-check.py
patchoutmodules/rabbitmq/files/rabbitmqadmin.py
portedmodules/raid/files/check-raid.py
patchoutmodules/raid/files/get-raid-status-megacli.py
willnoportowners are portingmodules/scap/files/mwgrep.py
patchoutmodules/sslcert/files/update-ocsp.py
patchoutmodules/sslcert/files/x509-bundle.py
patchoutmodules/swift/files/swift-account-stats.py
patchoutmodules/swift/files/swift-container-stats.py
patchoutmodules/swift/files/swift-dispersion-stats.py
patchoutmodules/swift/files/swift-drive-audit.py
portedmodules/tcpircbot/files/tcpircbot.py
patchoutmodules/tlsproxy/files/utils/cipher_sim.py
patchoutmodules/varnish/files/cachestats.py
patchoutmodules/zuul/files/zuul-gearman.pya
portedmodules/base/files/apt-upgrade-activity.py
portedmodules/base/files/check_systemd_state.py
portedmodules/base/files/firewall/check_conntrack.py
portedmodules/base/files/phaste.py
portedmodules/elasticsearch/files/es-tool.py
portedmodules/icinga/files/check_legal_html.py
portedmodules/icinga/files/check_ripe_atlas.py
portedmodules/icinga/files/purge-nagios-resources.py
portedmodules/icinga/files/raid_handler.py
portedmodules/labstore/files/logcleanup.py
portedmodules/ldap/files/rewrite-group-for-memberof.py
portedmodules/nagios_common/files/check_commands/check_grafana_alert.py
portedmodules/nagios_common/files/check_commands/check_graphite_freshness.py
portedmodules/nagios_common/files/check_commands/check_graphite.py
porteddone by kunalmodules/openldap/files/cross-validate-accounts.py
portedported by Andrew Bogottmodules/openstack/files/nova/fullstack/nova_fullstack_test.py
porteddone by someone elsemodules/openstack/files/util/wmcs-wikireplica-dns.py
portedmodules/service/files/logstash_checker.py
portedkunal ported thismodules/zuul/files/zuul-test-repo.py
ported/externalmodules/base/files/labs/puppet_alert.py
ported/externalbrook did thiswork modules/base/files/labs/notify_maintainers.py
removedported, later removed as unusedmodules/admin/data/nda_audit.py
removedported, later rewritten by jbond in python3modules/diffscan/files/diffscan.py
removedported, later removed as replaced by cookbookmodules/drac/files/drac.py
removedmodules/librenms/files/purge.py
removedremoved in f90ba7e7e6modules/openstack/files/monitor/keystone/check_keystone_projects.py
removedmodules/openstack/files/queens/admin_scripts/wmcs-cold-migrate.py
removeddoes not pass python3 pep8modules/openstack/files/queens/admin_scripts/wmcs-cold-nova-migrate.py
removeddoes not pass python3 pep8modules/openstack/files/queens/admin_scripts/wmcs-live-migrate.py
removedmodules/openstack/files/queens/admin_scripts/wmcs-logstat.py
removeddoes not pass python3 pep8modules/openstack/files/queens/admin_scripts/wmcs-makedomain.py
removedmodules/openstack/files/queens/admin_scripts/wmcs-novastats/wmcs-novastats-capacity.py
removedmodules/openstack/files/queens/admin_scripts/wmcs-novastats/wmcs-novastats-dnsleaks.py
removedmodules/openstack/files/queens/admin_scripts/wmcs-novastats/wmcs-novastats-flavorreport.py
removedmodules/openstack/files/queens/admin_scripts/wmcs-novastats/wmcs-novastats-imagestats.py
removedmodules/openstack/files/queens/admin_scripts/wmcs-novastats/wmcs-novastats-proxyleaks.py
removedmodules/openstack/files/queens/admin_scripts/wmcs-novastats/wmcs-novastats-puppetleaks.py
removedmodules/openstack/files/queens/admin_scripts/wmcs-region-migrate.py
removedmodules/openstack/files/queens/admin_scripts/wmcs-region-migrate-quotas.py
removedmodules/openstack/files/queens/admin_scripts/wmcs-region-migrate-security-groups.py
removedmodules/openstack/files/queens/admin_scripts/wmcs-wikitech-grep.py
removedmodules/openstack/files/rocky/admin_scripts/wmcs-cold-migrate.py
removeddoes not pass python3 pep8modules/openstack/files/rocky/admin_scripts/wmcs-cold-nova-migrate.py
removeddoes not pass python3 pep8modules/openstack/files/rocky/admin_scripts/wmcs-live-migrate.py
removedmodules/openstack/files/rocky/admin_scripts/wmcs-logstat.py
removeddoes not pass python3 pep8modules/openstack/files/rocky/admin_scripts/wmcs-makedomain.py
removedmodules/openstack/files/rocky/admin_scripts/wmcs-novastats/wmcs-novastats-capacity.py
removedmodules/openstack/files/rocky/admin_scripts/wmcs-novastats/wmcs-novastats-dnsleaks.py
removedmodules/openstack/files/rocky/admin_scripts/wmcs-novastats/wmcs-novastats-imagestats.py
removedmodules/openstack/files/rocky/admin_scripts/wmcs-novastats/wmcs-novastats-proxyleaks.py
removedmodules/openstack/files/rocky/admin_scripts/wmcs-novastats/wmcs-novastats-puppetleaks.py
removedmodules/openstack/files/rocky/admin_scripts/wmcs-region-migrate.py
removedmodules/openstack/files/rocky/admin_scripts/wmcs-region-migrate-quotas.py
removedmodules/openstack/files/rocky/admin_scripts/wmcs-region-migrate-security-groups.py
removedmodules/openstack/files/rocky/admin_scripts/wmcs-wikitech-grep.py
removedmodules/profile/files/toolforge/gridscripts/runninggridjobsmail.py
removedmodules/profile/files/toolforge/gridscripts/runninggridtasks.py
removedmodules/sentry/files/sentry-auth.py
removedmodules/shinken/files/shinkengen.py
willnotporttargets jessie specificallymodules/graphite/files/graphite-auth.jessie.py
willnotporttargets stretch specificallymodules/graphite/files/graphite-auth.stretch.py
willnotporttargets jessie specificallymodules/graphite/files/graphite-index.jessie.py
willnotporttargets stretch specificallymodules/graphite/files/graphite-index.stretch.py
willnotportport work done, deprecated since 2015 T114063modules/ldap/files/scripts/ldaplist.py
willnotportport work done, deprecated since 2015 T114063modules/ldap/files/scripts/ldapsupportlib.py
willnotporttargets python2 specificallymodules/ldap/files/scripts/ssh-key-ldap-lookup-python2.py

Details

SubjectRepoBranchLines +/-
phabricator/phab_epipe.py: Port to Python 3operations/puppetproduction+7 -7
cipher_sim.py: Port to Python 3operations/puppetproduction+4 -5
burrow/check_kafka_consumer_lag.py: Port to Python 3operations/puppetproduction+18 -15
C:ldap::client::utils: Update to python3operations/puppetproduction+11 -12
modules/beta/files/wmf-beta-update-databases.py: Port to Python 3operations/puppetproduction+1 -1
wmcs-webproxy.py: Port to Python 3operations/puppetproduction+3 -4
confd/confd-lint-wrap.py: Port for Python 3operations/puppetproduction+5 -4
check_keystone_roles.py: Port to Python 3operations/puppetproduction+2 -2
wmcs-spreadcheck.py: Port to Python 3operations/puppetproduction+3 -4
rabbitmqadmin.py: Update to latest available upstream versionoperations/puppetproduction+365 -171
swift-account-stats.py: Port to Python 3operations/puppetproduction+7 -5
Revert "openldap/offboard-user.py: Port to Python 3"operations/puppetproduction+13 -11
openldap/offboard-user.py: Port to Python 3operations/puppetproduction+11 -13
x509-bundle.py: Port to Python 3operations/puppetproduction+4 -4
x509-bundle.py: Port to Python 3operations/puppetproduction+4 -4
check-raid.py: Port to Python 3operations/puppetproduction+40 -40
zuul-gearman.py: Port to Python 3operations/puppetproduction+5 -5
icinga: fix string encoding on raid_handler port py3 portoperations/puppetproduction+1 -1
Switch firejail-convert to python3operations/puppetproduction+1 -1
mwgrep.py: Port to Python 3operations/puppetproduction+6 -7
ircecho: port to Python 3operations/puppetproduction+21 -10
update-ocsp.py: Port to Python 3operations/puppetproduction+8 -7
get-raid-status-megacli.py: Port to Python 3operations/puppetproduction+9 -11
pybal-eval-check.py: Port to Python 3operations/puppetproduction+10 -11
check_pybal_ipvs_diff.py: Port to Python 3operations/puppetproduction+5 -5
proxylistener.py: Port to Python 3operations/puppetproduction+8 -7
modules/tcpircbot: Port to Python3operations/puppetproduction+8 -9
base/monitoring/check-fresh-files-in-dir.py: Port to Python3operations/puppetproduction+5 -5
cachestats.py: Port to Python 3operations/puppetproduction+3 -3
swift-drive-audit.py: Port to Python 3operations/puppetproduction+4 -4
swift-dispersion-stats.py: Port to Python 3operations/puppetproduction+12 -12
swift-container-stats.py: Port to Python 3operations/puppetproduction+8 -8
mw_rc_irc/udpmxircecho.py: port to Python 3operations/puppetproduction+9 -13
ldap/rewrite-group-for-memberof.py: Port for Python 3operations/puppetproduction+8 -7
ldap/ldapsupportlib.py: Adjust for Python 3operations/puppetproduction+2 -2
ldap/ldaplist.py: Port for Python 3operations/puppetproduction+29 -29
modules/interface/files/interface-rps.py: Adapt for Python3operations/puppetproduction+6 -6
check_graphite.py: Port to Python 3operations/puppetproduction+14 -21
check_graphite_freshness.py: Port to Python 3operations/puppetproduction+5 -9
check_grafana_alert.py: Port to Python 3operations/puppetproduction+6 -11
labstore/files/logcleanup.py: Port to Python3operations/puppetproduction+6 -6
modules/icinga/files/raid_handler.py: Port to Python 3operations/puppetproduction+6 -6
check_ripe_atlas.py: Port to Python3operations/puppetproduction+29 -28
Port elasticsearch/es-tool.py to Python3operations/puppetproduction+75 -76
icinga/raid.pp: Add Python3 requirements for raid_handler.pyoperations/puppetproduction+1 -3
modules/icinga/files/raid_handler.py: Port to Python 3operations/puppetproduction+5 -5
purge-nagios-resources.py: Port to Python 3operations/puppetproduction+4 -4
Port drac.py to Python3operations/puppetproduction+15 -15
Port elasticsearch/es-tool.py to Python3operations/puppetproduction+70 -71
icinga/check_legal_html.py: Port to Python3operations/puppetproduction+36 -35
base/firewall/check_conntrack.py: Port to Python3operations/puppetproduction+3 -4
base/phaste.py: Port to Python 3operations/puppetproduction+10 -13
diffscan.py: Port to Python3operations/puppetproduction+8 -8
base/check_systemd_state.py: Fix encoding issueoperations/puppetproduction+2 -2
base/check_systemd_state.py: Decode bytes before stripoperations/puppetproduction+1 -1
base/check_systemd_state.py: Switch header to Python 3operations/puppetproduction+1 -1
modules/admin/data/nda_audit.py: Port to Python3operations/puppetproduction+13 -11
modules/service/files/logstash_checker.py: Move to Python3operations/puppetproduction+3 -7
Remove obsolete nda_audit scriptoperations/puppetproduction+0 -172
toolforge grid: Remove some old scripts we don't use anymoreoperations/puppetproduction+7 -205
base/apt-upgrade-activity.py: Port to Python3operations/puppetproduction+8 -9
toolforge/gridscripts/runninggridtasks.py: Fix Python3 PEP8 Warningoperations/puppetproduction+4 -4
base/apt-upgrade-activity.py: Port to Python3operations/puppetproduction+9 -10
data_admin: delete this file it seems to be unusedoperations/puppetproduction+0 -27
Show related patches Customize query in gerrit

Related Objects
Search...

Event Timeline

There are a very large number of changes, so older changes are hidden. Show Older Changes
gerritbot added a comment.Dec 1 2020, 4:12 PM

Change 644372 merged by CRusnov:
[operations/puppet@production] icinga/check_legal_html.py: Port to Python3

https://gerrit.wikimedia.org/r/644372

gerritbot added a comment.Dec 1 2020, 4:46 PM

Change 644365 merged by CRusnov:
[operations/puppet@production] Port elasticsearch/es-tool.py to Python3

https://gerrit.wikimedia.org/r/644365

gerritbot added a comment.Dec 1 2020, 6:40 PM

Change 644591 had a related patch set uploaded (by CRusnov; owner: CRusnov):
[operations/puppet@production] Port elasticsearch/es-tool.py to Python3

https://gerrit.wikimedia.org/r/644591

gerritbot added a comment.Dec 8 2020, 1:34 AM

Change 646879 had a related patch set uploaded (by CRusnov; owner: CRusnov):
[operations/puppet@production] check_ripe_atlas.py: Port to Python3

https://gerrit.wikimedia.org/r/646879

gerritbot added a comment.Dec 8 2020, 2:00 AM

Change 646884 had a related patch set uploaded (by CRusnov; owner: CRusnov):
[operations/puppet@production] purge-nagios-resources.py: Port to Python 3

https://gerrit.wikimedia.org/r/646884

gerritbot added a comment.Dec 8 2020, 2:32 AM

Change 646890 had a related patch set uploaded (by CRusnov; owner: CRusnov):
[operations/puppet@production] modules/icinga/files/raid_handler.py: Port to Python 3

https://gerrit.wikimedia.org/r/646890

gerritbot added a comment.Dec 8 2020, 6:59 PM

Change 646884 merged by CRusnov:
[operations/puppet@production] purge-nagios-resources.py: Port to Python 3

https://gerrit.wikimedia.org/r/646884

gerritbot added a comment.Dec 9 2020, 4:37 PM

Change 646890 merged by CRusnov:
[operations/puppet@production] modules/icinga/files/raid_handler.py: Port to Python 3

https://gerrit.wikimedia.org/r/646890

gerritbot added a comment.Dec 9 2020, 9:44 PM

Change 647364 had a related patch set uploaded (by CRusnov; owner: CRusnov):
[operations/puppet@production] icinga/raid.pp: Add Python3 requirements for raid_handler.py

https://gerrit.wikimedia.org/r/647364

gerritbot added a comment.Dec 9 2020, 10:00 PM

Change 647364 merged by CRusnov:
[operations/puppet@production] icinga/raid.pp: Add Python3 requirements for raid_handler.py

https://gerrit.wikimedia.org/r/647364

gerritbot added a comment.Dec 9 2020, 10:17 PM

Change 647369 had a related patch set uploaded (by CRusnov; owner: CRusnov):
[operations/puppet@production] modules/icinga/files/raid_handler.py: Port to Python 3

https://gerrit.wikimedia.org/r/647369

gerritbot added a comment.Dec 30 2020, 6:40 PM

Change 652575 had a related patch set uploaded (by CRusnov; owner: CRusnov):
[operations/puppet@production] modules/interface/files/interface-rps.py: Adapt for Python3

https://gerrit.wikimedia.org/r/652575

gerritbot added a comment.Jan 4 2021, 5:31 PM

Change 644591 merged by CRusnov:
[operations/puppet@production] Port elasticsearch/es-tool.py to Python3

https://gerrit.wikimedia.org/r/644591

gerritbot added a comment.Jan 4 2021, 5:31 PM

Change 646879 merged by CRusnov:
[operations/puppet@production] check_ripe_atlas.py: Port to Python3

https://gerrit.wikimedia.org/r/646879

gerritbot added a comment.Jan 4 2021, 5:32 PM

Change 647369 merged by CRusnov:
[operations/puppet@production] modules/icinga/files/raid_handler.py: Port to Python 3

https://gerrit.wikimedia.org/r/647369

gerritbot added a comment.Jan 5 2021, 12:02 AM

Change 654336 had a related patch set uploaded (by CRusnov; owner: CRusnov):
[operations/puppet@production] ircecho: port to Python 3

https://gerrit.wikimedia.org/r/654336

gerritbot added a comment.Jan 5 2021, 12:20 AM

Change 654339 had a related patch set uploaded (by CRusnov; owner: CRusnov):
[operations/puppet@production] labstore/files/logcleanup.py: Port to Python3

https://gerrit.wikimedia.org/r/654339

gerritbot added a comment.Jan 5 2021, 9:51 PM

Change 654339 merged by CRusnov:
[operations/puppet@production] labstore/files/logcleanup.py: Port to Python3

https://gerrit.wikimedia.org/r/654339

gerritbot added a comment.Jan 12 2021, 6:49 PM

Change 655731 had a related patch set uploaded (by CRusnov; owner: CRusnov):
[operations/puppet@production] check_grafana_alert.py: Port to Python 3

https://gerrit.wikimedia.org/r/655731

gerritbot added a comment.Jan 12 2021, 6:53 PM

Change 655733 had a related patch set uploaded (by CRusnov; owner: CRusnov):
[operations/puppet@production] check_graphite_freshness.py: Port to Python 3

https://gerrit.wikimedia.org/r/655733

gerritbot added a comment.Jan 12 2021, 7:00 PM

Change 655734 had a related patch set uploaded (by CRusnov; owner: CRusnov):
[operations/puppet@production] check_graphite.py: Port to Python 3

https://gerrit.wikimedia.org/r/655734

gerritbot added a comment.Jan 12 2021, 7:48 PM

Change 655743 had a related patch set uploaded (by CRusnov; owner: CRusnov):
[operations/puppet@production] phabricator/phab_epipe.py: Port to Python 3

https://gerrit.wikimedia.org/r/655743

gerritbot added a comment.Jan 25 2021, 5:08 PM

Change 658360 had a related patch set uploaded (by CRusnov; owner: CRusnov):
[operations/puppet@production] ldap/ldapsupportlib.py: Adjust for Python 3

https://gerrit.wikimedia.org/r/658360

gerritbot added a comment.Jan 25 2021, 5:34 PM

Change 658396 had a related patch set uploaded (by CRusnov; owner: CRusnov):
[operations/puppet@production] burrow/check_kafka_consumer_lag.py: Port to Python 3

https://gerrit.wikimedia.org/r/658396

gerritbot added a comment.Jan 25 2021, 7:39 PM

Change 658414 had a related patch set uploaded (by CRusnov; owner: CRusnov):
[operations/puppet@production] confd/confd-lint-wrap.py: Port for Python 3

https://gerrit.wikimedia.org/r/658414

gerritbot added a comment.Jan 25 2021, 7:47 PM

Change 658415 had a related patch set uploaded (by CRusnov; owner: CRusnov):
[operations/puppet@production] ldap/rewrite-group-for-memberof.py: Port for Python 3

https://gerrit.wikimedia.org/r/658415

gerritbot added a comment.Jan 25 2021, 9:07 PM

Change 658427 had a related patch set uploaded (by CRusnov; owner: CRusnov):
[operations/puppet@production] ldap/ldaplist.py: Port for Python 3

https://gerrit.wikimedia.org/r/658427

gerritbot added a comment.Feb 2 2021, 9:33 PM

Change 655731 merged by CRusnov:
[operations/puppet@production] check_grafana_alert.py: Port to Python 3

https://gerrit.wikimedia.org/r/655731

gerritbot added a comment.Feb 2 2021, 9:42 PM

Change 655733 merged by CRusnov:
[operations/puppet@production] check_graphite_freshness.py: Port to Python 3

https://gerrit.wikimedia.org/r/655733

gerritbot added a comment.Feb 2 2021, 9:49 PM

Change 655734 merged by CRusnov:
[operations/puppet@production] check_graphite.py: Port to Python 3

https://gerrit.wikimedia.org/r/655734

gerritbot added a comment.Feb 2 2021, 9:50 PM

Change 652575 merged by CRusnov:
[operations/puppet@production] modules/interface/files/interface-rps.py: Adapt for Python3

https://gerrit.wikimedia.org/r/652575

gerritbot added a comment.Feb 4 2021, 6:54 PM

Change 658415 merged by CRusnov:
[operations/puppet@production] ldap/rewrite-group-for-memberof.py: Port for Python 3

https://gerrit.wikimedia.org/r/658415

gerritbot added a comment.Feb 8 2021, 7:54 PM

Change 662764 had a related patch set uploaded (by CRusnov; owner: CRusnov):
[operations/puppet@production] mw_rc_irc/udpmxircecho.py: port to Python 3

https://gerrit.wikimedia.org/r/662764

gerritbot added a comment.Feb 8 2021, 8:08 PM

Change 662765 had a related patch set uploaded (by CRusnov; owner: CRusnov):
[operations/puppet@production] openldap/offboard-user.py: Port to Python 3

https://gerrit.wikimedia.org/r/662765

• crusnov moved this task from Backlog to In Progress on the User-crusnov board.Feb 23 2021, 4:40 PM
gerritbot added a comment.Mar 11 2021, 7:47 PM

Change 670922 had a related patch set uploaded (by CRusnov; owner: CRusnov):
[operations/puppet@production] modules/beta/files/wmf-beta-update-databases.py: Port to Python 3

https://gerrit.wikimedia.org/r/670922

gerritbot added a comment.Mar 11 2021, 7:52 PM

Change 670925 had a related patch set uploaded (by CRusnov; owner: CRusnov):
[operations/puppet@production] check_keystone_roles.py: Port to Python 3

https://gerrit.wikimedia.org/r/670925

gerritbot added a comment.Mar 11 2021, 7:58 PM

Change 670928 had a related patch set uploaded (by CRusnov; owner: CRusnov):
[operations/puppet@production] wmcs-spreadcheck.py: Port to Python 3

https://gerrit.wikimedia.org/r/670928

gerritbot added a comment.Mar 11 2021, 8:09 PM

Change 670933 had a related patch set uploaded (by CRusnov; owner: CRusnov):
[operations/puppet@production] wmcs-webproxy.py: Port to Python 3

https://gerrit.wikimedia.org/r/670933

gerritbot added a comment.Mar 11 2021, 8:21 PM

Change 670937 had a related patch set uploaded (by CRusnov; owner: CRusnov):
[operations/puppet@production] proxylistener.py: Port to Python 3

https://gerrit.wikimedia.org/r/670937

gerritbot added a comment.Mar 11 2021, 8:29 PM

Change 670938 had a related patch set uploaded (by CRusnov; owner: CRusnov):
[operations/puppet@production] check_pybal_ipvs_diff.py: Port to Python 3

https://gerrit.wikimedia.org/r/670938

gerritbot added a comment.Mar 11 2021, 9:23 PM

Change 670952 had a related patch set uploaded (by CRusnov; owner: CRusnov):
[operations/puppet@production] pybal-eval-check.py: Port to Python 3

https://gerrit.wikimedia.org/r/670952

gerritbot added a comment.Mar 11 2021, 10:53 PM

Change 670970 had a related patch set uploaded (by CRusnov; owner: CRusnov):
[operations/puppet@production] rabbitmqadmin.py: Port to Python 3

https://gerrit.wikimedia.org/r/670970

gerritbot added a comment.Mar 11 2021, 10:59 PM

Change 670972 had a related patch set uploaded (by CRusnov; owner: CRusnov):
[operations/puppet@production] check-raid.py: Port to Python 3

https://gerrit.wikimedia.org/r/670972

gerritbot added a comment.Mar 11 2021, 11:08 PM

Change 670973 had a related patch set uploaded (by CRusnov; owner: CRusnov):
[operations/puppet@production] get-raid-status-megacli.py: Port to Python 3

https://gerrit.wikimedia.org/r/670973

gerritbot added a comment.Mar 11 2021, 11:19 PM

Change 670975 had a related patch set uploaded (by CRusnov; owner: CRusnov):
[operations/puppet@production] mwgrep.py: Port to Python 3

https://gerrit.wikimedia.org/r/670975

gerritbot added a comment.Mar 11 2021, 11:23 PM

Change 670977 had a related patch set uploaded (by CRusnov; owner: CRusnov):
[operations/puppet@production] update-ocsp.py: Port to Python 3

https://gerrit.wikimedia.org/r/670977

gerritbot added a comment.Mar 11 2021, 11:24 PM

Change 670978 had a related patch set uploaded (by CRusnov; owner: CRusnov):
[operations/puppet@production] x509-bundle.py: Port to Python 3

https://gerrit.wikimedia.org/r/670978

gerritbot added a comment.Mar 11 2021, 11:37 PM

Change 670981 had a related patch set uploaded (by CRusnov; owner: CRusnov):
[operations/puppet@production] swift-account-stats.py: Port to Python 3

https://gerrit.wikimedia.org/r/670981

gerritbot added a comment.Mar 11 2021, 11:42 PM

Change 670982 had a related patch set uploaded (by CRusnov; owner: CRusnov):
[operations/puppet@production] swift-container-stats.py: Port to Python 3

https://gerrit.wikimedia.org/r/670982

gerritbot added a comment.Mar 11 2021, 11:45 PM

Change 670983 had a related patch set uploaded (by CRusnov; owner: CRusnov):
[operations/puppet@production] swift-dispersion-stats.py: Port to Python 3

https://gerrit.wikimedia.org/r/670983

gerritbot added a comment.Mar 11 2021, 11:47 PM

Change 670984 had a related patch set uploaded (by CRusnov; owner: CRusnov):
[operations/puppet@production] swift-drive-audit.py: Port to Python 3

https://gerrit.wikimedia.org/r/670984

gerritbot added a comment.Mar 11 2021, 11:50 PM

Change 670985 had a related patch set uploaded (by CRusnov; owner: CRusnov):
[operations/puppet@production] cipher_sim.py: Port to Python 3

https://gerrit.wikimedia.org/r/670985

gerritbot added a comment.Mar 12 2021, 12:20 AM

Change 670989 had a related patch set uploaded (by CRusnov; owner: CRusnov):
[operations/puppet@production] cachestats.py: Port to Python 3

https://gerrit.wikimedia.org/r/670989

gerritbot added a comment.Mar 12 2021, 12:21 AM

Change 670990 had a related patch set uploaded (by CRusnov; owner: CRusnov):
[operations/puppet@production] zuul-gearman.py: Port to Python 3

https://gerrit.wikimedia.org/r/670990

gerritbot added a comment.Mar 17 2021, 5:01 PM

Change 628436 merged by CRusnov:
[operations/puppet@production] modules/tcpircbot: Port to Python3

https://gerrit.wikimedia.org/r/628436

gerritbot added a comment.Mar 19 2021, 3:41 PM

Change 670975 abandoned by CRusnov:
[operations/puppet@production] mwgrep.py: Port to Python 3

Reason:
Superseded by https://gerrit.wikimedia.org/r/q/I51ba05f2537b4c068a0150c22fc00920a9f70edb

https://gerrit.wikimedia.org/r/670975

gerritbot added a comment.Mar 25 2021, 6:41 AM

Change 674684 had a related patch set uploaded (by RhinosF1; author: RhinosF1):
[operations/puppet@production] Switch firejail-convert to python3

https://gerrit.wikimedia.org/r/674684

gerritbot added a comment.Mar 29 2021, 1:13 PM

Change 674684 merged by Jbond:
[operations/puppet@production] Switch firejail-convert to python3

https://gerrit.wikimedia.org/r/674684

fgiunchedi subscribed.Mar 31 2021, 7:50 AM

Thank you for taking care of the Python 3 migration in Puppet !

I ran into this bytes-vs-strings problem with raid_handler.py (or similar/related) in T278908: Degraded RAID on logstash2022, specifically the command output has literal \n instead of newlines:

CRITICAL: State: degraded, Active: 7, Working: 7, Failed: 0, Spare: 0

$ sudo /usr/local/lib/nagios/plugins/get-raid-status-md
b'Personalities : [linear] [multipath] [raid0] [raid1] [raid6] [raid5] [raid4] [raid10] \nmd1 : active raid0 sda3[0] sdd3[3] sdc3[2] sdb3[1]\n      15432220672 blocks super 1.2 512k chunks\n      \nmd0 : active raid1 sda2[0] sdd2[3] sdb2[1]\n      48794624 blocks super 1.2 [4/3] [UU_U]\n      \nunused devices: <none>\n'
gerritbot added a comment.Mar 31 2021, 9:48 AM

Change 676009 had a related patch set uploaded (by Jbond; author: John Bond):

[operations/puppet@production] icinga: fix string encoding on raid_handler port py3 port

https://gerrit.wikimedia.org/r/676009

gerritbot added a comment.Mar 31 2021, 11:46 AM

Change 676009 merged by Jbond:

[operations/puppet@production] icinga: fix string encoding on raid_handler port py3 port

https://gerrit.wikimedia.org/r/676009

• crusnov added a subtask: T254480: Shell/Python/other scripts should not be generated by ERB files; dynamic parts should be a simple ERB config file.Mar 31 2021, 3:09 PM
• crusnov updated the task description. (Show Details)Mar 31 2021, 3:49 PM
  • added my full working todo list for this project
• MoritzMuehlenhoff added a comment.Apr 16 2021, 10:01 AM

@crusnov Could you please take modules/raid/files/check-raid.py with precedence? It's part of a Bullseye base install and thus affected by it's lack of Python 2.

• crusnov added a comment.Apr 16 2021, 3:28 PM
In T247364#7008439, @MoritzMuehlenhoff wrote:

@crusnov Could you please take modules/raid/files/check-raid.py with precedence? It's part of a Bullseye base install and thus affected by it's lack of Python 2.

Certainly, there is a patch out for it, I'll round that up in the next day or two.

gerritbot added a comment.Apr 27 2021, 2:01 PM

Change 670990 merged by Jbond:

[operations/puppet@production] zuul-gearman.py: Port to Python 3

https://gerrit.wikimedia.org/r/670990

gerritbot added a comment.Apr 28 2021, 10:38 AM

Change 670978 merged by Jbond:

[operations/puppet@production] x509-bundle.py: Port to Python 3

https://gerrit.wikimedia.org/r/670978

gerritbot added a comment.Apr 28 2021, 10:43 AM

Change 670972 merged by Jbond:

[operations/puppet@production] check-raid.py: Port to Python 3

https://gerrit.wikimedia.org/r/670972

gerritbot added a comment.Apr 28 2021, 10:55 AM

Change 683133 had a related patch set uploaded (by Jbond; author: Jbond):

[operations/puppet@production] x509-bundle.py: Port to Python 3

https://gerrit.wikimedia.org/r/683133

gerritbot added a comment.Apr 28 2021, 10:57 AM

Change 683133 merged by Jbond:

[operations/puppet@production] x509-bundle.py: Port to Python 3

https://gerrit.wikimedia.org/r/683133

jbond added a comment.Apr 28 2021, 11:36 AM

I merged a couple of changes today, just a note that subprocess.Popen (and all the functions which inturn call this) dos not support the text=True option untill python 3.7 (buster) so we need to use universal_newlines=True instead for any scripts which need to run on debian < buster

gerritbot added a comment.May 6 2021, 10:33 AM

Change 662765 merged by Muehlenhoff:

[operations/puppet@production] openldap/offboard-user.py: Port to Python 3

https://gerrit.wikimedia.org/r/662765

• MoritzMuehlenhoff updated the task description. (Show Details)May 6 2021, 10:35 AM
• MoritzMuehlenhoff updated the task description. (Show Details)
• MoritzMuehlenhoff added a project: SRE.May 6 2021, 10:37 AM
• MoritzMuehlenhoff removed • crusnov as the assignee of this task.May 17 2021, 8:05 AM
• MoritzMuehlenhoff updated the task description. (Show Details)
gerritbot added a comment.May 17 2021, 8:07 AM

Change 692251 had a related patch set uploaded (by Muehlenhoff; author: Muehlenhoff):

[operations/puppet@production] Revert "openldap/offboard-user.py: Port to Python 3"

https://gerrit.wikimedia.org/r/692251

gerritbot added a comment.May 17 2021, 8:20 AM

Change 692251 merged by Muehlenhoff:

[operations/puppet@production] Revert "openldap/offboard-user.py: Port to Python 3"

https://gerrit.wikimedia.org/r/692251

Aklapper added a project: Infrastructure-Foundations.Jun 21 2021, 8:59 PM
gerritbot added a comment.Jul 20 2021, 8:06 AM

Change 670981 abandoned by Filippo Giunchedi:

[operations/puppet@production] swift-account-stats.py: Port to Python 3

Reason:

This happened in I2bc8141e82

https://gerrit.wikimedia.org/r/670981

gerritbot added a comment.Aug 30 2021, 11:14 PM

Change 670970 merged by Andrew Bogott:

[operations/puppet@production] rabbitmqadmin.py: Update to latest available upstream version

https://gerrit.wikimedia.org/r/670970

gerritbot added a comment.Aug 30 2021, 11:16 PM

Change 670928 merged by Andrew Bogott:

[operations/puppet@production] wmcs-spreadcheck.py: Port to Python 3

https://gerrit.wikimedia.org/r/670928

gerritbot added a comment.Aug 30 2021, 11:21 PM

Change 670925 merged by Andrew Bogott:

[operations/puppet@production] check_keystone_roles.py: Port to Python 3

https://gerrit.wikimedia.org/r/670925

gerritbot added a comment.Aug 31 2021, 10:18 AM

Change 658414 merged by Jbond:

[operations/puppet@production] confd/confd-lint-wrap.py: Port for Python 3

https://gerrit.wikimedia.org/r/658414

gerritbot added a comment.Sep 1 2021, 4:05 AM

Change 670933 merged by Andrew Bogott:

[operations/puppet@production] wmcs-webproxy.py: Port to Python 3

https://gerrit.wikimedia.org/r/670933

gerritbot added a comment.Dec 2 2021, 7:27 PM

Change 670922 merged by Dzahn:

[operations/puppet@production] modules/beta/files/wmf-beta-update-databases.py: Port to Python 3

https://gerrit.wikimedia.org/r/670922

gerritbot added a comment.Dec 3 2021, 1:34 PM

Change 743387 had a related patch set uploaded (by Jbond; author: jbond):

[operations/puppet@production] C:ldap::client::utils: Update to python3

https://gerrit.wikimedia.org/r/743387

gerritbot added a comment.Dec 7 2021, 11:19 AM

Change 743387 merged by Jbond:

[operations/puppet@production] C:ldap::client::utils: Update to python3

https://gerrit.wikimedia.org/r/743387

Volans mentioned this in T211750: Introduce Python code formatters usage.Apr 14 2022, 10:40 PM
• MoritzMuehlenhoff closed this task as Declined.Nov 16 2022, 2:37 PM

This task was opened 2.5 years ago as part of work to systematically port scripts across puppet.git. Since then we have migrated half of our servers to Bullseye which no longer provides Python 2, so all affected scripts have been ported or removed, but this task wasn't necessarily updated along and it also doesn't feel useful to track this further. All remaining scripts will be ported as roles are moved away from Buster (or obsolete scripts removed).

gerritbot added a comment.Dec 1 2022, 2:15 PM

Change 670985 abandoned by BBlack:

[operations/puppet@production] cipher_sim.py: Port to Python 3

Reason:

File was removed in Ic786864ef068e674d485a587732b07ffd1308d28

https://gerrit.wikimedia.org/r/670985

BCornwall closed subtask T277910: Port dstat related scripts to Python 3 as Invalid.Dec 1 2022, 11:03 PM
SLyngshede-WMF closed subtask T254480: Shell/Python/other scripts should not be generated by ERB files; dynamic parts should be a simple ERB config file as Resolved.Jan 23 2024, 2:33 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits