Page MenuHomePhabricator

update.php should make things it actually changed stand out better in its report
Closed, DeclinedPublic


You know, looking at the output each time one runs update.php,

...category table already populated.
...have ar_parent_id field in archive table.
...have user_last_timestamp field in user_newtalk table.
...rev_parent_id column already populated.
protected_titles table has correct pt_title encoding.
Checking filearchive indices...
...have ss_active_users field in site_stats table.
...ss_active_users user count set...
...have rd_interwiki field in redirect table.
...transcache tc_time already converted.
Renaming eu_wiki_id -> eu_local_id... already done.
Altering all *_mime_minor fields to 100 bytes in size ... ok
Populating rev_len column
...doing rev_id from 943 to 1142

it is very hard to tell which lines

  • changed nothing, vs.
  • changed something

Apparently the last three lines above changed something. The rest changed nothing.

Even worse is if one is not a native English speaker, then reading
each line to figure out if it changed nothing vs. changed something is
even harder.

However don't get me wrong. I am not proposing translation work.
Instead I am just hoping that the lines that actually changed
something will stand out better, via indenting, prefixing, or

E.g., /var/log/Xorg.0.log has:

Markers: (--) probed, (**) from config file, (==) default setting,

(++) from command line, (!!) notice, (II) informational,
(WW) warning, (EE) error, (NI) not implemented, (??) unknown.

So perhaps just have a * prefix pre-pended to lines that changed
something, with of course a note at top saying what the * means.

Version: 1.17.x
Severity: enhancement



Event Timeline

bzimport raised the priority of this task from to Lowest.Nov 21 2014, 11:01 PM
bzimport set Reference to bz22753.
bzimport added a subscriber: Unknown Object (MLST).

At this point, all update steps that do nothing have been updated to begin with ...

I suppose you still want a message at the top saying what ... means?

Yeah. Or trade you the three dots for three other ASCIIs, like

apt-get update

Ign unstable/ InRelease
Hit unstable/ Release.gpg
Hit experimental/contrib i386 Packages/DiffIndex
Get:1 unstable/main i386 Packages [7,250 kB]
Ign experimental/iceweasel-4.0 Translation-en

which is somewhat better.

Most of this was already cleaned up... until Bug 32508 came along...