Page MenuHomePhabricator
Create Task
Maniphest T247777

Remove $wgProfileLimit
Closed, ResolvedPublic
Actions

Description

This has been deprecated since MW 1.25. Let's finish this.

Details

SubjectRepoBranchLines +/-
Remove $wgProfileLimit settingmediawiki/coremaster+8 -15
profiler: Improve $wgProfiler docs in DefaultSettings.phpmediawiki/coremaster+35 -33
filebackend: Fix undefined wgProfiler in FileBackendGroupTestmediawiki/coremaster+11 -0
Customize query in gerrit

Event Timeline

Krinkle created this task.Mar 16 2020, 5:17 PM
Restricted Application added a project: Performance-Team. · View Herald TranscriptMar 16 2020, 5:17 PM
Restricted Application added a subscriber: Aklapper. · View Herald Transcript
Krinkle added a parent task: T189966: Audit and simplify MediaWiki initialisation code (Spring 2018).Mar 16 2020, 5:17 PM
gerritbot added a comment.Mar 16 2020, 5:33 PM

Change 580085 had a related patch set uploaded (by Krinkle; owner: Krinkle):
[mediawiki/core@master] profiler: Improve $wgProfiler docs in DefaultSettings.php

https://gerrit.wikimedia.org/r/580085

gerritbot added a project: Patch-For-Review.Mar 16 2020, 5:33 PM

Change 580086 had a related patch set uploaded (by Krinkle; owner: Krinkle):
[mediawiki/core@master] Remove $wgProfileLimit setting

https://gerrit.wikimedia.org/r/580086

Krinkle claimed this task.Mar 16 2020, 5:33 PM
Krinkle triaged this task as Medium priority.
Krinkle added a parent task: T228895: 3% of load.php spent creating DBLoadBalancerFactory in WebStart.php.Mar 16 2020, 5:38 PM
Krinkle removed parent tasks: T228895: 3% of load.php spent creating DBLoadBalancerFactory in WebStart.php, T189966: Audit and simplify MediaWiki initialisation code (Spring 2018).
gerritbot added a comment.Mar 16 2020, 6:10 PM

Change 580100 had a related patch set uploaded (by Krinkle; owner: Krinkle):
[mediawiki/core@master] filebackend: Fix undefined wgProfiler in FileBackendGroupTest

https://gerrit.wikimedia.org/r/580100

• Gilles moved this task from Inbox, needs triage to Doing (old) on the Performance-Team board.Mar 16 2020, 9:27 PM
Krinkle reassigned this task from Krinkle to aaron.Mar 16 2020, 9:27 PM
Krinkle moved this task from Untriaged to <= 2015 / MW 1.26 on the Technical-Debt (Deprecation process) board.
gerritbot added a comment.Mar 18 2020, 4:44 PM

Change 580100 merged by jenkins-bot:
[mediawiki/core@master] filebackend: Fix undefined wgProfiler in FileBackendGroupTest

https://gerrit.wikimedia.org/r/580100

ReleaseTaggerBot added a project: MW-1.35-notes (1.35.0-wmf.25; 2020-03-24).Mar 19 2020, 8:47 PM
gerritbot added a comment.Mar 19 2020, 11:17 PM

Change 580085 merged by jenkins-bot:
[mediawiki/core@master] profiler: Improve $wgProfiler docs in DefaultSettings.php

https://gerrit.wikimedia.org/r/580085

gerritbot added a comment.Mar 19 2020, 11:17 PM

Change 580086 merged by jenkins-bot:
[mediawiki/core@master] Remove $wgProfileLimit setting

https://gerrit.wikimedia.org/r/580086

Maintenance_bot removed a project: Patch-For-Review.Mar 20 2020, 12:10 AM
Krinkle closed this task as Resolved.Mar 20 2020, 1:27 AM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits