Page MenuHomePhabricator
Create Task
Maniphest T248768

clientlogin seems to respond with badtoken instead of NeedToken or WrongToken; but site.tokens is empty when login
Closed, ResolvedPublicBUG REPORT
Actions

Details

SubjectRepoBranchLines +/-
[bugfix] Bail out early if login in progresspywikibot/coremaster+4 -3
[bugfix] Fix endless loop when badtokenpywikibot/coremaster+13 -14
[bugfix] Fix handling of badtoken response for login actionspywikibot/coremaster+6 -1
Customize query in gerrit

Related Objects
Search...

Event Timeline

Dvorapa created this task.Mar 29 2020, 12:14 AM
Restricted Application added a project: Pywikibot. · View Herald TranscriptMar 29 2020, 12:14 AM
Restricted Application added subscribers: pywikibot-bugs-list, Aklapper. · View Herald Transcript
Dvorapa added a parent task: T137805: API action=login is deprecated.Mar 29 2020, 12:14 AM
Dvorapa added a comment.Mar 29 2020, 12:16 AM

https://travis-ci.org/github/wikimedia/pywikibot/jobs/668204529#L9896

Dvorapa renamed this task from clientlogin seems to respond with badtoken instead of NeedToken or WrongToken; but site.tokens does not handle logintoken to clientlogin seems to respond with badtoken instead of NeedToken or WrongToken; but site.tokens is empty when login.Mar 29 2020, 3:07 AM
Dvorapa added a subtask: T248771: login() with retry=True might delete correct password if unknown APIError occurs.
gerritbot added a comment.Mar 29 2020, 12:00 PM

Change 584195 had a related patch set uploaded (by Dvorapa; owner: Dvorapa):
[pywikibot/core@master] [bugfix] Fix handling of badtoken response for login actions

https://gerrit.wikimedia.org/r/584195

gerritbot added a project: Patch-For-Review.Mar 29 2020, 12:00 PM
Xqt triaged this task as High priority.Mar 29 2020, 12:13 PM
gerritbot added a comment.Mar 29 2020, 12:41 PM

Change 584195 merged by jenkins-bot:
[pywikibot/core@master] [bugfix] Fix handling of badtoken response for login actions

https://gerrit.wikimedia.org/r/584195

Dvorapa mentioned this in rPWBCb8a8db90d624: [bugfix] Fix handling of badtoken response for login actions.Mar 29 2020, 12:49 PM
Maintenance_bot removed a project: Patch-For-Review.Mar 29 2020, 1:10 PM
Dvorapa closed this task as Resolved.Mar 30 2020, 12:35 AM
Dvorapa reopened this task as Open.
Dvorapa claimed this task.
Dvorapa moved this task from Backlog to Test failures on the Pywikibot-tests board.
Dvorapa changed the subtype of this task from "Task" to "Bug Report".
gerritbot added a comment.Mar 30 2020, 12:52 AM

Change 584269 had a related patch set uploaded (by Dvorapa; owner: Dvorapa):
[pywikibot/core@master] [bugfix] Fix minor endless loop when badtoken

https://gerrit.wikimedia.org/r/584269

gerritbot added a project: Patch-For-Review.Mar 30 2020, 12:52 AM
Dvorapa mentioned this in T248471: login() with retry=True might delete correct password if unknown APIError occurs.Mar 30 2020, 1:14 PM
gerritbot added a comment.Mar 30 2020, 2:27 PM

Change 584269 merged by jenkins-bot:
[pywikibot/core@master] [bugfix] Fix endless loop when badtoken

https://gerrit.wikimedia.org/r/584269

Dvorapa mentioned this in rPWBC983239158ea2: [bugfix] Fix endless loop when badtoken.Mar 30 2020, 2:27 PM
Dvorapa closed this task as Resolved.Mar 30 2020, 2:40 PM
Dvorapa removed a project: Patch-For-Review.
Dvorapa reopened this task as Open.Mar 30 2020, 4:47 PM

OMG, this step-by-step issue solving is a nightmare. Now badtoken raises APIError, which it haven't before. But we are close to the solution finally!

gerritbot added a comment.Mar 30 2020, 5:22 PM

Change 584634 had a related patch set uploaded (by Dvorapa; owner: Dvorapa):
[pywikibot/core@master] [bugfix] Bail out early if login in progress

https://gerrit.wikimedia.org/r/584634

gerritbot added a project: Patch-For-Review.Mar 30 2020, 5:22 PM
gerritbot added a comment.Mar 30 2020, 8:12 PM

Change 584634 merged by jenkins-bot:
[pywikibot/core@master] [bugfix] Bail out early if login in progress

https://gerrit.wikimedia.org/r/584634

Dvorapa mentioned this in rPWBC6761f9881ebb: [bugfix] Bail out early if login in progress.Mar 30 2020, 8:13 PM
Maintenance_bot removed a project: Patch-For-Review.Mar 30 2020, 9:10 PM
Dvorapa closed this task as Resolved.EditedMar 30 2020, 9:16 PM

Finally badtoken handled properly

Xqt removed a subtask: T248771: login() with retry=True might delete correct password if unknown APIError occurs.May 4 2023, 3:30 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL