Page MenuHomePhabricator

Make testing-access-wrapper compatible with PHP8
Closed, ResolvedPublic

Description

ReflectionProperty::getValue() doesn't accept non-strings anymore, breaking TestingAccessWrapper::__get():

TypeError: ReflectionProperty::getValue(): Argument #1 ($object) must be of type object, string given

Event Timeline

Change 584661 had a related patch set uploaded (by MaxSem; owner: MaxSem):
[testing-access-wrapper@master] PHP8 compatibility

https://gerrit.wikimedia.org/r/584661

Change 584661 merged by jenkins-bot:
[testing-access-wrapper@master] PHP8 compatibility

https://gerrit.wikimedia.org/r/584661

Reedy assigned this task to MaxSem.
Reedy added a subscriber: Reedy.

I guess this probably warrants a release at some point..