Page MenuHomePhabricator
Create Task
Maniphest T248887

Make testing-access-wrapper compatible with PHP8
Closed, ResolvedPublic
Actions

Description

ReflectionProperty::getValue() doesn't accept non-strings anymore, breaking TestingAccessWrapper::__get():

TypeError: ReflectionProperty::getValue(): Argument #1 ($object) must be of type object, string given

Details

SubjectRepoBranchLines +/-
PHP8 compatibilitytesting-access-wrappermaster+14 -0
Customize query in gerrit

Related Objects

Event Timeline

MaxSem created this task.Mar 30 2020, 5:35 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptMar 30 2020, 5:35 PM
gerritbot added a comment.Mar 30 2020, 5:46 PM

Change 584661 had a related patch set uploaded (by MaxSem; owner: MaxSem):
[testing-access-wrapper@master] PHP8 compatibility

https://gerrit.wikimedia.org/r/584661

gerritbot added a project: Patch-For-Review.Mar 30 2020, 5:46 PM
MaxSem updated the task description. (Show Details)Mar 30 2020, 5:46 PM
gerritbot added a comment.Apr 30 2020, 5:15 PM

Change 584661 merged by jenkins-bot:
[testing-access-wrapper@master] PHP8 compatibility

https://gerrit.wikimedia.org/r/584661

Reedy mentioned this in rTAWR553bfb7189d3: PHP8 compatibility.Apr 30 2020, 5:18 PM
Maintenance_bot removed a project: Patch-For-Review.Apr 30 2020, 6:11 PM
Reedy moved this task from Backlog to Wikimedia production on the PHP 8.0 support board.Oct 6 2020, 2:24 PM
Reedy closed this task as Resolved.Oct 28 2020, 12:34 AM
Reedy assigned this task to MaxSem.
Reedy subscribed.

I guess this probably warrants a release at some point..

TK-999 mentioned this in T268846: Update MediaWiki to a new wikimedia/testing-access-wrapper release.Nov 26 2020, 6:09 PM
Reedy mentioned this in T270228: "Error: Unsupported operand types" from ParserOptionsTest::testMatches on php74.Dec 16 2020, 4:21 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits