Parser.php has far too many public fields. Most of these already have accessor methods. We should deprecate the public fields, make them private, and ask users to use the accessor methods instead.
Description
Description
Details
Details
Customize query in gerrit
| Status | Subtype | Assigned | Task | ||
|---|---|---|---|---|---|
| Open | None | T261329 Prepare Parsoid for MW | |||
| Open | None | T236809 Refactor Parser.php to allow alternate parser (Parsoid) | |||
| Open | None | T248889 Make public fields of Parser.php private and use accessors |
Event Timeline
Comment Actions
Change 584662 had a related patch set uploaded (by C. Scott Ananian; owner: C. Scott Ananian):
[mediawiki/core@master] Remove Parser::$mDefaultStripList
Comment Actions
Change 584663 had a related patch set uploaded (by C. Scott Ananian; owner: C. Scott Ananian):
[mediawiki/core@master] WIP: Deprecate most public fields of Parser
Comment Actions
Change 584683 had a related patch set uploaded (by C. Scott Ananian; owner: C. Scott Ananian):
[mediawiki/core@master] Remove Parser::$mIncludeCount
Comment Actions
Change 584692 had a related patch set uploaded (by C. Scott Ananian; owner: C. Scott Ananian):
[mediawiki/core@master] Remove Parser::$mRevIdForTs
Comment Actions
Change 584706 had a related patch set uploaded (by C. Scott Ananian; owner: C. Scott Ananian):
[mediawiki/core@master] Make private some Parser constants
Comment Actions
Change 584662 merged by jenkins-bot:
[mediawiki/core@master] Remove Parser::$mDefaultStripList
Comment Actions
Change 584683 merged by jenkins-bot:
[mediawiki/core@master] Remove Parser::$mIncludeCount
Comment Actions
Change 584692 merged by jenkins-bot:
[mediawiki/core@master] Remove Parser::$mRevIdForTs
Comment Actions
Change 584961 had a related patch set uploaded (by C. Scott Ananian; owner: C. Scott Ananian):
[mediawiki/core@master] Prepare to deprecate public fields of Parser
Comment Actions
Change 584706 merged by jenkins-bot:
[mediawiki/core@master] Make private some Parser constants
Comment Actions
Change 584961 merged by jenkins-bot:
[mediawiki/core@master] Prepare to deprecate public fields of Parser
Comment Actions
Change 584663 merged by jenkins-bot:
[mediawiki/core@master] Deprecate most public fields of Parser; make private those unused outside core
Comment Actions
Removing task assignee due to inactivity as this open task has been assigned for more than two years. See the email sent to the task assignee on August 22nd, 2022.
Please assign this task to yourself again if you still realistically [plan to] work on this task - it would be welcome!
If this task has been resolved in the meantime, or should not be worked on ("declined"), please update its task status via "Add Action… 🡒 Change Status".
Also see https://www.mediawiki.org/wiki/Bug_management/Assignee_cleanup for tips how to best manage your individual work in Phabricator. Thanks!