Page MenuHomePhabricator

Make public fields of Parser.php private and use accessors
Open, MediumPublic

Description

Parser.php has far too many public fields. Most of these already have accessor methods. We should deprecate the public fields, make them private, and ask users to use the accessor methods instead.

Event Timeline

ssastry triaged this task as Medium priority.
ssastry added a project: Parsing-Active-Work.

Change 584662 had a related patch set uploaded (by C. Scott Ananian; owner: C. Scott Ananian):
[mediawiki/core@master] Remove Parser::$mDefaultStripList

https://gerrit.wikimedia.org/r/584662

Change 584663 had a related patch set uploaded (by C. Scott Ananian; owner: C. Scott Ananian):
[mediawiki/core@master] WIP: Deprecate most public fields of Parser

https://gerrit.wikimedia.org/r/584663

Change 584683 had a related patch set uploaded (by C. Scott Ananian; owner: C. Scott Ananian):
[mediawiki/core@master] Remove Parser::$mIncludeCount

https://gerrit.wikimedia.org/r/584683

Change 584692 had a related patch set uploaded (by C. Scott Ananian; owner: C. Scott Ananian):
[mediawiki/core@master] Remove Parser::$mRevIdForTs

https://gerrit.wikimedia.org/r/584692

Change 584706 had a related patch set uploaded (by C. Scott Ananian; owner: C. Scott Ananian):
[mediawiki/core@master] Make private some Parser constants

https://gerrit.wikimedia.org/r/584706

Change 584662 merged by jenkins-bot:
[mediawiki/core@master] Remove Parser::$mDefaultStripList

https://gerrit.wikimedia.org/r/584662

Change 584683 merged by jenkins-bot:
[mediawiki/core@master] Remove Parser::$mIncludeCount

https://gerrit.wikimedia.org/r/584683

Change 584692 merged by jenkins-bot:
[mediawiki/core@master] Remove Parser::$mRevIdForTs

https://gerrit.wikimedia.org/r/584692

Change 584961 had a related patch set uploaded (by C. Scott Ananian; owner: C. Scott Ananian):
[mediawiki/core@master] Prepare to deprecate public fields of Parser

https://gerrit.wikimedia.org/r/584961

Change 584706 merged by jenkins-bot:
[mediawiki/core@master] Make private some Parser constants

https://gerrit.wikimedia.org/r/584706

Change 584961 merged by jenkins-bot:
[mediawiki/core@master] Prepare to deprecate public fields of Parser

https://gerrit.wikimedia.org/r/584961

Change 584663 merged by jenkins-bot:
[mediawiki/core@master] Deprecate most public fields of Parser; make private those unused outside core

https://gerrit.wikimedia.org/r/584663