ParserIntegrationTest doesn't reload ParserFactory and always test parser with default options
Closed, ResolvedPublic
Actions

Assigned To

Authored By

	Peter.ovchyn
	Mar 31 2020, 1:16 PM

Description

Motivation

There're many places in the code (particularly) in extensions/intersection where the parser is created via direct access to MediaWikiServices:

MediaWikiServices::instance()->getParserFactory()->create();

As far as parserFactory is a singleton it always creates the Parser with the options were actual when ParserFactory initialized.

So the tests, particularly ParserIntegrationTest run with settings provided from LocalSetting, not test settings,

Expected result:

ParserIntegrationTest should reset ParserFactory service on setUp so that it's created with the settings provided by the test.

Additional info:

This issue blocks the paths: https://gerrit.wikimedia.org/r/c/mediawiki/extensions/intersection/+/572720
and T244055

Details

	Subject	Repo	Branch	Lines +/-
	Deprecate $wgParserConf	mediawiki/core	master	+19 -9
	parser: Reset ParserFactory service in ParserIntergrationTests	mediawiki/core	master	+5 -0

Customize query in gerrit

Related Objects

Mentioned Here: T244055: Replace Parser's creation from "Parser::__constructor" to "ParserFactory::create" across all the code

Event Timeline

Peter.ovchyn created this task.Mar 31 2020, 1:16 PM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptMar 31 2020, 1:16 PM

Peter.ovchyn claimed this task.Mar 31 2020, 1:19 PM

Peter.ovchyn triaged this task as Medium priority.

Peter.ovchyn added a project: Platform Team Workboards (S&F Workboard).

Change 584924 had a related patch set uploaded (by Peter.ovchyn; owner: Peter.ovchyn):
[mediawiki/core@master] parser: Reset ParserFactory service in ParserIntergrationTests

https://gerrit.wikimedia.org/r/584924

gerritbot added a project: Patch-For-Review.Mar 31 2020, 1:28 PM

Peter.ovchyn moved this task from Backlog to In Progress/In Review on the Platform Team Workboards (S&F Workboard) board.Mar 31 2020, 1:35 PM

Peter.ovchyn added a project: MediaWiki-Parser.

Peter.ovchyn renamed this task from ParserIntegrationTest doesn't reload ParserFactory what leads to side effects between to ParserIntegrationTest doesn't reload ParserFactory and always test parser with default parameters.Mar 31 2020, 6:05 PM

Peter.ovchyn updated the task description. (Show Details)

Peter.ovchyn renamed this task from ParserIntegrationTest doesn't reload ParserFactory and always test parser with default parameters to ParserIntegrationTest doesn't reload ParserFactory and always test parser with default options.Mar 31 2020, 6:07 PM

Peter.ovchyn updated the task description. (Show Details)

Peter.ovchyn moved this task from In Progress/In Review to Backlog on the Platform Team Workboards (S&F Workboard) board.Apr 1 2020, 2:47 PM

Peter.ovchyn moved this task from Backlog to In Progress/In Review on the Platform Team Workboards (S&F Workboard) board.

I don't necessarily agree that extensions should be calling MediaWikiServices::instance()->getParserFactory()->create(); All extensions should be given a $parser object in their hooks, they should be using that.

Change 589397 had a related patch set uploaded (by C. Scott Ananian; owner: C. Scott Ananian):
[mediawiki/core@master] Deprecate $wgParserConf

https://gerrit.wikimedia.org/r/589397

Change 584924 abandoned by C. Scott Ananian:
parser: Reset ParserFactory service in ParserIntergrationTests

Reason:
Done as part of I787f22ea9bf59a049b13631ba6974866a1300988 -- thanks for the pointer to this issue!

https://gerrit.wikimedia.org/r/584924

Change 589397 merged by jenkins-bot:
[mediawiki/core@master] Deprecate $wgParserConf

https://gerrit.wikimedia.org/r/589397

Maintenance_bot removed a project: Patch-For-Review.Apr 16 2020, 9:11 PM

Peter.ovchyn moved this task from In Progress/In Review to Done on the Platform Team Workboards (S&F Workboard) board.May 3 2020, 7:42 PM

Peter.ovchyn closed this task as Resolved.May 7 2020, 3:42 PM

ParserIntegrationTest doesn't reload ParserFactory and always test parser with default optionsClosed, ResolvedPublicActions