Page MenuHomePhabricator
Create Task
Maniphest T244055

Replace Parser's creation from "Parser::__constructor" to "ParserFactory::create" across all the code
Closed, ResolvedPublic
Actions

Description

Motivation

Migration to context-based DI aims to separate creation from logic. Using Parser::__constructor (new Parser) demands to support backward compatibility.
At the moment Parser already uses DI, but a lot of legacy code in extension creates it directly via constructor.
https://codesearch.wmflabs.org/search/?q=new%20%5C%5C%3FParser%5C(&i=nope&files=&repos=

Expected Result:

All occurrences of new Parser() should be replaced in favor of creating it via factory (both core and extensions):
MediaWikiServices::getInstance()->getParserFactory()->create();

Details

SubjectRepoBranchLines +/-
parser: Replace 'new Parser' in favour of using Parser::getFreshParsermediawiki/extensions/intersectionmaster+1 -1
parser: Replace 'new Parser' in favour of using ParserFactory/MediaWikiServicesmediawiki/extensions/Lingomaster+32 -30
parser: Replace 'new Parser' in favour of using ParserFactory/MediaWikiServicesmediawiki/extensions/BiblioPlusmaster+6 -3
parser: Replace 'new Parser' in favour of using Parser::getFreshParsermediawiki/extensions/RSSmaster+1 -1
parser: Replace 'new Parser' in favour of using ParserFactory/MediaWikiServicesmediawiki/extensions/MediaWikiChatmaster+1 -1
parser: Replace 'new Parser' in favour of using ParserFactory/MediaWikiServicesmediawiki/extensions/Videomaster+1 -7
parser: Replace 'new Parser' in favour of using ParserFactory/MediaWikiServicesmediawiki/extensions/BlogPagemaster+4 -1
parser: Replace 'new Parser' in favour of using ParserFactory/MediaWikiServicesmediawiki/extensions/FanBoxesmaster+4 -4
Remove not needed `new Parser()`, fix broken test setupmediawiki/extensions/NumerAlphamaster+11 -5
parser: Replace 'new Parser' in favour of using ParserFactory/MediaWikiServicesmediawiki/extensions/DynamicPageListmaster+1 -3
parser: Replace 'new Parser' in favour of using ParserFactory/MediaWikiServicesmediawiki/extensions/SocialProfilemaster+8 -3
parser: Replace 'new Parser' in favour of using ParserFactory/MediaWikiServicesmediawiki/extensions/Translatemaster+6 -2
parser: Replace 'new Parser' in favour of using ParserFactory/MediaWikiServicesmediawiki/extensions/CommentStreamsmaster+9 -1
Remove onParserAfterTidy hood as tidy is deadmediawiki/extensions/TemplateStylesmaster+0 -57
parser: Replace 'new Parser' in favour of using ParserFactory/MediaWikiServicesmediawiki/extensions/DataTable2master+4 -2
parser: Replace 'new Parser' in favour of using ParserFactory/MediaWikiServicesmediawiki/extensions/MassMessageEmailmaster+6 -1
parser: Replace 'new Parser' in favour of using ParserFactory/MediaWikiServicesmediawiki/extensions/Kartographermaster+6 -4
parser: Replace 'new Parser' in favour of using ParserFactory/MediaWikiServicesmediawiki/extensions/Flowmaster+2 -3
parser: Replace 'new Parser' in favour of using ParserFactory/MediaWikiServicesmediawiki/extensions/FileAnnotationsmaster+1 -1
parser: Replace 'new Parser' in favour of using ParserFactory/MediaWikiServicesmediawiki/extensions/FeaturedFeedsmaster+2 -2
parser: Replace 'new Parser' in favour of using ParserFactory/MediaWikiServicesmediawiki/extensions/Wikibasemaster+35 -25
parser: Replace 'new Parser' in favour of using ParserFactory/MediaWikiServicesmediawiki/extensions/NewsTickermaster+1 -1
parser: Replace 'new Parser' in favour of using ParserFactory/MediaWikiServicesmediawiki/extensions/ProofreadPagemaster+4 -2
Use MediaWikiServices::getParserFactory() for MW 1.32+mediawiki/extensions/ApprovedRevsmaster+14 -2
parser: Replace 'new Parser' in favour of using ParserFactory/MediaWikiServicesmediawiki/extensions/MassMessagemaster+2 -2
parser: Replace 'new Parser' in favour of using ParserFactory/MediaWikiServicesmediawiki/extensions/Mathmaster+7 -3
Add missing `use` statementmediawiki/extensions/BlueSpiceFoundationmaster+2 -0
parser: Replace 'new Parser' in favour of using ParserFactory/MediaWikiServicesmediawiki/extensions/BlueSpiceFoundationmaster+3 -3
Show related patches Customize query in gerrit

Related Objects

Event Timeline

Peter.ovchyn created this task.Feb 1 2020, 12:11 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptFeb 1 2020, 12:11 PM
Peter.ovchyn updated the task description. (Show Details)Feb 11 2020, 9:40 AM
Peter.ovchyn moved this task from Backlog to In Progress/Doing on the Platform Team Workboards (S&F Workboard) board.Feb 11 2020, 10:22 AM
gerritbot added a comment.Feb 17 2020, 11:24 AM

Change 572646 had a related patch set uploaded (by Peter.ovchyn; owner: Peter.ovchyn):
[mediawiki/extensions/Wikibase@master] parser: Replace 'new Parser' in favour of using ParserFactory/MediaWikiServices

https://gerrit.wikimedia.org/r/572646

gerritbot added a project: Patch-For-Review.Feb 17 2020, 11:24 AM
gerritbot added a comment.Feb 17 2020, 2:54 PM

Change 572683 had a related patch set uploaded (by Peter.ovchyn; owner: Peter.ovchyn):
[mediawiki/extensions/BiblioPlus@master] parser: Replace 'new Parser' in favour of using ParserFactory/MediaWikiServices

https://gerrit.wikimedia.org/r/572683

gerritbot added a comment.Feb 17 2020, 3:27 PM

Change 572687 had a related patch set uploaded (by Peter.ovchyn; owner: Peter.ovchyn):
[mediawiki/extensions/Video@master] parser: Replace 'new Parser' in favour of using ParserFactory/MediaWikiServices

https://gerrit.wikimedia.org/r/572687

gerritbot added a comment.Feb 17 2020, 3:29 PM

Change 572689 had a related patch set uploaded (by Peter.ovchyn; owner: Peter.ovchyn):
[mediawiki/extensions/Math@master] parser: Replace 'new Parser' in favour of using ParserFactory/MediaWikiServices

https://gerrit.wikimedia.org/r/572689

gerritbot added a comment.Feb 17 2020, 3:37 PM

Change 572694 had a related patch set uploaded (by Peter.ovchyn; owner: Peter.ovchyn):
[mediawiki/extensions/Lingo@master] parser: Replace 'new Parser' in favour of using ParserFactory/MediaWikiServices

https://gerrit.wikimedia.org/r/572694

gerritbot added a comment.Feb 17 2020, 3:48 PM

Change 572699 had a related patch set uploaded (by Peter.ovchyn; owner: Peter.ovchyn):
[mediawiki/extensions/DataTable2@master] parser: Replace 'new Parser' in favour of using ParserFactory/MediaWikiServices

https://gerrit.wikimedia.org/r/572699

gerritbot added a comment.Feb 17 2020, 3:57 PM

Change 572700 had a related patch set uploaded (by Peter.ovchyn; owner: Peter.ovchyn):
[mediawiki/extensions/FeaturedFeeds@master] parser: Replace 'new Parser' in favour of using ParserFactory/MediaWikiServices

https://gerrit.wikimedia.org/r/572700

gerritbot added a comment.Feb 17 2020, 4:14 PM

Change 572703 had a related patch set uploaded (by Peter.ovchyn; owner: Peter.ovchyn):
[mediawiki/extensions/CommentStreams@master] parser: Replace 'new Parser' in favour of using ParserFactory/MediaWikiServices

https://gerrit.wikimedia.org/r/572703

gerritbot added a comment.Feb 17 2020, 4:15 PM

Change 572704 had a related patch set uploaded (by Peter.ovchyn; owner: Peter.ovchyn):
[mediawiki/extensions/MassMessage@master] parser: Replace 'new Parser' in favour of using ParserFactory/MediaWikiServices

https://gerrit.wikimedia.org/r/572704

gerritbot added a comment.Feb 17 2020, 4:23 PM

Change 572706 had a related patch set uploaded (by Peter.ovchyn; owner: Peter.ovchyn):
[mediawiki/extensions/FanBoxes@master] parser: Replace 'new Parser' in favour of using ParserFactory/MediaWikiServices

https://gerrit.wikimedia.org/r/572706

gerritbot added a comment.Feb 17 2020, 4:46 PM

Change 572709 had a related patch set uploaded (by Peter.ovchyn; owner: Peter.ovchyn):
[mediawiki/extensions/BlueSpiceFoundation@master] parser: Replace 'new Parser' in favour of using ParserFactory/MediaWikiServices

https://gerrit.wikimedia.org/r/572709

gerritbot added a comment.Feb 17 2020, 4:52 PM

Change 572710 had a related patch set uploaded (by Peter.ovchyn; owner: Peter.ovchyn):
[mediawiki/extensions/ApprovedRevs@master] parser: Replace 'new Parser' in favour of using ParserFactory/MediaWikiServices

https://gerrit.wikimedia.org/r/572710

gerritbot added a comment.Feb 17 2020, 5:13 PM

Change 572720 had a related patch set uploaded (by Peter.ovchyn; owner: Peter.ovchyn):
[mediawiki/extensions/intersection@master] parser: Replace 'new Parser' in favour of using ParserFactory/MediaWikiServices

https://gerrit.wikimedia.org/r/572720

gerritbot added a comment.Feb 17 2020, 5:14 PM

Change 572721 had a related patch set uploaded (by Peter.ovchyn; owner: Peter.ovchyn):
[mediawiki/extensions/RSS@master] parser: Replace 'new Parser' in favour of using ParserFactory/MediaWikiServices

https://gerrit.wikimedia.org/r/572721

Physikerwelt subscribed.Feb 17 2020, 6:56 PM

Is there a follow up change to the coding convention check. Otherwise people like me might reintroduce the shorter alternative in the future without being aware of the longer form.

Peter.ovchyn added a comment.Feb 17 2020, 7:45 PM
In T244055#5890939, @Physikerwelt wrote:

Is there a follow up change to the coding convention check. Otherwise people like me might reintroduce the shorter alternative in the future without being aware of the longer form.

Didn’t get you. What do you mean by shorter/longer form?

gerritbot added a comment.Feb 17 2020, 9:11 PM

Change 572744 had a related patch set uploaded (by Peter.ovchyn; owner: Peter.ovchyn):
[mediawiki/extensions/NumerAlpha@master] parser: Replace 'new Parser' in favour of using ParserFactory/MediaWikiServices

https://gerrit.wikimedia.org/r/572744

Physikerwelt added a comment.Feb 18 2020, 5:07 AM
In T244055#5891021, @Peter.ovchyn wrote:

Didn’t get you. What do you mean by shorter/longer form?

short = new Parser()

long = MediaWikiServices::getInstance()->getParserFactory()->create()

gerritbot added a comment.Feb 18 2020, 7:27 AM

Change 572709 merged by jenkins-bot:
[mediawiki/extensions/BlueSpiceFoundation@master] parser: Replace 'new Parser' in favour of using ParserFactory/MediaWikiServices

https://gerrit.wikimedia.org/r/572709

gerritbot added a comment.Feb 18 2020, 8:28 AM

Change 572816 had a related patch set uploaded (by Robert Vogel; owner: Robert Vogel):
[mediawiki/extensions/BlueSpiceFoundation@master] Add missing use statement

https://gerrit.wikimedia.org/r/572816

gerritbot added a comment.Feb 18 2020, 9:06 AM

Change 572816 merged by jenkins-bot:
[mediawiki/extensions/BlueSpiceFoundation@master] Add missing use statement

https://gerrit.wikimedia.org/r/572816

Peter.ovchyn claimed this task.Feb 18 2020, 11:48 AM
Peter.ovchyn added a comment.Feb 18 2020, 11:56 AM
In T244055#5891821, @Physikerwelt wrote:
In T244055#5891021, @Peter.ovchyn wrote:

Didn’t get you. What do you mean by shorter/longer form?

short = new Parser()

long = MediaWikiServices::getInstance()->getParserFactory()->create()

I don't know how to implement this rule yet but you're 100% right, it would be really great to have it working across all the code. However, a few difficulties: not all new Parser statements refer to MediaWiki\Parser. PhpParser, Lua parser, and a few other 3d-party libs also have class Parser. Also, the follow up it to make new Parser() hard deprecated, and make it only possible to use providing all arguments.

I hope it'll sort your question out.
Anyway, having code style rules is a brilliant idea here.

Physikerwelt added a comment.Feb 18 2020, 1:01 PM

While reading this, I was thinking about a private constructor. Not sure if that makes sense, but it would be an alternative to a code style rule.

gerritbot added a comment.Feb 18 2020, 1:37 PM

Change 572689 merged by jenkins-bot:
[mediawiki/extensions/Math@master] parser: Replace 'new Parser' in favour of using ParserFactory/MediaWikiServices

https://gerrit.wikimedia.org/r/572689

ReleaseTaggerBot added a project: MW-1.35-notes (1.35.0-wmf.20; 2020-02-18).Feb 18 2020, 2:01 PM
Aklapper added a project: MediaWiki-extensions-General.Feb 18 2020, 2:02 PM
Peter.ovchyn added a comment.Feb 18 2020, 2:12 PM
In T244055#5892649, @Physikerwelt wrote:

While reading this, I was thinking about a private constructor. Not sure if that makes sense, but it would be an alternative to a code style rule.

Other languages have "internal" or "module" visibility modifications. It's exactly what you're talking about. Making constructor "private" automatically makes factory (ParserFactory) senseless, since it can't call it as well.

xSavitar awarded a token.Feb 18 2020, 6:51 PM
gerritbot added a comment.Feb 18 2020, 6:58 PM

Change 572704 merged by jenkins-bot:
[mediawiki/extensions/MassMessage@master] parser: Replace 'new Parser' in favour of using ParserFactory/MediaWikiServices

https://gerrit.wikimedia.org/r/572704

ReleaseTaggerBot edited projects, added MW-1.35-notes (1.35.0-wmf.21; 2020-02-25); removed MW-1.35-notes (1.35.0-wmf.20; 2020-02-18).Feb 18 2020, 7:00 PM
gerritbot added a comment.Feb 18 2020, 7:39 PM

Change 572951 had a related patch set uploaded (by Peter.ovchyn; owner: Peter.ovchyn):
[mediawiki/extensions/ProofreadPage@master] parser: Replace 'new Parser' in favour of using ParserFactory/MediaWikiServices

https://gerrit.wikimedia.org/r/572951

gerritbot added a comment.Feb 18 2020, 8:16 PM

Change 572961 had a related patch set uploaded (by Peter.ovchyn; owner: Peter.ovchyn):
[mediawiki/extensions/SocialProfile@master] parser: Replace 'new Parser' in favour of using ParserFactory/MediaWikiServices

https://gerrit.wikimedia.org/r/572961

gerritbot added a comment.Feb 18 2020, 8:21 PM

Change 572962 had a related patch set uploaded (by Peter.ovchyn; owner: Peter.ovchyn):
[mediawiki/extensions/DynamicPageList@master] parser: Replace 'new Parser' in favour of using ParserFactory/MediaWikiServices

https://gerrit.wikimedia.org/r/572962

gerritbot added a comment.Feb 18 2020, 8:23 PM

Change 572963 had a related patch set uploaded (by Peter.ovchyn; owner: Peter.ovchyn):
[mediawiki/extensions/BlogPage@master] parser: Replace 'new Parser' in favour of using ParserFactory/MediaWikiServices

https://gerrit.wikimedia.org/r/572963

gerritbot added a comment.Feb 18 2020, 8:39 PM

Change 572964 had a related patch set uploaded (by Peter.ovchyn; owner: Peter.ovchyn):
[mediawiki/extensions/NewsTicker@master] parser: Replace 'new Parser' in favour of using ParserFactory/MediaWikiServices

https://gerrit.wikimedia.org/r/572964

gerritbot added a comment.Feb 18 2020, 8:40 PM

Change 572965 had a related patch set uploaded (by Peter.ovchyn; owner: Peter.ovchyn):
[mediawiki/extensions/FileAnnotations@master] parser: Replace 'new Parser' in favour of using ParserFactory/MediaWikiServices

https://gerrit.wikimedia.org/r/572965

gerritbot added a comment.Feb 18 2020, 8:49 PM

Change 572968 had a related patch set uploaded (by Peter.ovchyn; owner: Peter.ovchyn):
[mediawiki/extensions/MassMessageEmail@master] parser: Replace 'new Parser' in favour of using ParserFactory/MediaWikiServices

https://gerrit.wikimedia.org/r/572968

gerritbot added a comment.Feb 18 2020, 8:51 PM

Change 572969 had a related patch set uploaded (by Peter.ovchyn; owner: Peter.ovchyn):
[mediawiki/extensions/Translate@master] parser: Replace 'new Parser' in favour of using ParserFactory/MediaWikiServices

https://gerrit.wikimedia.org/r/572969

gerritbot added a comment.Feb 18 2020, 8:54 PM

Change 572971 had a related patch set uploaded (by Peter.ovchyn; owner: Peter.ovchyn):
[mediawiki/extensions/Flow@master] parser: Replace 'new Parser' in favour of using ParserFactory/MediaWikiServices

https://gerrit.wikimedia.org/r/572971

gerritbot added a comment.Feb 18 2020, 8:57 PM

Change 572972 had a related patch set uploaded (by Peter.ovchyn; owner: Peter.ovchyn):
[mediawiki/extensions/TemplateStyles@master] parser: Replace 'new Parser' in favour of using ParserFactory/MediaWikiServices

https://gerrit.wikimedia.org/r/572972

gerritbot added a comment.Feb 18 2020, 8:58 PM

Change 572973 had a related patch set uploaded (by Peter.ovchyn; owner: Peter.ovchyn):
[mediawiki/extensions/MediaWikiChat@master] parser: Replace 'new Parser' in favour of using ParserFactory/MediaWikiServices

https://gerrit.wikimedia.org/r/572973

gerritbot added a comment.Feb 18 2020, 8:59 PM

Change 572974 had a related patch set uploaded (by Peter.ovchyn; owner: Peter.ovchyn):
[mediawiki/extensions/Kartographer@master] parser: Replace 'new Parser' in favour of using ParserFactory/MediaWikiServices

https://gerrit.wikimedia.org/r/572974

gerritbot added a comment.Feb 19 2020, 1:02 AM

Change 572710 merged by jenkins-bot:
[mediawiki/extensions/ApprovedRevs@master] Use MediaWikiServices::getParserFactory() for MW 1.32+

https://gerrit.wikimedia.org/r/572710

gerritbot added a comment.Feb 19 2020, 5:13 AM

Change 572951 merged by jenkins-bot:
[mediawiki/extensions/ProofreadPage@master] parser: Replace 'new Parser' in favour of using ParserFactory/MediaWikiServices

https://gerrit.wikimedia.org/r/572951

gerritbot added a comment.Feb 20 2020, 9:13 AM

Change 572964 merged by jenkins-bot:
[mediawiki/extensions/NewsTicker@master] parser: Replace 'new Parser' in favour of using ParserFactory/MediaWikiServices

https://gerrit.wikimedia.org/r/572964

Peter.ovchyn mentioned this in rENWT98eb11203100: parser: Replace 'new Parser' in favour of using ParserFactory/MediaWikiServices.Feb 20 2020, 9:26 AM
gerritbot added a comment.Feb 21 2020, 10:15 AM

Change 572646 merged by jenkins-bot:
[mediawiki/extensions/Wikibase@master] parser: Replace 'new Parser' in favour of using ParserFactory/MediaWikiServices

https://gerrit.wikimedia.org/r/572646

gerritbot added a comment.Feb 21 2020, 8:04 PM

Change 572972 merged by jenkins-bot:
[mediawiki/extensions/TemplateStyles@master] Remove onParserAfterTidy hood as tidy is dead

https://gerrit.wikimedia.org/r/572972

Daimona updated the task description. (Show Details)Feb 22 2020, 5:01 PM
gerritbot added a comment.Feb 23 2020, 9:45 AM

Change 572700 merged by jenkins-bot:
[mediawiki/extensions/FeaturedFeeds@master] parser: Replace 'new Parser' in favour of using ParserFactory/MediaWikiServices

https://gerrit.wikimedia.org/r/572700

gerritbot added a comment.Feb 23 2020, 9:45 AM

Change 572971 merged by jenkins-bot:
[mediawiki/extensions/Flow@master] parser: Replace 'new Parser' in favour of using ParserFactory/MediaWikiServices

https://gerrit.wikimedia.org/r/572971

gerritbot added a comment.Feb 23 2020, 9:45 AM

Change 572974 merged by jenkins-bot:
[mediawiki/extensions/Kartographer@master] parser: Replace 'new Parser' in favour of using ParserFactory/MediaWikiServices

https://gerrit.wikimedia.org/r/572974

gerritbot added a comment.Feb 23 2020, 9:45 AM

Change 572965 merged by jenkins-bot:
[mediawiki/extensions/FileAnnotations@master] parser: Replace 'new Parser' in favour of using ParserFactory/MediaWikiServices

https://gerrit.wikimedia.org/r/572965

Peter.ovchyn mentioned this in rEFFD5a9d3e340e24: parser: Replace 'new Parser' in favour of using ParserFactory/MediaWikiServices.Feb 23 2020, 9:53 AM
gerritbot added a comment.Feb 24 2020, 8:57 AM

Change 572968 merged by jenkins-bot:
[mediawiki/extensions/MassMessageEmail@master] parser: Replace 'new Parser' in favour of using ParserFactory/MediaWikiServices

https://gerrit.wikimedia.org/r/572968

gerritbot added a comment.Feb 24 2020, 8:57 AM

Change 572699 merged by jenkins-bot:
[mediawiki/extensions/DataTable2@master] parser: Replace 'new Parser' in favour of using ParserFactory/MediaWikiServices

https://gerrit.wikimedia.org/r/572699

Peter.ovchyn mentioned this in rEMME4b14ac109c9d: parser: Replace 'new Parser' in favour of using ParserFactory/MediaWikiServices.Feb 24 2020, 9:50 AM
gerritbot added a comment.Feb 25 2020, 2:12 AM

Change 572703 merged by jenkins-bot:
[mediawiki/extensions/CommentStreams@master] parser: Replace 'new Parser' in favour of using ParserFactory/MediaWikiServices

https://gerrit.wikimedia.org/r/572703

gerritbot added a comment.Feb 25 2020, 5:15 AM

Change 572969 merged by Abijeet Patro:
[mediawiki/extensions/Translate@master] parser: Replace 'new Parser' in favour of using ParserFactory/MediaWikiServices

https://gerrit.wikimedia.org/r/572969

gerritbot added a comment.Feb 25 2020, 10:56 PM

Change 572961 merged by jenkins-bot:
[mediawiki/extensions/SocialProfile@master] parser: Replace 'new Parser' in favour of using ParserFactory/MediaWikiServices

https://gerrit.wikimedia.org/r/572961

Jdforrester-WMF mentioned this in rESPR64fe0c5e8dff: parser: Replace 'new Parser' in favour of using ParserFactory/MediaWikiServices.Feb 25 2020, 10:58 PM
Peter.ovchyn moved this task from In Progress/Doing to In Progress/In Review on the Platform Team Workboards (S&F Workboard) board.Mar 2 2020, 8:52 AM
gerritbot added a comment.Mar 10 2020, 7:13 PM

Change 572962 merged by jenkins-bot:
[mediawiki/extensions/DynamicPageList@master] parser: Replace 'new Parser' in favour of using ParserFactory/MediaWikiServices

https://gerrit.wikimedia.org/r/572962

gerritbot added a comment.Mar 25 2020, 3:20 PM

Change 572744 merged by jenkins-bot:
[mediawiki/extensions/NumerAlpha@master] Remove not needed new Parser(), fix broken test setup

https://gerrit.wikimedia.org/r/572744

gerritbot added a comment.Mar 25 2020, 7:10 PM

Change 572706 merged by jenkins-bot:
[mediawiki/extensions/FanBoxes@master] parser: Replace 'new Parser' in favour of using ParserFactory/MediaWikiServices

https://gerrit.wikimedia.org/r/572706

gerritbot added a comment.Mar 25 2020, 7:10 PM

Change 572963 merged by jenkins-bot:
[mediawiki/extensions/BlogPage@master] parser: Replace 'new Parser' in favour of using ParserFactory/MediaWikiServices

https://gerrit.wikimedia.org/r/572963

Peter.ovchyn moved this task from In Progress/In Review to Current sprint Backlog on the Platform Team Workboards (S&F Workboard) board.Mar 26 2020, 5:10 PM
Peter.ovchyn moved this task from Current sprint Backlog to In Progress/Doing on the Platform Team Workboards (S&F Workboard) board.Mar 30 2020, 11:19 AM
Helga_sf moved this task from In Progress/Doing to Current sprint Backlog on the Platform Team Workboards (S&F Workboard) board.Mar 31 2020, 3:57 PM
Peter.ovchyn moved this task from Current sprint Backlog to In Progress/Doing on the Platform Team Workboards (S&F Workboard) board.Mar 31 2020, 4:06 PM
Peter.ovchyn mentioned this in T248977: ParserIntegrationTest doesn't reload ParserFactory and always test parser with default options.Mar 31 2020, 6:05 PM
gerritbot added a comment.Apr 1 2020, 5:28 AM

Change 572687 merged by jenkins-bot:
[mediawiki/extensions/Video@master] parser: Replace 'new Parser' in favour of using ParserFactory/MediaWikiServices

https://gerrit.wikimedia.org/r/572687

gerritbot added a comment.Apr 1 2020, 5:31 AM

Change 572973 merged by jenkins-bot:
[mediawiki/extensions/MediaWikiChat@master] parser: Replace 'new Parser' in favour of using ParserFactory/MediaWikiServices

https://gerrit.wikimedia.org/r/572973

Peter.ovchyn moved this task from In Progress/Doing to Blocked on the Platform Team Workboards (S&F Workboard) board.Apr 1 2020, 9:54 AM
gerritbot added a comment.Apr 1 2020, 2:54 PM

Change 572721 merged by jenkins-bot:
[mediawiki/extensions/RSS@master] parser: Replace 'new Parser' in favour of using Parser::getFreshParser

https://gerrit.wikimedia.org/r/572721

ReleaseTaggerBot edited projects, added MW-1.35-notes (1.35.0-wmf.27; 2020-04-07); removed MW-1.35-notes (1.35.0-wmf.21; 2020-02-25).Apr 1 2020, 3:00 PM
gerritbot added a comment.Apr 1 2020, 7:01 PM

Change 572683 merged by jenkins-bot:
[mediawiki/extensions/BiblioPlus@master] parser: Replace 'new Parser' in favour of using ParserFactory/MediaWikiServices

https://gerrit.wikimedia.org/r/572683

gerritbot added a comment.Apr 20 2020, 8:47 PM

Change 572694 merged by jenkins-bot:
[mediawiki/extensions/Lingo@master] parser: Replace 'new Parser' in favour of using ParserFactory/MediaWikiServices

https://gerrit.wikimedia.org/r/572694

gerritbot added a comment.Apr 20 2020, 9:00 PM

Change 572720 abandoned by C. Scott Ananian:
parser: Replace 'new Parser' in favour of using Parser::getFreshParser

Reason:
I777475d0ab0144e53240173f501d6c8da35d33fb did this already.

https://gerrit.wikimedia.org/r/572720

Maintenance_bot removed a project: Patch-For-Review.Apr 20 2020, 9:10 PM
Peter.ovchyn moved this task from Blocked to Done on the Platform Team Workboards (S&F Workboard) board.Apr 21 2020, 6:31 PM
Peter.ovchyn closed this task as Resolved.May 7 2020, 3:43 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits