I just added a trival no-op patch to tox.ini, and jenkins marked it -1: https://gerrit.wikimedia.org/r/#/c/operations/puppet/+/585058/ This is cramping my style as I have a different patch on progress that requires a tox change.
19:55:33 ________________________ VarnishRlsTest.testIfNoneMatch ________________________
19:55:33
19:55:33 self = <varnish_test.VarnishRlsTest testMethod=testIfNoneMatch>
19:55:33
19:55:33 def testIfNoneMatch(self):
19:55:33 s = self.store.get_samples('varnish_resourceloader_inm')
19:55:33 > self.assertIn(('', 1), s)
19:55:33 E AssertionError: ('', 1) not found in [('', 0)]
19:55:33
19:55:33 modules/mtail/files/test/varnish_test.py:28: AssertionError
19:55:33 ___________________________ VarnishRlsTest.testResp ____________________________
19:55:33
19:55:33 self = <varnish_test.VarnishRlsTest testMethod=testResp>
19:55:33
19:55:33 def testResp(self):
19:55:33 > s = self.store.get_samples('varnish_resourceloader_resp')
19:55:33
19:55:33 modules/mtail/files/test/varnish_test.py:31:
19:55:33 _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _
19:55:33
19:55:33 self = <mtail_store.MtailMetricStore object at 0x7f1d8834bd90>
19:55:33 name = 'varnish_resourceloader_resp'
19:55:33
19:55:33 def get_samples(self, name):
19:55:33 """Return all samples for metric name as a list of samples.
19:55:33 Each sample is in this form: ("k1=v1,k2=v2", value)"""
19:55:33 samples = []
19:55:33 if name not in self._store:
19:55:33 raise ValueError('metric %s not found in store' % name)
19:55:33 > for metric in self._store[name][0]['LabelValues']:
19:55:33 E KeyError: 'LabelValues'
19:55:33
19:55:33 modules/mtail/files/test/mtail_store.py:47: KeyError
19:55:33 ===================== 2 failed, 28 passed in 3.00 seconds ======================
19:55:33 ERROR: InvocationError for command '/srv/workspace/puppet/.tox/mtail/bin/pytest modules/mtail/files' (exited with code 1)