Page MenuHomePhabricator

RevisionSlider diff navigation displays "hidden" change tags
Closed, ResolvedPublic

Description

RevisionSlider diff navigation displays "hidden" change tags. I noticed this with the hidden tag we apply to all edits done with DiscussionTools, but any tags can be hidden by editing the related localisation message to be empty.

Example diff:
https://fr.wikipedia.org/w/index.php?diff=169058185&oldid=169043395&title=Discussion_utilisateur:FR

Event Timeline

matmarex created this task.Apr 2 2020, 8:01 PM
Restricted Application added a project: archived--TCB-Team. · View Herald TranscriptApr 2 2020, 8:01 PM
Restricted Application added a subscriber: Aklapper. · View Herald Transcript

Additionally, the tag "display names" are not used for revisions loaded using the arrow buttons on either end of the navigation:

Change 585603 had a related patch set uploaded (by Bartosz Dziewoński; owner: Bartosz Dziewoński):
[mediawiki/extensions/RevisionSlider@master] Use tag displaynames when fetching additional revisions

https://gerrit.wikimedia.org/r/585603

Change 585604 had a related patch set uploaded (by Bartosz Dziewoński; owner: Bartosz Dziewoński):
[mediawiki/extensions/RevisionSlider@master] Do not show entries for hidden tags

https://gerrit.wikimedia.org/r/585604

Change 585603 merged by jenkins-bot:
[mediawiki/extensions/RevisionSlider@master] Use tag displaynames when fetching additional revisions

https://gerrit.wikimedia.org/r/585603

Change 585604 merged by jenkins-bot:
[mediawiki/extensions/RevisionSlider@master] Do not show entries for hidden tags

https://gerrit.wikimedia.org/r/585604

ppelberg closed this task as Resolved.Fri, Jun 5, 1:22 AM