Page MenuHomePhabricator
Create Task
Maniphest T249266

RevisionSlider diff navigation displays "hidden" change tags
Closed, ResolvedPublic
Actions

Description

RevisionSlider diff navigation displays "hidden" change tags. I noticed this with the hidden tag we apply to all edits done with DiscussionTools, but any tags can be hidden by editing the related localisation message to be empty.

Example diff:
https://fr.wikipedia.org/w/index.php?diff=169058185&oldid=169043395&title=Discussion_utilisateur:FR

image.png (2×3 px, 703 KB)

Details

SubjectRepoBranchLines +/-
Do not show entries for hidden tagsmediawiki/extensions/RevisionSlidermaster+4 -1
Use tag displaynames when fetching additional revisionsmediawiki/extensions/RevisionSlidermaster+19 -5
Customize query in gerrit

Event Timeline

matmarex created this task.Apr 2 2020, 8:01 PM
Restricted Application added a project: TCB-Team (now WMDE-TechWish). · View Herald TranscriptApr 2 2020, 8:01 PM
Restricted Application added a subscriber: Aklapper. · View Herald Transcript
matmarex added a comment.Apr 2 2020, 8:41 PM

Additionally, the tag "display names" are not used for revisions loaded using the arrow buttons on either end of the navigation:

image.png (2×3 px, 710 KB)

matmarex claimed this task.Apr 2 2020, 8:42 PM
matmarex added a project: Editing-team (Q3 2019-2020 Kanban Board).
gerritbot added a comment.Apr 2 2020, 8:42 PM

Change 585603 had a related patch set uploaded (by Bartosz Dziewoński; owner: Bartosz Dziewoński):
[mediawiki/extensions/RevisionSlider@master] Use tag displaynames when fetching additional revisions

https://gerrit.wikimedia.org/r/585603

gerritbot added a project: Patch-For-Review.Apr 2 2020, 8:42 PM

Change 585604 had a related patch set uploaded (by Bartosz Dziewoński; owner: Bartosz Dziewoński):
[mediawiki/extensions/RevisionSlider@master] Do not show entries for hidden tags

https://gerrit.wikimedia.org/r/585604

matmarex moved this task from Needs Discussion / Investigation to Code Review on the Editing-team (Q3 2019-2020 Kanban Board) board.Apr 2 2020, 8:43 PM
gerritbot added a comment.Apr 13 2020, 2:14 PM

Change 585603 merged by jenkins-bot:
[mediawiki/extensions/RevisionSlider@master] Use tag displaynames when fetching additional revisions

https://gerrit.wikimedia.org/r/585603

gerritbot added a comment.Apr 13 2020, 2:14 PM

Change 585604 merged by jenkins-bot:
[mediawiki/extensions/RevisionSlider@master] Do not show entries for hidden tags

https://gerrit.wikimedia.org/r/585604

ReleaseTaggerBot added a project: MW-1.35-notes (1.35.0-wmf.28; 2020-04-14).Apr 13 2020, 3:00 PM
Maintenance_bot removed a project: Patch-For-Review.Apr 13 2020, 3:10 PM
matmarex moved this task from Code Review to QA on the Editing-team (Q3 2019-2020 Kanban Board) board.Apr 14 2020, 3:30 PM
matmarex added a project: Editing QA.Apr 14 2020, 3:33 PM
Ryasmeen edited projects, added Verified; removed Editing QA.May 29 2020, 10:10 PM
Ryasmeen moved this task from QA to Ready for Sign Off on the Editing-team (Q3 2019-2020 Kanban Board) board.
ppelberg closed this task as Resolved.Jun 5 2020, 1:22 AM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits