|Open||None||T234743 User rights validation is sometimes malfunctioning (with FlaggedRevs only?)|
|Resolved||Huji||T249643 Restore the "reviewer" group for fawiki|
@Huji Yes, all config patches needs to. You basically need to schedule the patch at https://wikitech.wikimedia.org/wiki/Deployments in any SWAT window (except Puppet SWAT :-)) and then be available in #wikimedia-operations during the window you chosed. Everything else can be explained during the SWAT deployment. More detailed instructions can be found at this GCI taskhttps://www.mediawiki.org/wiki/Google_Code-in/Admins#Deploy_a_Wikimedia_site_configuration_change_(2018/2019).
Config patches can be scheduled as soon as they're created, backports need to have +2 in master. You don't need to do anything extra with code patches that aren't urgent. Does that make sense?
That's what I thought too. Because I have submitted lots of non-urgent config patches, all of which were +2'ed and eventually deployed without me being involved with their scheduling or SWAT. So I was assuming that this patch would go through the same experience.
Eventually, it can happen someone who knows what the config patch will change and is at least somehow sure it is wanted by the community will deploy that patch without you being involved. However, that should be more an exception than a rule. I hope that makes sense.
Gotcha. With config patches, they're never merged without being deployed (and if they do, it's always a mistake). Thanks for scheduling your patches!
Is is possible to list on the Deployment page when the train is blocked, I scheduled patches last time (and was on IRC) only to be informed that it is policy to not conduct SWAT deploys when the train is blocked. :/
[OT] Perhaps you want to join https://groups.google.com/a/wikimedia.org/forum/#!forum/sitereq-l and discuss this kind of stuff there? :-) IMO it's too hard to specify all the kind of conditions that may lead to a SWAT deployer refusing to do the window.
Since you did not schedule it for SWAT, it sat there for more than a year until someone (Urbanecm in this case) found it randomly. You should have read Amir's comment to you here: https://gerrit.wikimedia.org/r/c/operations/mediawiki-config/+/430627/#message-387fdb008e056fa4b594e805d75f388b836d63d9 which was basically about this.