Maniphest T249817

Disable mobile view
Closed, ResolvedPublic2 Estimated Story Points
Actions

Description

Disable current mobile view for 2ColConflict interface and show the legacy version on mobile.

Details

	Subject	Repo	Branch	Lines +/-
	Temporarily disable new UI on mobile	mediawiki/extensions/TwoColConflict	master	+8 -0

Customize query in gerrit

Related Objects

Mentioned In: T250942: Enable, test and clean up the two-column interface on mobile (MinervaNeue)
Mentioned Here: T250942: Enable, test and clean up the two-column interface on mobile (MinervaNeue)

Event Timeline

ECohen_WMDE created this task.Apr 9 2020, 1:31 PM

ECohen_WMDE moved this task from Backlog to Product backlog on the Two-Column-Edit-Conflict-Merge board.

Lena_WMDE moved this task from Product backlog to Before full default on the Two-Column-Edit-Conflict-Merge board.Apr 23 2020, 8:11 AM

Lena_WMDE updated the task description. (Show Details)Apr 23 2020, 9:30 AM

Lena_WMDE set the point value for this task to 2.

thiemowmde mentioned this in T250942: Enable, test and clean up the two-column interface on mobile (MinervaNeue).Apr 23 2020, 9:48 AM

Lena_WMDE moved this task from Before full default to Tickets ready for pickup on the Two-Column-Edit-Conflict-Merge board.Apr 29 2020, 7:59 AM

Change 594198 had a related patch set uploaded (by Thiemo Kreuz (WMDE); owner: Thiemo Kreuz (WMDE)):
[mediawiki/extensions/TwoColConflict@master] Temporarily disable new UI on mobile

https://gerrit.wikimedia.org/r/594198

gerritbot added a project: Patch-For-Review.May 4 2020, 2:38 PM

It appears like this situation can only happen under rare circumstances. When I enable mobile view first and then cause an edit conflict, all I get is an error message telling me that a conflict happened.

What I have to do is:

Make sure I'm in desktop mode.
Start editing a page.
Cause an edit conflict in an incognito tab.
Try to save the first edit. Now I get the TwoColConflict UI.
Don't resolve the conflict yet. Instead, open a new tab and switch to mobile view in that tab.
Reload the first tab. Now a broken mobile experience is shown.

Note: It's only broken because neither the CSS nor the JavaScript is marked to load for mobile targets. This is easily fixed, see https://gerrit.wikimedia.org/r/592254 and T250942.

thiemowmde moved this task from Tickets ready for pickup to Tickets in sprint on the Two-Column-Edit-Conflict-Merge board.May 4 2020, 2:41 PM

thiemowmde added projects: WMDE-QWERTY-Sprint-2020-04-29, Unplanned-Sprint-Work.

thiemowmde moved this task from Sprint Backlog to Review on the WMDE-QWERTY-Sprint-2020-04-29 board.

Change 594198 merged by jenkins-bot:
[mediawiki/extensions/TwoColConflict@master] Temporarily disable new UI on mobile

https://gerrit.wikimedia.org/r/594198

Andrew-WMDE moved this task from Review to Demo on the WMDE-QWERTY-Sprint-2020-04-29 board.May 7 2020, 10:16 AM

ReleaseTaggerBot added a project: MW-1.35-notes (1.35.0-wmf.32; 2020-05-12).May 7 2020, 11:00 AM

Maintenance_bot removed a project: Patch-For-Review.May 7 2020, 11:10 AM

WMDE-Fisch closed this task as Resolved.May 12 2020, 11:37 AM

WMDE-Fisch claimed this task.

WMDE-Fisch moved this task from Demo to Done on the WMDE-QWERTY-Sprint-2020-04-29 board.