Page MenuHomePhabricator

Wikibase\Lib\Tests\Formatters\CachingKartographerEmbeddingHandlerTest::testGetHtml
Closed, ResolvedPublic

Description

This error in unit tests is blocking all my merges today across various repositories including MobileFrontend and Vector.

https://integration.wikimedia.org/ci/job/wmf-quibble-vendor-mysql-php72-docker/29384/console

3:26:10 There was 1 failure:
13:26:10 
13:26:10 1) Wikibase\Lib\Tests\Formatters\CachingKartographerEmbeddingHandlerTest::testGetHtml
13:26:10 === Logs generated by test case
13:26:10 [objectcache] [debug] MainWANObjectCache using store {class} {"class":"EmptyBagOStuff"}
13:26:10 [wfDebug] [debug] ParserFactory: using default preprocessor {"private":false}
13:26:10 [wfDebug] [debug] ParserOutput::addTrackingCategory: Not adding tracking category kartographer-tracking-category to special page! {"private":false}
13:26:10 [wfDebug] [debug] IP: 127.0.0.1 {"private":false}
13:26:10 [wfDebug] [debug] ContextSource::getContext (SkinVector): called and $context is null. Using RequestContext::getMain() for sanity {"private":false}
13:26:10 ===
13:26:10 Failed asserting that '<div class="mw-parser-output"><p><a class="mw-kartographer-map mw-kartographer-container floatleft" style="width: 310px; height: 180px;" data-mw="interface" data-style="osm-intl" data-width="310" data-height="180" data-zoom="13" data-lat="50" data-lon="1.1E-5" data-overlays="[&quot;_95e1e602ef011ab4b6b6240f50fed6474deb9681&quot;]" href="/index.php/Special:Map/13/50/1.1E-5/en"><img src="https://maps.wikimedia.org/img/osm-intl,13,50,1.1E-5,310x180.png?lang=en&amp;domain=127.0.0.1&amp;title=Special%3ABlankPage&amp;groups=_95e1e602ef011ab4b6b6240f50fed6474deb9681" alt="" width="310" height="180" decoding="async" srcset="https://maps.wikimedia.org/img/osm-intl,13,50,1.1E-5,310x180@2x.png?lang=en&amp;domain=127.0.0.1&amp;title=Special%3ABlankPage&amp;groups=_95e1e602ef011ab4b6b6240f50fed6474deb9681 2x" /></a>\n
13:26:10 </p></div>' contains "data-lon="1.0E-5"".
13:26:10 
13:26:10 /workspace/src/extensions/Wikibase/lib/tests/phpunit/Formatters/CachingKartographerEmbeddingHandlerTest.php:43
13:26:10 /workspace/src/tests/phpunit/MediaWikiIntegrationTestCase.php:424
13:26:10 /workspace/src/maintenance/doMaintenance.php:99

Event Timeline

Jdlrobson created this task.Apr 9 2020, 9:01 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptApr 9 2020, 9:01 PM
Restricted Application added a project: Wikidata. · View Herald TranscriptApr 9 2020, 9:02 PM

Change 587880 had a related patch set uploaded (by Jforrester; owner: Jforrester):
[mediawiki/extensions/Wikibase@master] CachingKartographerEmbeddingHandlerTest: Update assert value

https://gerrit.wikimedia.org/r/587880

Change 587880 merged by jenkins-bot:
[mediawiki/extensions/Wikibase@master] CachingKartographerEmbeddingHandlerTest: Update assert value

https://gerrit.wikimedia.org/r/587880

Jdforrester-WMF closed this task as Resolved.Apr 14 2020, 5:42 PM
Jdforrester-WMF claimed this task.
Jdforrester-WMF added a subscriber: Jdforrester-WMF.

Going to declare this Resolved. Ideally the test wouldn't change values, but eh.