$wgDefaultSkin value not set correctly for MinervaNeue skin
Open, LowPublic
Actions

Assigned To

None

Authored By

	Edtadros
	Apr 16 2020, 2:54 PM

Description

When following the instructions from DEVELOPERS.md, the $wgDefaultSkin parameter for the MinervaNeue skin is not set correctly:

Expected:

$wgDefaultSkin = 'minerva';

Actual:

$wgDefaultSkin = 'minervaneue';

Steps to Reproduce:

git clone "https://gerrit.wikimedia.org/r/mediawiki/core"
cd core/skins
git clone "https://gerrit.wikimedia.org/r/mediawiki/skins/MinervaNeue"

docker-compose up -d
docker-compose exec mediawiki composer update
docker-compose exec mediawiki /bin/bash /docker/install.sh

Workaround:
Edit the $wgDefaultSkin parameter in LocalSettings.php to:

$wgDefaultSkin = 'minerva';

Details

	Subject	Repo	Branch	Lines +/-
	Add minervaneue as valid skin name	mediawiki/skins/MinervaNeue	master	+2 -1

Customize query in gerrit

Event Timeline

Edtadros created this task.Apr 16 2020, 2:54 PM

Restricted Application added subscribers: Masumrezarock100, Aklapper. · View Herald TranscriptApr 16 2020, 2:54 PM

@Edtadros: Assuming this task is about the MinervaNeue code base, hence adding that project tag so other people can find this task when searching via projects.

Edtadros updated the task description. (Show Details)Apr 16 2020, 2:59 PM

Edtadros triaged this task as Low priority.Apr 16 2020, 3:02 PM

Edtadros added projects: MediaWiki-Docker, MediaWiki-Installer.

Edtadros updated the task description. (Show Details)Apr 16 2020, 3:06 PM

Edtadros updated the task description. (Show Details)

Edtadros updated the task description. (Show Details)Apr 16 2020, 3:09 PM

Edtadros updated the task description. (Show Details)

@Edtatros: Hmm, how is this related to code in the MediaWiki-Docker and MediaWiki-Installer code bases?

Change 589339 had a related patch set uploaded (by Kosta Harlan; owner: Kosta Harlan):
[mediawiki/skins/MinervaNeue@master] Add minervaneue as valid skin name

https://gerrit.wikimedia.org/r/589339

gerritbot added a project: Patch-For-Review.Apr 16 2020, 3:24 PM

Yeah, I see this as a MinervaNeue issue, so untagging the other projects. I've pushed a patch which should address the problem you see.

I've added a note on the patch but the key cannot be changed easily.

Is there a problem with using the workaround? This is documented here: https://www.mediawiki.org/wiki/Skin:Minerva_Neue#Installation

$wgDefaultSkin = 'minerva';

If we want to support the minervaneue case we'd need to make it possible for a skin to have multiple skin keys which requires a change in core which I fear will be a little complicated so we'd want to go have good reason to go down that rabbit hole.

Change 589339 abandoned by Kosta Harlan:
Add minervaneue as valid skin name

https://gerrit.wikimedia.org/r/589339

Maintenance_bot removed a project: Patch-For-Review.Apr 16 2020, 7:10 PM

$wgDefaultSkin value not set correctly for MinervaNeue skinOpen, LowPublicActions

Description

Details

Event Timeline

$wgDefaultSkin value not set correctly for MinervaNeue skin
Open, LowPublic
Actions