Parser::getFreshParser sometimes returns $this. This is a relic of previous code which had a global $wgParser which it kept alive forever and tried to reuse. We should let the $parser go out of scope and get gc'ed and just create a new one if/when needed, instead of playing games and trying to reuse parser state.
Description
Description
| Status | Subtype | Assigned | Task | ||
|---|---|---|---|---|---|
| Open | None | T261329 Prepare Parsoid for MW | |||
| Open | None | T236809 Refactor Parser.php to allow alternate parser (Parsoid) | |||
| Declined | None | T250750 Parser::getFreshParser should always return a fresh parser |
Event Timeline
Comment Actions
The function is deprecated and it seems not useful to change the behaviour, it is better to remove the usage (T325959)