Guard maintenance scripts that interact with certain entity types against use when on repo without the type locally
Closed, ResolvedPublic5 Estimated Story Points
Actions

Description

I raised this in the CR of https://gerrit.wikimedia.org/r/#/c/mediawiki/extensions/Wikibase/+/591971/6

repo/maintenance/pruneItemsPerSite.php is a repo script, and now we have repos without all entity types enabled.
This means a simple check that repo is enabled is no longer enough, and if a maintenance script interacts with "items" it should only be allowed to run on a repo with "items" on the local entity source.

We should audit all of our maintenance scripts and add this check where we deem necessary.

Acceptance Criteria🏕️🌟 :

All repo maintenance scripts that interact with a specific entity type should ensure it exists on the local entity source

Details

	Subject	Repo	Branch	Lines +/-
	Guard maintenance scripts against running on foreign entity types	mediawiki/extensions/Wikibase	master	+35 -0

Customize query in gerrit

Event Timeline

Addshore created this task.Apr 22 2020, 8:29 PM

Restricted Application added a project: Wikidata. · View Herald TranscriptApr 22 2020, 8:29 PM

Restricted Application added a subscriber: Aklapper. · View Herald Transcript

Addshore renamed this task from Guard maintenance scripts that interact with certain entity types against use when on repo without the type lcoally to Guard maintenance scripts that interact with certain entity types against use when on repo without the type locally.Apr 22 2020, 8:29 PM

hoo subscribed.Apr 23 2020, 11:42 AM

Addshore edited projects, added [DEPRECATED] wdwb-tech; removed Wikidata-Campsite.Jul 16 2021, 8:07 AM

Addshore moved this task from Inbox to To Prioritize on the [DEPRECATED] wdwb-tech board.Jul 19 2021, 2:09 PM

Addshore moved this task from To Prioritize to Triaged High (100+) on the [DEPRECATED] wdwb-tech board.Jul 20 2021, 2:40 PM

Addshore added a project: Wikidata-Campsite.Jul 20 2021, 2:45 PM

Addshore moved this task from Incoming to Prioritized Wikidata Tech Backlog (prioritised from top to bottom) on the Wikidata-Campsite board.

Addshore triaged this task as Medium priority.Jul 20 2021, 2:47 PM

Addshore updated the task description. (Show Details)Jul 21 2021, 8:19 AM

Addshore updated the task description. (Show Details)