Page MenuHomePhabricator
Create Task
Maniphest T251025

Adyen/iDEAL message getting from DonationInterface to Civi missing payment_submethod
Closed, ResolvedPublic
Actions

Description

Invoice ID 80188432.1, April 23rd 2020.

Details

SubjectRepoBranchLines +/-
Don't clear sole submethod on validate failmediawiki/extensions/DonationInterfacemaster+11 -5
Test to examine log & queue msg for RTBTmediawiki/extensions/DonationInterfacemaster+63 -0
Adyen iDEAL audit parse testwikimedia/fundraising/SmashPigmaster+29 -0
Debug logging for missing payment_submethodmediawiki/extensions/DonationInterfacemaster+18 -0
Audit parsing: Use non-blank values in mergewikimedia/fundraising/crmmaster+60 -2
Customize query in gerrit

Event Timeline

Ejegg created this task.Apr 25 2020, 2:34 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptApr 25 2020, 2:34 PM
• DStrine moved this task from Triage to Sprint +1 on the Fundraising-Backlog board.Apr 27 2020, 3:32 PM
• DStrine moved this task from Sprint +1 to Current Sprint on the Fundraising-Backlog board.Apr 28 2020, 8:07 PM
• DStrine added a project: Fundraising Sprint Ice cream cures everything.Apr 28 2020, 8:18 PM
Ejegg claimed this task.May 4 2020, 4:27 PM
Ejegg moved this task from Backlog to Doing on the Fundraising Sprint Ice cream cures everything board.
gerritbot added a comment.May 4 2020, 4:40 PM

Change 594233 had a related patch set uploaded (by Ejegg; owner: Ejegg):
[wikimedia/fundraising/SmashPig@master] Adyen iDEAL audit parse test

https://gerrit.wikimedia.org/r/594233

gerritbot added a project: Patch-For-Review.May 4 2020, 4:40 PM

Change 594213 had a related patch set uploaded (by Ejegg; owner: Ejegg):
[mediawiki/extensions/DonationInterface@master] Test to examine log & queue msg for RTBT

https://gerrit.wikimedia.org/r/594213

gerritbot added a comment.May 4 2020, 5:39 PM

Change 594252 had a related patch set uploaded (by Ejegg; owner: Ejegg):
[wikimedia/fundraising/crm@master] Audit parsing: Use non-blank values in merge

https://gerrit.wikimedia.org/r/594252

gerritbot added a comment.May 4 2020, 9:00 PM

Change 594306 had a related patch set uploaded (by Ejegg; owner: Ejegg):
[mediawiki/extensions/DonationInterface@master] Debug logging for missing payment_submethod

https://gerrit.wikimedia.org/r/594306

Ejegg moved this task from Doing to Review on the Fundraising Sprint Ice cream cures everything board.May 4 2020, 11:48 PM
gerritbot added a comment.May 5 2020, 3:27 PM

Change 594252 merged by jenkins-bot:
[wikimedia/fundraising/crm@master] Audit parsing: Use non-blank values in merge

https://gerrit.wikimedia.org/r/594252

gerritbot added a comment.May 6 2020, 4:34 PM

Change 594306 merged by jenkins-bot:
[mediawiki/extensions/DonationInterface@master] Debug logging for missing payment_submethod

https://gerrit.wikimedia.org/r/594306

ReleaseTaggerBot added a project: MW-1.35-notes (1.35.0-wmf.32; 2020-05-12).May 6 2020, 5:00 PM
gerritbot added a comment.May 8 2020, 4:12 PM

Change 594233 merged by jenkins-bot:
[wikimedia/fundraising/SmashPig@master] Adyen iDEAL audit parse test

https://gerrit.wikimedia.org/r/594233

gerritbot added a comment.May 8 2020, 4:26 PM

Change 594213 merged by jenkins-bot:
[mediawiki/extensions/DonationInterface@master] Test to examine log & queue msg for RTBT

https://gerrit.wikimedia.org/r/594213

Maintenance_bot removed a project: Patch-For-Review.May 8 2020, 5:10 PM
• mepps subscribed.May 11 2020, 5:48 PM

All the patches here look merged. Move to pending deploy?

Ejegg added a comment.May 11 2020, 6:10 PM

The last patch added some logging, but it didn't fix the problem. I was leaving the task in 'doing' till we got another one with some more diagnostic info to help reproduce the issue.

• mepps moved this task from Review to Doing on the Fundraising Sprint Ice cream cures everything board.May 11 2020, 6:23 PM

Cool @Ejegg moving it back to "doing" for now :).

• DStrine added a project: Fundraising Sprint Just space out.May 12 2020, 8:34 PM
Ejegg moved this task from Backlog to Review on the Fundraising Sprint Just space out board.May 13 2020, 9:23 PM
gerritbot added a comment.May 13 2020, 9:26 PM

Change 596286 had a related patch set uploaded (by Ejegg; owner: Ejegg):
[mediawiki/extensions/DonationInterface@master] Don't clear sole submethod on validate fail

https://gerrit.wikimedia.org/r/596286

gerritbot added a project: Patch-For-Review.May 13 2020, 9:26 PM
gerritbot added a comment.May 13 2020, 10:26 PM

Change 596286 merged by jenkins-bot:
[mediawiki/extensions/DonationInterface@master] Don't clear sole submethod on validate fail

https://gerrit.wikimedia.org/r/596286

ReleaseTaggerBot edited projects, added MW-1.35-notes (1.35.0-wmf.34; 2020-05-26); removed MW-1.35-notes (1.35.0-wmf.32; 2020-05-12).May 13 2020, 11:00 PM
Maintenance_bot removed a project: Patch-For-Review.May 13 2020, 11:10 PM
Ejegg moved this task from Doing to Done on the Fundraising Sprint Ice cream cures everything board.May 13 2020, 11:33 PM

Deployed a fix for the underlying problem! If we don't see the errors for another few weeks we can revert the debug logging patch.

Ejegg moved this task from Review to Done on the Fundraising Sprint Just space out board.May 20 2020, 3:46 PM
• DStrine closed this task as Resolved.May 26 2020, 8:28 PM
• DStrine removed a subscriber: • mepps.Feb 17 2021, 4:27 PM
AnnWF added a project: FR-Alerts.Jul 15 2022, 10:06 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL