@AndyRussG @DStrine Maybe we should take this off the board until we get a new patch?

@Ejegg Has this been deployed?

@XenoRyet I see patches merged. Should this be moved to "Pending Deployment"?

@AndyRussG How you would you like this reviewed? I wasn't sure if this is what you and @jgleeson talked about yesterday, but it's a long train of patches and I'm wondering if we should start by +2ing the original patch, or work from the top down.

@Ejegg What is the best way to test this change?

Thanks @Ejegg! @AndyRussG anything to add? @DStrine I assume we don't have hours left to fix this. Should we be doing it ourselves?

@AndyRussG @Ejegg Above is what I remembered offhand today.

Notes from tech-talk review:

We talked about this in fortnightly today. @NNichols If you search for Communication:Employer Name Regex [a-zA-Z] that will return only those with values. (Not Empty works too but is slow.)

This was emotionally difficult but I went ahead and removed all his roles and blocked his user. @Eileenmcnaughton any thoughts on whether we should delete his user or keep it for historical records (as in any changes he might have made in Civi)?

@cwdent, @Eileenmcnaughton and I were just discussing that it might be helpful if we put up notes like those at the bottom of the collab page she linked for any time there is an outage.

I didn't know this existed! I need to add a link on the documentation homepage.

@chasemp Sorry this dropped of my radar! Finally done today. Thanks for the pings :).

Weird @Cstone looks like you correctly linked the task but it didn't show up here. Thanks!

@XenoRyet did I remember you talking about this yesterday in standup or was it another part of contribution_tracking?

@Cstone where is your patch for this that we were looking at?

@Ejegg some of the errors were from Monday though.

@MBeat is #577898 a uk or swedish donor?

@cwdent @Ejegg can we close this now? Or should we work on a test plan for the next upgrade first perhaps?

I'm moving this to done, but more feedback is still welcome.

@CaitVirtue will we be checking if their employer matches the gift? If I saw that text on a donation form, I'd expect an automatic lookup.

@cwdent @Jeff_Green @Ejegg where are we on testing this?

Weird @Ejegg I can see it on my iPhone 7.

Our next step is to update the CSP settings, and test both ourselves, and see if we can get any in-country donors to test. Then we can switch back over during higher traffic European times, and do a live test for a few hours. @cwdent @Ejegg does that sound right to you?

@Ejegg would we both write to the db and use a queue?

@Ejegg Thanks! It looks good. I'm closing this.

@Ejegg I don't see any edits from you in the page history. Where did you put them?

@jgleeson can you be ready to handle any fr-tech engineer needs when you start work until 4:30 utc on Monday? Then @XenoRyet will take over.

@jgleeson @XenoRyet @AndyRussG I'd love your feedback on the new homepage. @Cstone, @Ejegg I made a couple minor changes since I last showed you, and if you have more thoughts, I'd love to hear them!

Next todo: break Dashboard out into it's own page

I've started on this. Currently trying to decide which headings belong on the main page versus sub pages. I want to break up the big block called "Documents" and move the software installation to a separate page.

Oops, this was just a mistaken click!

@Cstone @Ejegg want to review this?

@cwdent With your go ahead, @DStrine will reach out to advancement to schedule a time with the least amount of campaign traffic possible.

@cwdent I believe we discussed that you felt better about this with @Jgreen's plan. Are we okay to schedule this?

Page created at https://collab.wikimedia.org/wiki/Fundraising/Engineering/Onboarding. Now I need to re-add links and formatting.

@Ejegg would this be a good tech talk topic or pairing exercise?

I also updated my column!

@Cstone I added you but did not fill in any boxes.

Thanks @cwdent for taking the time to answer to each question. It sounds like you're very concerned about deploying this change, and I appreciate that given the importance of the effected systems.

@cwdent Does @Ejegg's comment resolve your concerns?

@cwdent @Ejegg @DStrine Can we get on a call to discuss this?

@sbassett Thanks!

Let's break this conversation about opt_in into a separate task.

So the query that gets bogged down is in CRM_Dedupe_BAO_RuleGroup.php on line 204. Note that if it goes through a similar but not identical query on line 198 the db does not get locked in the same way. It looks like all Contact profile forms end up deduping, though I'm not sure why.

I was able to replicate this in the Contact Summary Layout Major Gifts uses. When I tried to add tags, it froze and then locked up the database.

Both issues appear to be caused by the js in the selector. Unfortunately I'm trying to repair my local civi install so I can't debug. In my testing, it could find me, but if I selected another search option then tried to go back to Name, it suddenly couldn't find me.

@Ejegg have we tidied this up in civi? Otherwise we should create a separate ticket for that work.

Thanks @CCogdill_WMF!

I see a patch merged @Ejegg. Is this pending deployment?

@DStrine I don't currently have permission on the attached doc, so I'm wondering if other fr-tech engineers would.

@Ejegg what are the steps to complete this? It would be helpful to know for next year too.

@jcrespo I just returned from maternity leave and I can approve this request.

@MBeat33 Do you have any recent examples of where you've seen this? All the older examples seem to have been corrected now.

Seeing if I can catch it in a test. @Ejegg have we seen this with any other gateways?

I'm trying to dig into this a bit but struggling to find where the error would be happening now.

This is deployed.

@Ejegg @eileen I just tried to go to this CID and it seems to have timed out. This is not happening on all cids.

Put it on my calendar for Monday.

@Ejegg can we close this?

@Ejegg I'm seeing a patch merged here. Is this task Pending Deployment?

@Ejegg should we go ahead and turn this on? We'd need to add settings to donationinterface.settings.php and create the job.