Fri, Mar 27
I'm going to move this documentation but I wanted to write down how I got the servers working:
vagrant up vagrant roles enable centralnotice vagrant provision vagrant config nfs_shares off vagrant reload --provision
Note the first couple commands error out but they still need to run.
Thu, Mar 26
@spatton @TSkaff Would you guys want to test out the recent work done on Geotargeting? We have a site set up. You'd just need to create an account and give me the info. I'd be happy to set up a call to go over it.
@DStrine @AndyRussG @Ejegg This is now ready to test at http://cn-stage-2.wmflabs.org/wiki/Special:CentralNotice. Anyone who wants to test should create an account and let me know so I can make them an admin. Who should sign off on this?
Wed, Mar 25
I like the idea of adding documentation as part of this!
Tue, Mar 24
cid 41437821 appears to have their contribution recorded even though the message is still listed in the /damaged view.
This actually looks like a new contribution based on the amount--it looks like it could be from upsell.
Hmm one belongs to CID 10936530 that has a recurring payment which hasn't been run since June 6th 2019.
Mon, Mar 23
@Eileenmcnaughton Can you update the link above with instructions for Civicrm upgrades? I wasn't sure how our custom code in the civi repo is differentiated or if it's all been moved to extensions now.
Wed, Mar 11
@AndyRussG what day should we merge the outstanding commits to master?
I +2ed one of the patches above. Another is from Sept 2019 and has a comment waiting for reply. The third I +1ed but I wasn't clear about the context on the page we were deleting. I saw a Phab task about it but don't know enough of the history of the CNReporter page to feel comfortable +2ing that patch.
I see all patches merged. Can this be moved?
Closing as we have this set up.
Mon, Mar 9
Thu, Mar 5
These are the patches I see waiting for review (aside from Geotargeting and Banner templates). Do we have others @AndyRussG?
Each shore should also be documented.
Wed, Mar 4
Mon, Mar 2
Feb 27 2020
Actually since writing that I'm much closer on the first problem, just have to remember how to slice off the last two characters of a string.
- If we're going to display the regions the same way as the dashboard, I for some reason am blanking on how to group them all by country and then convert to a string. In one iteration I had the object but my brain wouldn't recreate how to pull it out into a string.
- I've wondered how the UX will be if the list is too long and played with some other formats, though as I write I'm thinking the first is probably best. (Other formats like, listing countries, then saying X number regions in another countries list.)
@Ejegg could you either review or nominate someone to review?
Feb 25 2020
@Ejegg here's what works for me ssh cn-staging-2.centralnotice-staging.eqiad.wmflabs. And in my ssh config file, I have:
@Ejegg yeah it actually was pretty straightforward, and I followed the steps you stated above. The only trick was adding lines to LocalSettings.php but those are in the CentralNotice documentation. The hard part was the nfs errors on the first instance.
Feb 24 2020
Oops I meant a server to preview banners as opposed to this which is for the geotargeting feature.
@Ejegg great! Do we feel like this is able to be closed as originally scoped? I think we have another task about creating an actual preview server?
Feb 13 2020
I made these changes on staging but as a note, I just made a local commit on frdev and updated the original patch because git fetch wasn't working...
Feb 12 2020
Hmm I also just noticed that the countries and regions still show up even if geotargeting is not checked.
I fixed the All except/numerical code bug! The all list was returning the array_keys instead of the values. Now working on getting one cohesive list.
@Ejegg no I couldn't get vagrant up on it due to nfs issues.
Feb 11 2020
Documenting my current thinking: need to tackle the array_diff error listed above. It seems to be how the array is passed in to the makeShortList. Also I want to move the list logic to one function in CentralNotice whereas now it's split up into two separate functions of listCountries and listRegions neither of which is used outside of CNCampaignPager.
Feb 10 2020
So it's in the array_diff function in CentralNotice.php:1788 that causes this. Otherwise it would be strings. There are a few things to approach on this task.
@MBeat33 we put a fix in place for the minfraud issue on Friday, so the additional charges not on the 7th would be something different. I tried an initial grep of the logs for one contribution but couldn't find the id listed there. Is that Ingenico's reference number?
Feb 6 2020
In working on this I've noticed this "All except" language being used, but it's not being applied correctly. In the example in the screenshot, the regions listed are the ones selected, not the ones excepted. (Also this is my dumb way of combining them but obviously I need to deal with that initial comma.
In my initial investigation, it looks like we can't mimic the exact way it looks in the columns because as of now, the columns in Special:CentralNotice use region numerical codes and what's available in js for the selector tree is either the text name or a letter code.
I'm thinking about the best way to approach this.
That makes sense Ejegg! I made you an admin.
Feb 5 2020
@Ejegg This is what I see in the main CN page under Add a Banner. It looks correct under edit though.
Closing because CI got fixed.
Yay! However I might need to open another one because currently the js is broken on the main campaigns screen for geotargeting (but not on edit).
From @Ejegg: This other ticket: T243012 is about showing the full list under the tree selector (rather than just the count of countries and regions) so that people can see at a glance what's selected, without scrolling through the whole tree selector.
So this I actually do see happening already.
Oops sorry, I misread the task, and also the way I set up the test data confused me.. This is what I see for this and now I get what you mean. It looks like we've previously used the countries column. Which one should we use going forward? Also it's a little weird that if a region of a country is included but not the whole country, it doesn't count as a country. I can see the argument for it but it's confusing as a user.
This is what I see in the edit screen @Ejegg. What did you have in mind?
Feb 4 2020
The counter is kind of under the tree select but I assume we'll address it in T243012
I see that this is sort of done except it currently lists regions by their number (otherwise might be longer). Do we want to change that?
There may still be some work to finish set up (that I'm working on), but figured it could be in review since CN can be found here: http://cn-stage-2.wmflabs.org/wiki/Special:CentralNotice :).
Jan 22 2020
Jan 21 2020
Jan 16 2020
With only one working day left in this sprint, I'm going to move this to Sprint B, with the idea that we'll break out the two issues Elliott mentioned into separate tasks. Rebasing the patch should probably be a separate task as well.
Jan 15 2020
I'm trying to test my patch locally but the banners still aren't displaying with "error: Not Found" in mw.centralNotice.data.errorMsg.
Jan 13 2020
@AndyRussG Okay, I can see what you mean. When I look at the loop what I see is that state.setCampaign is called early on and that should set the status to CAMPAIGN_CHOSEN for the campaign that gets selected. cancelBanner is called if hide.shouldHide() is true. Just recording my findings as I go.
Jan 9 2020
@AndyRussG I tried copying and pasting that query using impyla but I'm getting:
"HiveServer2Error: Error while compiling statement: FAILED: ParseException line 4:0 missing EOF at 'SELECT' near ')'". -- This is resolved so this comment can be ignored.
Also @AndyRussG what is the correct, expected behavior here?
@AndyRussG Is there any documentation of what these status codes mean?