Should this be closed @AndyRussG? 3/4 of these are merged.

I think this would have been deployed by now?

Okay, I took a stab at this. @DStrine Want to take a look?

@Eileenmcnaughton in starting this I realized I didn't know whether we used the On Hold field in Civi or do not solicit for those who unsubscribe?

@AndyRussG Where are we with this? I'm thinking it's in the wrong column.

The error display was resolved in https://phabricator.wikimedia.org/T149240, in that it now says "You do not have the correct permissions to perform the requested action or the action itself was invalid." as opposed to a full stack trace. However, I wonder if it's worth displaying the specific error message when a user inputs an invalid format.

Note: FR wants to do a test of adyen versus globalcollect and waiting on this is a minor blocker. It looks like it's a 1. @Ejegg do you know why this got prioritized for Sprint S?

Yup @Ejegg I got it. I'll put up a patch tomorrow morning.

@Ejegg Oh! I think this is caused by the type being "number" as I've learned it happens when any value with a decimal place is entered.

@CCogdill_WMF Can you confirm whether you see the error message when you directly click on the "Donate Monthly" button versus just tabbing away? That's what I found in my testing but want to confirm it. Thanks!

I'm currently thinking this might be something from Firefox, because I noticed the red highlighting doesn't happen in Chrome and the errorHighlight class doesn't seem to have actually been applied. I'm trying to test one more idea.

There are two places I thought the initial error highlighting might be coming from: validation_input and ext.donationinterface.validation.js, but when I enter console.log statements in them, they are not logged.

Okay, so I've found more interesting behavior. Basically the error highlighting appears if I tab away from the box, but when I click "Donate Monthly" the error text appears. I've been trying to find where in the code the highlight is applied but haven't found it yet.

@XenoRyet Want to take a look at this or ask someone else to review?

So I had a weird experience testing this locally. I saw the error on my first test. Then I added some logging and tested again, and strangely the error text showed up! Then I tried to test without the logging (though it seemed weird if that fixed it) and there was an unrelated bug on ingenico's side that prevented me from testing further.

Note definition of done, with Phab tasks listed, but not created.

@XenoRyet are you taking a look at this? @Ejegg thought he remembered you saying you might.

Or anyone else who remembers what our plan was? @Ejegg remembers something about mustache templates.

@jgleeson what did we plan to do here? Please write it up if you have time before leaving for Wikimania.

@Cstone @XenoRyet Either of you want to tackle this? I could try to help tomorrow morning too.

@Eileenmcnaughton It looks like you started this?

This page: https://www.mediawiki.org/wiki/Fundraising_tech/CiviCRM

Hmm, so one question. Are we just looking for the fields in the custom set "Communication"? Also, I agree that so far there is no obvious place in our documentation to put this, but that means we need to create one.

@DStrine Do you just want the list on the task or somewhere else?

This also happened in 2017 with cid 1092521. The pending recurring contributions report (where I found this) only has 5 rows though so it's possible this is a limited issue.

@AndyRussG @DStrine Maybe we should take this off the board until we get a new patch?

@Ejegg Has this been deployed?

@XenoRyet I see patches merged. Should this be moved to "Pending Deployment"?

@AndyRussG How you would you like this reviewed? I wasn't sure if this is what you and @jgleeson talked about yesterday, but it's a long train of patches and I'm wondering if we should start by +2ing the original patch, or work from the top down.

@Ejegg What is the best way to test this change?

Thanks @Ejegg! @AndyRussG anything to add? @DStrine I assume we don't have hours left to fix this. Should we be doing it ourselves?

@AndyRussG @Ejegg Above is what I remembered offhand today.

Notes from tech-talk review:

We talked about this in fortnightly today. @NNichols If you search for Communication:Employer Name Regex [a-zA-Z] that will return only those with values. (Not Empty works too but is slow.)

This was emotionally difficult but I went ahead and removed all his roles and blocked his user. @Eileenmcnaughton any thoughts on whether we should delete his user or keep it for historical records (as in any changes he might have made in Civi)?

@cwdent, @Eileenmcnaughton and I were just discussing that it might be helpful if we put up notes like those at the bottom of the collab page she linked for any time there is an outage.

I didn't know this existed! I need to add a link on the documentation homepage.

@chasemp Sorry this dropped of my radar! Finally done today. Thanks for the pings :).

Weird @Cstone looks like you correctly linked the task but it didn't show up here. Thanks!

@XenoRyet did I remember you talking about this yesterday in standup or was it another part of contribution_tracking?

@Cstone where is your patch for this that we were looking at?

@Ejegg some of the errors were from Monday though.

@MBeat is #577898 a uk or swedish donor?

@cwdent @Ejegg can we close this now? Or should we work on a test plan for the next upgrade first perhaps?

I'm moving this to done, but more feedback is still welcome.

@CaitVirtue will we be checking if their employer matches the gift? If I saw that text on a donation form, I'd expect an automatic lookup.

@cwdent @Jeff_Green @Ejegg where are we on testing this?

Weird @Ejegg I can see it on my iPhone 7.

Our next step is to update the CSP settings, and test both ourselves, and see if we can get any in-country donors to test. Then we can switch back over during higher traffic European times, and do a live test for a few hours. @cwdent @Ejegg does that sound right to you?

@Ejegg would we both write to the db and use a queue?

@Ejegg Thanks! It looks good. I'm closing this.

@Ejegg I don't see any edits from you in the page history. Where did you put them?

@jgleeson can you be ready to handle any fr-tech engineer needs when you start work until 4:30 utc on Monday? Then @XenoRyet will take over.

@jgleeson @XenoRyet @AndyRussG I'd love your feedback on the new homepage. @Cstone, @Ejegg I made a couple minor changes since I last showed you, and if you have more thoughts, I'd love to hear them!

Next todo: break Dashboard out into it's own page

I've started on this. Currently trying to decide which headings belong on the main page versus sub pages. I want to break up the big block called "Documents" and move the software installation to a separate page.

Oops, this was just a mistaken click!

@Cstone @Ejegg want to review this?

@cwdent With your go ahead, @DStrine will reach out to advancement to schedule a time with the least amount of campaign traffic possible.

@cwdent I believe we discussed that you felt better about this with @Jgreen's plan. Are we okay to schedule this?