With only one working day left in this sprint, I'm going to move this to Sprint B, with the idea that we'll break out the two issues Elliott mentioned into separate tasks. Rebasing the patch should probably be a separate task as well.

I'm trying to test my patch locally but the banners still aren't displaying with "error: Not Found" in mw.centralNotice.data.errorMsg.

@AndyRussG, @Ejegg and I think we see what happened, and I've made a commit. However, I don't know how to test it. Any thoughts on that?

@AndyRussG Okay, I can see what you mean. When I look at the loop what I see is that state.setCampaign is called early on and that should set the status to CAMPAIGN_CHOSEN for the campaign that gets selected. cancelBanner is called if hide.shouldHide() is true. Just recording my findings as I go.

@AndyRussG I tried copying and pasting that query using impyla but I'm getting:
"HiveServer2Error: Error while compiling statement: FAILED: ParseException line 4:0 missing EOF at 'SELECT' near ')'".

Also @AndyRussG what is the correct, expected behavior here?

@AndyRussG Is there any documentation of what these status codes mean?

For my own notes, all of this happens in state.js.

Goal for Sprint A: Get local donation into Civi and ready to recur (but not the recurring job set up).

From tech-talk, Jack: 1. Hosted Payment pages--learn more from Adyen, 2. enhance smashpig handling of back-end to handle recurring payment authorize/capture actions, access token 3. Wire up existing smashpig job tool to call new adyen actions

@Nuria @elukey Thank you so much for moving this back! I appreciate all your questions and helpful explanations about the implications of this change.

@Nuria Thanks for the quick and thorough response! To confirm, I read your comments as saying no kafka streams will either have downtime on December 2nd or require authentication. Is that correct?

I have no doubts about this change generally, but Fundraising and Fundraising tech rely on this data heavily and will have just started the annual fundraiser on December 2nd. Could this change be made in mid-December or early January? The risk is that we won't have access to highly needed data while thousands of donations are coming in.

@MBeat33 @DStrine How do we want to handle donors who have not donated in the previous year? We currently have no handling for this because we were only sending to donors who had made a recurring contribution.

@jijiki Let's go with sustainability@. Thanks!

Good question @Aklapper! It is environmental sustainability. I was going for brevity, but I'm open to environmental-sustainability@lists.wikimedia.org if it makes more sense.

Thanks @CCogdill_WMF! @Eileenmcnaughton was it intentional that saying "no" on opt-in doesn't lead to opt out or are they actually opted out?

Basically the issue seems to be that not opting_in doesn't opt out of bulk mail, correct @MBeat? Did the donor get a bulk email? Also is this the behavior we want @CCogdill_WMF?

@MBeat it looks like the contact was created on 10/2 and the only change after that was the activity record.

@MBeat Thanks! I see opt-in listed as no, and my expectation is that that's what that form maps to, but do you think she would also get "On Hold" on her email address? I don't see "is_opt_out" available on her record as this documentation would suggest. https://www.mediawiki.org/wiki/Fundraising_tech/CiviCRM Which specific field are you looking for, just so I can start looking.

@MBeat did you already manually update this contact? Just curious as I'm investigating.

Thanks @Jdlrobson!

I couldn't reproduce locally, but based on what I saw stepping through the debugger, it looks like when there is no campaign or iterations, the campaign variable is undefined. There is logic for the campaign being null but not undefined. I assumed we'd handle both the same way and added an or campaign === undefined. @AndyRussG Let me know what you think!

@AndyRussG It looks like you were working on this and put something out yesterday. Should it be in review/deployed?

I went with MaxCampaignFallback because I thought it had a better ring to it than using Iterations. I also noticed there's another config variable named FallbackHideCookieDuration which seems unrelated to Campaign Fallback so this name might be more clear than MaxFallbackIterations. Another options is MaxFallbackCampaign but I might be overthinking it :).

Hmm, we think this could be pulling the gift source and using and if conditional in the thank you letter.

@jrobell, @Ejegg added documentation for how to make the request to analytics above.

@Ejegg are you working on this and should it be moved to "Doing"?

@Eileen I updated this documentation based on my knowledge, but I wasn't sure where is_opt_out was on the Contact record..do we use it?

@Dstine I added those to the documentation a while back but didn't update the task.

Should this be closed @AndyRussG? 3/4 of these are merged.

I think this would have been deployed by now?

Okay, I took a stab at this. @DStrine Want to take a look?

@Eileenmcnaughton in starting this I realized I didn't know whether we used the On Hold field in Civi or do not solicit for those who unsubscribe?

@AndyRussG Where are we with this? I'm thinking it's in the wrong column.

The error display was resolved in https://phabricator.wikimedia.org/T149240, in that it now says "You do not have the correct permissions to perform the requested action or the action itself was invalid." as opposed to a full stack trace. However, I wonder if it's worth displaying the specific error message when a user inputs an invalid format.

Note: FR wants to do a test of adyen versus globalcollect and waiting on this is a minor blocker. It looks like it's a 1. @Ejegg do you know why this got prioritized for Sprint S?

Yup @Ejegg I got it. I'll put up a patch tomorrow morning.

@Ejegg Oh! I think this is caused by the type being "number" as I've learned it happens when any value with a decimal place is entered.

@CCogdill_WMF Can you confirm whether you see the error message when you directly click on the "Donate Monthly" button versus just tabbing away? That's what I found in my testing but want to confirm it. Thanks!

I'm currently thinking this might be something from Firefox, because I noticed the red highlighting doesn't happen in Chrome and the errorHighlight class doesn't seem to have actually been applied. I'm trying to test one more idea.

There are two places I thought the initial error highlighting might be coming from: validation_input and ext.donationinterface.validation.js, but when I enter console.log statements in them, they are not logged.

Okay, so I've found more interesting behavior. Basically the error highlighting appears if I tab away from the box, but when I click "Donate Monthly" the error text appears. I've been trying to find where in the code the highlight is applied but haven't found it yet.

@XenoRyet Want to take a look at this or ask someone else to review?

So I had a weird experience testing this locally. I saw the error on my first test. Then I added some logging and tested again, and strangely the error text showed up! Then I tried to test without the logging (though it seemed weird if that fixed it) and there was an unrelated bug on ingenico's side that prevented me from testing further.

Note definition of done, with Phab tasks listed, but not created.

@XenoRyet are you taking a look at this? @Ejegg thought he remembered you saying you might.

Or anyone else who remembers what our plan was? @Ejegg remembers something about mustache templates.

@jgleeson what did we plan to do here? Please write it up if you have time before leaving for Wikimania.

@Cstone @XenoRyet Either of you want to tackle this? I could try to help tomorrow morning too.