Wed, Sep 22
A couple of questions to add after talking with @Madalina today:
- How many times is a user shown a survey? Each page visit until answering or just once?
- Would we want users to be able to opt out of all surveys? Or just temporarily for one survey, or both options? (Maybe a close button that dismissed the individual survey for the session and a "don't show me these again" which updates the user preferences)
@Jhernandez My understanding of the answer to these questions as of now is:
- Can we sample based on logged-in status? yes (can set anon to false)
- Can we sample based on edit count? yes (can set minEdits and maxEdits)
- Can we sample based on a time frame for a number of edits? no
Tue, Aug 31
@Niharika Based on my read, it also looks like the 10 day delay would only be when there were holidays too. What's the next step here assuming we're okay with that? It sounds like @sbassett is moving forward with looking into this.
Aug 3 2021
As the engineering manager supporting AHT while Jay Cano is out, I approve this. I'm tagging the Release-Engineering-Team based on the other ticket.
Aug 2 2021
I checked one of the images that got this error and it does look like a real image: https://commons.wikimedia.org/wiki/File:For%C3%AAt_@_Mont_Veyrier_(51122922841).jpg. So I'm not sure what to make of this.
@eigyan I found an error message! It looks like the api is returning "The given file could not be verified as an image". I'm still curious if this an appropriate rate of this error.
Jul 28 2021
@eigyan A good idea! I think the only issue is the starting and ending timestamps...
Jul 27 2021
What I see is that all the processing happens in ModerateExistingFilesHelper whereas output is called in ModerateExistingFiles. If we wanted to do an output line per job, we would have to pull the iteration logic back into ModerateExistingFiles.
In terms of the final output of rows processed and timestamp, getSeveralOutput relies on $completed which is the negative of the outcome of processSeveral. However processSeveral returns the number of rows processed. That number is never used. It'd be possible to change the value of $completed but it was no longer mirror how it works in getSingleOutput, which is why I imagine it was written this way.
Petr said it does output the final timestamp at the very end, but I'm not seeing that in the code.
Also, the last job run was on timestamp 20210501132444 according to kafkacat.
We paused running the script today because of the volume of failures. We want to confirm it's still working as it should because there wasn't enough log data. I've opened https://phabricator.wikimedia.org/T287511 for next steps.
Jul 22 2021
The next image to start from is 20210430135017.
Jul 14 2021
@kostajh @Krinkle I put up this patch that fixes it for the page. I'm not sure if we wanted a change in Html::check? In this case, my patch handles the space the same way it's handled in the rest of the class.
Jun 21 2021
Jun 14 2021
Thank you! I checked and I can connect :).
Jun 10 2021
May 4 2021
Apr 8 2021
@mewoph I put up a patch that does not include the if statement because I found that worked for me locally. However, I understand there are nuances to the loading times, so if addPlugin is needed, feel free to update the patch I put up.
Is there a reason we need to use addPlugin if it works to load the modules without it?
Apr 7 2021
Mar 29 2021
I'm looking into this today. So far I've found that none of the code in AddLinkArticleTarget.js runs on page reload.
Mar 25 2021
I see your comments on the task @kostajh. If you look above, the links message names were listed instead of link recommendation, but as you say, that may have been the misunderstanding. I wonder if we want just to update to the addlink documentation instead of the homepage documentation?
Updated both in patch above and on translate wiki.
Based on conversation with @kostajh I'm going to take my name off this.
Mar 22 2021
@Tgr have you already taken this on or should I look to see if the current link fits with the mockups?
Mar 18 2021
@Tgr Good to know! Thank you.
Mar 17 2021
I'd like to take a look at this.
Feb 25 2021
Feb 18 2021
Yes @RHo! That is. It was actually what I was trying to ask about earlier but I'm not sure I was clear :).
Feb 17 2021
@kostajh I have updated the patch with the changes you suggested.
Thanks @kostajh! I can confirm that I see the bug without the patch, and do not see the behavior with the patch applied.
Okay, I just pushed an updated patch. I'd love advice for testing it, but I'm pretty sure this is it.
Hmm, just saw the feedback on the patch. It makes sense now that I look more closely. It looks like the number actually gets set earlier in the code.
I looked at this today. @kostajh and I discussed adding an "icon" property to the taskType object, specified in NewcomerTasks.json. I was trying to figure out where taskTypes in the TaskExplanationWidget gets the TaskTypes.json from. It looks like it's generated in TaskType.php so I'll be working there tomorrow.
Feb 16 2021
Feb 11 2021
@RHo It's currently being translated by mw.messages( 'ellipsis' ). Would you think hardcoding the unicode would be better?
Feb 10 2021
I can take a look at this one since I was just working in the StartEditingDialog and DifficultyFilters.
I have two patches up now that work and address the previous code review.
While I have a working patch, I'm running into three issues:
- I tried switching out '...' for mw.messages('ellipsis') but it's just showing up as blank. If I try to use .parse() or any of the other functions that are actually references to .toString() it just shows up as <<ellipsis>>.
- @RHo Did you want the ellipsis with text or just an ellipsis? Either is doable but I realized I wasn't sure. As of now, I just have the ellipsis.
- The main patch I have up modifies .setCount on ArticleWidget. However, ideally there'd be a new function setSearching. I tried creating this, but the issue is that for the second level filters, I need to update it in SuggestedEdits.js, but that doesn't have the ArticleCounter available to it. Only DifficultyDialog and TopicDialog have those and they are two separate objects in FiltersWidget. In an ideal world, I'd think the ArticleCounter logic would live in FilterWidget but I'm not sure how much re-writing to do right now since I'm new to this code base.
Feb 8 2021
I may keep playing with the code structure but moving this on the workboard to reflect that I do have two patches up.
Feb 4 2021
Today I kept experimenting with svg formatting and found that the display changes based on image format (tried a sprite and png converted) but neither actually uses the frames--they all just display the entire svg.
The StartEditingDialog.updateMatchCount only applies to the initial search for articles. I'll need to apply this to the other dialogs. Kosta recommended using an api event potentially.
Feb 3 2021
Hmm, so I'm noticing two things:
Feb 2 2021
I've got the ellipsis in place during loading now. I'm having issues getting the animation to work with the svg and css above so I'm just trouble shooting that.
Yay! It looks like updateMatchCount is the correct function. Now I'll just need to deal with animated the icon and updating the number.
Feb 1 2021
I have my local environment working for this. I've begun looking at the code.
Basically, I'm looking to be able to animate it at the start of the search (and change the number to ellipsis), then return it to still at the end. ArticleCountWidget.setCount seems to be mark the end of articles search. So far, it looks like the place to switch to the animated icon would be in updateMatchCount, but that function works differently across a couple different modules. StartEditingDialogue.updateMatchCount is so far where I've found the api called and now I'm checking if that covers all cases.
Jan 13 2021
Need to update CurrencyRates: https://gerrit.wikimedia.org/r/c/wikimedia/fundraising/SmashPig/+/574903/2/PaymentData/ReferenceData/CurrencyRates.php#7.
Jan 9 2021
I've +2ed the major patches so they'll be on beta. I also have UI patch and the test patches that need to be +2ed by @AndyRussG.
Jan 6 2021
I think we wanted to hide the categories that can't be turned off, but I don't think that's a blocker for +2ing.
Dec 22 2020
Dec 15 2020
- Does label message validate?
- Check permissions/role for accessing campaign type editing.
From @Seddon ForceOn -> Display to all users.
Label message -> Translation id.
Dec 14 2020
Special and Maintenance will be set to "On for all users" or "Force on".
@DStrine the campaign types are configurable so the CN admins will add those. This was just test data on my local machine.
And here's the user preferences.
Here's the Campaign type manager interface. I updated some of the labels but on second thought the one for "label message" is now too long. I'd love any thoughts from @Seddon!
Dec 9 2020
Dec 8 2020
Dec 3 2020
Hmm there was a patch here but we're still seeing db errors as of today caused by someone putting an emoji into last name.
Dec 2 2020
This looks like what I need documentation wise: https://docs.civicrm.org/civiproxy/en/latest/outside/.
@Ejegg I was considering looking at this tomorrow. Want to post any thoughts you've had about it? I'll have to explore CiviProxy documentation a bit.
Dec 1 2020
From the 20th, the Omnimail forget me job delete in Silverpop failed but the error message was Could not delete OmnimailJobProgress id.
Those are the only recent silverpop failmails I see.
I also just looked at Get recipent data and the most recent failure was "Login failed", with no additional data.
I'm trying to figure out which failmails we're trying to mute. I just looked at the failmail for Get group member data from Silverpop and the last few runs all errored out with a DB Lock. @Eileenmcnaughton do you happen to know what's going on with that?
Nov 18 2020
Since we were able to create the alert and @RLewis sent me Shenya's email, I'm moving this to review. The bug is annoying, but it is still possible to set up alerts. We'll be changing this code next year for the drupal upgrade so for now, it might make sense to pause on fixing it.
@CaitVirtue There is an error at the link you posted about but at https://civicrm.wikimedia.org/admin/config/large_donation/configure, it's possible to add a new threshold level. I set up one up with @RLewis's email but I don't know Shenya's. Fr-tech is looking into the other error on tech talk now.