Thu, Feb 25
Thu, Feb 18
Yes @RHo! That is. It was actually what I was trying to ask about earlier but I'm not sure I was clear :).
Wed, Feb 17
@kostajh I have updated the patch with the changes you suggested.
Thanks @kostajh! I can confirm that I see the bug without the patch, and do not see the behavior with the patch applied.
Okay, I just pushed an updated patch. I'd love advice for testing it, but I'm pretty sure this is it.
Hmm, just saw the feedback on the patch. It makes sense now that I look more closely. It looks like the number actually gets set earlier in the code.
I looked at this today. @kostajh and I discussed adding an "icon" property to the taskType object, specified in NewcomerTasks.json. I was trying to figure out where taskTypes in the TaskExplanationWidget gets the TaskTypes.json from. It looks like it's generated in TaskType.php so I'll be working there tomorrow.
Tue, Feb 16
Thu, Feb 11
@RHo It's currently being translated by mw.messages( 'ellipsis' ). Would you think hardcoding the unicode would be better?
Wed, Feb 10
I can take a look at this one since I was just working in the StartEditingDialog and DifficultyFilters.
I have two patches up now that work and address the previous code review.
While I have a working patch, I'm running into three issues:
- I tried switching out '...' for mw.messages('ellipsis') but it's just showing up as blank. If I try to use .parse() or any of the other functions that are actually references to .toString() it just shows up as <<ellipsis>>.
- @RHo Did you want the ellipsis with text or just an ellipsis? Either (once I resolve the issue above) is doable but I realized I wasn't sure.
- The main patch I have up modifies .setCount on ArticleWidget. However, ideally there'd be a new function setSearching. I tried creating this, but the issue is that for the second level filters, I need to update it in SuggestedEdits.js, but that doesn't have the ArticleCounter available to it. Only DifficultyDialog and TopicDialog have those and they are two separate objects in FiltersWidget. In an ideal world, I'd think the ArticleCounter logic would live in FilterWidget but I'm not sure how much re-writing to do right now since I'm new to this code base.
Mon, Feb 8
I may keep playing with the code structure but moving this on the workboard to reflect that I do have two patches up.
Thu, Feb 4
Today I kept experimenting with svg formatting and found that the display changes based on image format (tried a sprite and png converted) but neither actually uses the frames--they all just display the entire svg.
The StartEditingDialog.updateMatchCount only applies to the initial search for articles. I'll need to apply this to the other dialogs. Kosta recommended using an api event potentially.
Wed, Feb 3
Hmm, so I'm noticing two things:
Feb 2 2021
I've got the ellipsis in place during loading now. I'm having issues getting the animation to work with the svg and css above so I'm just trouble shooting that.
Yay! It looks like updateMatchCount is the correct function. Now I'll just need to deal with animated the icon and updating the number.
Feb 1 2021
I have my local environment working for this. I've begun looking at the code.
Basically, I'm looking to be able to animate it at the start of the search (and change the number to ellipsis), then return it to still at the end. ArticleCountWidget.setCount seems to be mark the end of articles search. So far, it looks like the place to switch to the animated icon would be in updateMatchCount, but that function works differently across a couple different modules. StartEditingDialogue.updateMatchCount is so far where I've found the api called and now I'm checking if that covers all cases.
Jan 13 2021
Need to update CurrencyRates: https://gerrit.wikimedia.org/r/c/wikimedia/fundraising/SmashPig/+/574903/2/PaymentData/ReferenceData/CurrencyRates.php#7.
Jan 9 2021
I've +2ed the major patches so they'll be on beta. I also have UI patch and the test patches that need to be +2ed by @AndyRussG.
Jan 6 2021
I think we wanted to hide the categories that can't be turned off, but I don't think that's a blocker for +2ing.
Dec 22 2020
Dec 15 2020
- Does label message validate?
- Check permissions/role for accessing campaign type editing.
From @Seddon ForceOn -> Display to all users.
Label message -> Translation id.
Dec 14 2020
Special and Maintenance will be set to "On for all users" or "Force on".
@DStrine the campaign types are configurable so the CN admins will add those. This was just test data on my local machine.
And here's the user preferences.
Here's the Campaign type manager interface. I updated some of the labels but on second thought the one for "label message" is now too long. I'd love any thoughts from @Seddon!
Dec 9 2020
Dec 8 2020
Dec 3 2020
Hmm there was a patch here but we're still seeing db errors as of today caused by someone putting an emoji into last name.
Dec 2 2020
This looks like what I need documentation wise: https://docs.civicrm.org/civiproxy/en/latest/outside/.
@Ejegg I was considering looking at this tomorrow. Want to post any thoughts you've had about it? I'll have to explore CiviProxy documentation a bit.
Dec 1 2020
From the 20th, the Omnimail forget me job delete in Silverpop failed but the error message was Could not delete OmnimailJobProgress id.
Those are the only recent silverpop failmails I see.
I also just looked at Get recipent data and the most recent failure was "Login failed", with no additional data.
I'm trying to figure out which failmails we're trying to mute. I just looked at the failmail for Get group member data from Silverpop and the last few runs all errored out with a DB Lock. @Eileenmcnaughton do you happen to know what's going on with that?
Nov 18 2020
Since we were able to create the alert and @RLewis sent me Shenya's email, I'm moving this to review. The bug is annoying, but it is still possible to set up alerts. We'll be changing this code next year for the drupal upgrade so for now, it might make sense to pause on fixing it.
@CaitVirtue There is an error at the link you posted about but at https://civicrm.wikimedia.org/admin/config/large_donation/configure, it's possible to add a new threshold level. I set up one up with @RLewis's email but I don't know Shenya's. Fr-tech is looking into the other error on tech talk now.
Nov 17 2020
After @Dwisehaupt and I chatted, we believe this is due to the server maintenance that was performed yesterday.
Nov 16 2020
I put up a WIP patch trying to add the job, but I'm still learning how mgd files work. Update: It looks like I can't create a scheduled job with API v4. I added a simple bin script but we'll probably just want to install cv.
I'm wondering if I could add a script that calls the api call in the extension and then use that for the job.
So we can't access api4 calls through drush. It looks like we could use the cv tool: https://github.com/civicrm/cv but it doesn't seem to be installed, at least on staging. @Eileenmcnaughton did you have a plan for how to implement the job?
Nov 9 2020
Nov 4 2020
I see that the force class on the continue button is only supposed to be present when show_submethods is true.
There's a lot going on in the code.
On Safari I see just a continue button that doesn't work:
I was able to reproduce this morning too. Not seeing console errors on prod weirdly. I wonder if I can get set up to reproduce locally..
Nov 2 2020
I can confirm I got this running locally with @Ejegg's patch https://gerrit.wikimedia.org/r/c/operations/docker-images/docker-pkg/+/637082.
@spatton Quick question: did you want it to be "No, thanks!" or "No thanks!" as is?
Oct 28 2020
Thanks @katers! Let's keep it open so fr-tech can discuss the retry code for now.
It looks like there was an authentication failure last night. I've re-run the job now and it succeeded. It might be worthwhile to add re-try code into the upload job in case this happens again.
Oct 27 2020
@Eileenmcnaughton I'm glad it works and given priorities I 'm up for +2ing, but I still had some thoughts and questions on the patches. I also think there might be one typo? I'm so glad it's moving away from the modules!
Oct 26 2020
For now, I'm moving this to "Done" on the workboard because it looks like we might open another task for final cleanup. Feel free to move it if I'm wrong.
Oct 22 2020
Thanks for the quick response @KHaggard! I'm trying to figure out where to direct my efforts :).
@Eileenmcnaughton I'm trying to read from this if the primary issue is resolved now?
Oct 21 2020
I just confirmed the adyen recurring links now work for AU and NZ.
Oct 19 2020
@Eileenmcnaughton I don't find an associated patch or see a comment explaining this in review?
Oct 15 2020
A note that 2416641 got merged to 14901186 which doesn't explain the missing deletion. 20904192 also does have a civi contact, but again, this doesn't explain them existing in silverpop.
I'm wondering if there's any circumstance where silverpop could have duplicate emails, though I think we dedupe by email. Did we always do that? So far the commonality among these records is that they were duplicates.
I actually don't know that I have Zendesk access @MBeat33. That might help as I track this down. Because these contacts don't have Civi contacts I'm struggling to find more data on what happened. Could they be RML contacts? I realize RML contacts should have civi contacts and these addresses have contact ids in Acoustic so that's less likely.
Oct 14 2020
Ah thanks @KHaggard!
@KHaggard I don't know which email to search for because forgotten contacts have their emails deleted. How did you find the email address?
@KHaggard how do you search for these contacts on the suppression list? I was trying to look into this but without the email from civi, I'm not sure how to find them.
Removing my name so someone else reviews the patch above.