Page MenuHomePhabricator

mepps (Maggie Epps)
User

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Sunday

  • Clear sailing ahead.

User Details

User Since
Apr 28 2017, 8:33 PM (200 w, 6 d)
Availability
Available
LDAP User
Unknown
MediaWiki User
MEpps (WMF) [ Global Accounts ]

Recent Activity

Thu, Feb 25

mepps moved T268707: Add a link: task type info in suggested edits module from In Progress to Code Review on the Growth-Team (Current Sprint) board.
Thu, Feb 25, 6:00 PM · Patch-For-Review, MW-1.36-notes (1.36.0-wmf.26; 2021-01-12), Growth-Team (Current Sprint), GrowthExperiments, Add-Link, Growth-Structured-Tasks

Thu, Feb 18

mepps moved T236842: Newcomer tasks: Animate the "live broadcast" icon in the Suggested edits results overlay from In Progress to Code Review on the Growth-Team (Current Sprint) board.
Thu, Feb 18, 7:58 PM · MW-1.36-notes (1.36.0-wmf.33; 2021-03-02), Patch-For-Review, Growth-Team (Current Sprint), NewcomerTasks 1.0 , GrowthExperiments-Homepage
mepps added a comment to T236842: Newcomer tasks: Animate the "live broadcast" icon in the Suggested edits results overlay .

Yes @RHo! That is. It was actually what I was trying to ask about earlier but I'm not sure I was clear :).

Thu, Feb 18, 6:54 PM · MW-1.36-notes (1.36.0-wmf.33; 2021-03-02), Patch-For-Review, Growth-Team (Current Sprint), NewcomerTasks 1.0 , GrowthExperiments-Homepage

Wed, Feb 17

mepps added a comment to T274468: [minor] fawiki - SE counter displays Arabic numerals before switching to Farsi numerals.

@kostajh I have updated the patch with the changes you suggested.

Wed, Feb 17, 9:21 PM · MW-1.36-notes (1.36.0-wmf.32; 2021-02-23), Growth-Team (Current Sprint), GrowthExperiments
mepps added a comment to T274468: [minor] fawiki - SE counter displays Arabic numerals before switching to Farsi numerals.

Thanks @kostajh! I can confirm that I see the bug without the patch, and do not see the behavior with the patch applied.

Wed, Feb 17, 1:50 PM · MW-1.36-notes (1.36.0-wmf.32; 2021-02-23), Growth-Team (Current Sprint), GrowthExperiments
mepps moved T274468: [minor] fawiki - SE counter displays Arabic numerals before switching to Farsi numerals from In Progress to Code Review on the Growth-Team (Current Sprint) board.

Okay, I just pushed an updated patch. I'd love advice for testing it, but I'm pretty sure this is it.

Wed, Feb 17, 2:39 AM · MW-1.36-notes (1.36.0-wmf.32; 2021-02-23), Growth-Team (Current Sprint), GrowthExperiments
mepps added a comment to T274468: [minor] fawiki - SE counter displays Arabic numerals before switching to Farsi numerals.

Hmm, just saw the feedback on the patch. It makes sense now that I look more closely. It looks like the number actually gets set earlier in the code.

Wed, Feb 17, 1:01 AM · MW-1.36-notes (1.36.0-wmf.32; 2021-02-23), Growth-Team (Current Sprint), GrowthExperiments
mepps added a comment to T268707: Add a link: task type info in suggested edits module.

I looked at this today. @kostajh and I discussed adding an "icon" property to the taskType object, specified in NewcomerTasks.json. I was trying to figure out where taskTypes in the TaskExplanationWidget gets the TaskTypes.json from. It looks like it's generated in TaskType.php so I'll be working there tomorrow.

Wed, Feb 17, 12:13 AM · Patch-For-Review, MW-1.36-notes (1.36.0-wmf.26; 2021-01-12), Growth-Team (Current Sprint), GrowthExperiments, Add-Link, Growth-Structured-Tasks

Tue, Feb 16

mepps moved T268707: Add a link: task type info in suggested edits module from Ready for Development to In Progress on the Growth-Team (Current Sprint) board.

@RHo @MMiller_WMF Are we planning to use this robot icon with add an image too? It just might change my approach.

Tue, Feb 16, 5:40 PM · Patch-For-Review, MW-1.36-notes (1.36.0-wmf.26; 2021-01-12), Growth-Team (Current Sprint), GrowthExperiments, Add-Link, Growth-Structured-Tasks

Thu, Feb 11

mepps added a comment to T236842: Newcomer tasks: Animate the "live broadcast" icon in the Suggested edits results overlay .

@RHo It's currently being translated by mw.messages( 'ellipsis' ). Would you think hardcoding the unicode would be better?

Thu, Feb 11, 6:02 PM · MW-1.36-notes (1.36.0-wmf.33; 2021-03-02), Patch-For-Review, Growth-Team (Current Sprint), NewcomerTasks 1.0 , GrowthExperiments-Homepage
mepps claimed T268707: Add a link: task type info in suggested edits module.
Thu, Feb 11, 2:47 PM · Patch-For-Review, MW-1.36-notes (1.36.0-wmf.26; 2021-01-12), Growth-Team (Current Sprint), GrowthExperiments, Add-Link, Growth-Structured-Tasks
mepps added a comment to T268707: Add a link: task type info in suggested edits module.

@kostajh suggested working on this before T268707.

Thu, Feb 11, 2:47 PM · Patch-For-Review, MW-1.36-notes (1.36.0-wmf.26; 2021-01-12), Growth-Team (Current Sprint), GrowthExperiments, Add-Link, Growth-Structured-Tasks

Wed, Feb 10

mepps claimed T268706: Add a link: difficulty overlay and difficulty filter.

I can take a look at this one since I was just working in the StartEditingDialog and DifficultyFilters.

Wed, Feb 10, 9:35 PM · Patch-For-Review, Growth-Team (Current Sprint), GrowthExperiments, Add-Link, Growth-Structured-Tasks
mepps added a comment to T236842: Newcomer tasks: Animate the "live broadcast" icon in the Suggested edits results overlay .

I have two patches up now that work and address the previous code review.

Wed, Feb 10, 9:26 PM · MW-1.36-notes (1.36.0-wmf.33; 2021-03-02), Patch-For-Review, Growth-Team (Current Sprint), NewcomerTasks 1.0 , GrowthExperiments-Homepage
mepps added a comment to T236842: Newcomer tasks: Animate the "live broadcast" icon in the Suggested edits results overlay .

While I have a working patch, I'm running into three issues:

  • I tried switching out '...' for mw.messages('ellipsis') but it's just showing up as blank. If I try to use .parse() or any of the other functions that are actually references to .toString() it just shows up as <<ellipsis>>.
  • @RHo Did you want the ellipsis with text or just an ellipsis? Either (once I resolve the issue above) is doable but I realized I wasn't sure.
  • The main patch I have up modifies .setCount on ArticleWidget. However, ideally there'd be a new function setSearching. I tried creating this, but the issue is that for the second level filters, I need to update it in SuggestedEdits.js, but that doesn't have the ArticleCounter available to it. Only DifficultyDialog and TopicDialog have those and they are two separate objects in FiltersWidget. In an ideal world, I'd think the ArticleCounter logic would live in FilterWidget but I'm not sure how much re-writing to do right now since I'm new to this code base.
Wed, Feb 10, 5:22 PM · MW-1.36-notes (1.36.0-wmf.33; 2021-03-02), Patch-For-Review, Growth-Team (Current Sprint), NewcomerTasks 1.0 , GrowthExperiments-Homepage

Mon, Feb 8

mepps moved T236842: Newcomer tasks: Animate the "live broadcast" icon in the Suggested edits results overlay from In Progress to Code Review on the Growth-Team (Current Sprint) board.

I may keep playing with the code structure but moving this on the workboard to reflect that I do have two patches up.

Mon, Feb 8, 8:47 PM · MW-1.36-notes (1.36.0-wmf.33; 2021-03-02), Patch-For-Review, Growth-Team (Current Sprint), NewcomerTasks 1.0 , GrowthExperiments-Homepage

Thu, Feb 4

mepps added a comment to T236842: Newcomer tasks: Animate the "live broadcast" icon in the Suggested edits results overlay .

Today I kept experimenting with svg formatting and found that the display changes based on image format (tried a sprite and png converted) but neither actually uses the frames--they all just display the entire svg.

Thu, Feb 4, 8:56 PM · MW-1.36-notes (1.36.0-wmf.33; 2021-03-02), Patch-For-Review, Growth-Team (Current Sprint), NewcomerTasks 1.0 , GrowthExperiments-Homepage
mepps added a comment to T236842: Newcomer tasks: Animate the "live broadcast" icon in the Suggested edits results overlay .

The StartEditingDialog.updateMatchCount only applies to the initial search for articles. I'll need to apply this to the other dialogs. Kosta recommended using an api event potentially.

Thu, Feb 4, 2:41 PM · MW-1.36-notes (1.36.0-wmf.33; 2021-03-02), Patch-For-Review, Growth-Team (Current Sprint), NewcomerTasks 1.0 , GrowthExperiments-Homepage

Wed, Feb 3

mepps added a comment to T236842: Newcomer tasks: Animate the "live broadcast" icon in the Suggested edits results overlay .

Hmm, so I'm noticing two things:

Wed, Feb 3, 1:26 PM · MW-1.36-notes (1.36.0-wmf.33; 2021-03-02), Patch-For-Review, Growth-Team (Current Sprint), NewcomerTasks 1.0 , GrowthExperiments-Homepage

Feb 2 2021

mepps added a comment to T236842: Newcomer tasks: Animate the "live broadcast" icon in the Suggested edits results overlay .

I've got the ellipsis in place during loading now. I'm having issues getting the animation to work with the svg and css above so I'm just trouble shooting that.

Feb 2 2021, 11:00 PM · MW-1.36-notes (1.36.0-wmf.33; 2021-03-02), Patch-For-Review, Growth-Team (Current Sprint), NewcomerTasks 1.0 , GrowthExperiments-Homepage
mepps added a comment to T236842: Newcomer tasks: Animate the "live broadcast" icon in the Suggested edits results overlay .

Yay! It looks like updateMatchCount is the correct function. Now I'll just need to deal with animated the icon and updating the number.

Feb 2 2021, 7:32 PM · MW-1.36-notes (1.36.0-wmf.33; 2021-03-02), Patch-For-Review, Growth-Team (Current Sprint), NewcomerTasks 1.0 , GrowthExperiments-Homepage

Feb 1 2021

mepps added a comment to T236842: Newcomer tasks: Animate the "live broadcast" icon in the Suggested edits results overlay .

I have my local environment working for this. I've begun looking at the code.
Basically, I'm looking to be able to animate it at the start of the search (and change the number to ellipsis), then return it to still at the end. ArticleCountWidget.setCount seems to be mark the end of articles search. So far, it looks like the place to switch to the animated icon would be in updateMatchCount, but that function works differently across a couple different modules. StartEditingDialogue.updateMatchCount is so far where I've found the api called and now I'm checking if that covers all cases.

Feb 1 2021, 10:23 PM · MW-1.36-notes (1.36.0-wmf.33; 2021-03-02), Patch-For-Review, Growth-Team (Current Sprint), NewcomerTasks 1.0 , GrowthExperiments-Homepage
mepps moved T236842: Newcomer tasks: Animate the "live broadcast" icon in the Suggested edits results overlay from Code Review to In Progress on the Growth-Team (Current Sprint) board.
Feb 1 2021, 10:18 PM · MW-1.36-notes (1.36.0-wmf.33; 2021-03-02), Patch-For-Review, Growth-Team (Current Sprint), NewcomerTasks 1.0 , GrowthExperiments-Homepage
mepps moved T236842: Newcomer tasks: Animate the "live broadcast" icon in the Suggested edits results overlay from Ready for Development to Code Review on the Growth-Team (Current Sprint) board.
Feb 1 2021, 10:18 PM · MW-1.36-notes (1.36.0-wmf.33; 2021-03-02), Patch-For-Review, Growth-Team (Current Sprint), NewcomerTasks 1.0 , GrowthExperiments-Homepage

Jan 13 2021

mepps added a comment to T258527: Fr-tech chores list.

Need to update CurrencyRates: https://gerrit.wikimedia.org/r/c/wikimedia/fundraising/SmashPig/+/574903/2/PaymentData/ReferenceData/CurrencyRates.php#7.

Jan 13 2021, 7:33 PM · Fundraising Sprint Esperantoland, Fundraising Sprint Downed power line jump rope, Fundraising Sprint Corrugated super slide, Fundraising Sprint Bee Wheel, Fundraising Sprint Airline Passenger Experience, Fundraising Sprint Zeitgeistbusters, Fundraising Sprint Yellow hornets of kindness and healing, Fundraising Sprint We all meet again, Fundraising Sprint Vagranty McVagrantface, Fundraising Sprint Upbeat Upholstery, fundraising sprint Theme songs for programming languages, Fundraising Sprint 🐍 is not a valid zipcode, Fundraising Sprint Raw data never hurt anyone, fundraising Sprint Quackery limited to ducks, Fundraising Sprint Pseudopretzels, Fundraising Sprint Octopus hugs, Fundraising-Backlog

Jan 9 2021

mepps added a comment to T268646: Code review, fix major and minor issues, follow up on new requirements, write tests and release management for CN campaign filtering.

I've +2ed the major patches so they'll be on beta. I also have UI patch and the test patches that need to be +2ed by @AndyRussG.

Jan 9 2021, 1:59 AM · Fundraising Sprint Esperantoland, Fundraising Sprint Downed power line jump rope, Fundraising Sprint Corrugated super slide, Schema-change, Fundraising Sprint Bee Wheel, Fundraising Sprint Airline Passenger Experience, Fundraising Sprint Zeitgeistbusters, Patch-For-Review, Fundraising Sprint Yellow hornets of kindness and healing, Fundraising Sprint Xtreme Lolcats, MediaWiki-extensions-CentralNotice, Fundraising-Backlog
mepps moved T268646: Code review, fix major and minor issues, follow up on new requirements, write tests and release management for CN campaign filtering from Backlog to Review on the Fundraising Sprint Airline Passenger Experience board.
Jan 9 2021, 1:58 AM · Fundraising Sprint Esperantoland, Fundraising Sprint Downed power line jump rope, Fundraising Sprint Corrugated super slide, Schema-change, Fundraising Sprint Bee Wheel, Fundraising Sprint Airline Passenger Experience, Fundraising Sprint Zeitgeistbusters, Patch-For-Review, Fundraising Sprint Yellow hornets of kindness and healing, Fundraising Sprint Xtreme Lolcats, MediaWiki-extensions-CentralNotice, Fundraising-Backlog

Jan 6 2021

mepps added a comment to T268646: Code review, fix major and minor issues, follow up on new requirements, write tests and release management for CN campaign filtering.


I think we wanted to hide the categories that can't be turned off, but I don't think that's a blocker for +2ing.

Jan 6 2021, 9:49 PM · Fundraising Sprint Esperantoland, Fundraising Sprint Downed power line jump rope, Fundraising Sprint Corrugated super slide, Schema-change, Fundraising Sprint Bee Wheel, Fundraising Sprint Airline Passenger Experience, Fundraising Sprint Zeitgeistbusters, Patch-For-Review, Fundraising Sprint Yellow hornets of kindness and healing, Fundraising Sprint Xtreme Lolcats, MediaWiki-extensions-CentralNotice, Fundraising-Backlog

Dec 22 2020

mepps moved T269811: As an email stats updater, I need to find results for a send that is missing from Superset from Backlog to Pending Deployment on the Fundraising Sprint Yellow hornets of kindness and healing board.
Dec 22 2020, 3:55 PM · Fundraising Sprint Airline Passenger Experience, Fundraising Sprint Zeitgeistbusters, Fundraising Sprint Yellow hornets of kindness and healing, Patch-For-Review, FR-Tech-Analytics, FR-Email, Fundraising-Backlog

Dec 15 2020

mepps added a comment to T268646: Code review, fix major and minor issues, follow up on new requirements, write tests and release management for CN campaign filtering.
  • Does label message validate?
  • Check permissions/role for accessing campaign type editing.
Dec 15 2020, 5:26 PM · Fundraising Sprint Esperantoland, Fundraising Sprint Downed power line jump rope, Fundraising Sprint Corrugated super slide, Schema-change, Fundraising Sprint Bee Wheel, Fundraising Sprint Airline Passenger Experience, Fundraising Sprint Zeitgeistbusters, Patch-For-Review, Fundraising Sprint Yellow hornets of kindness and healing, Fundraising Sprint Xtreme Lolcats, MediaWiki-extensions-CentralNotice, Fundraising-Backlog
mepps added a comment to T268646: Code review, fix major and minor issues, follow up on new requirements, write tests and release management for CN campaign filtering.

From @Seddon ForceOn -> Display to all users.
Label message -> Translation id.

Dec 15 2020, 5:24 PM · Fundraising Sprint Esperantoland, Fundraising Sprint Downed power line jump rope, Fundraising Sprint Corrugated super slide, Schema-change, Fundraising Sprint Bee Wheel, Fundraising Sprint Airline Passenger Experience, Fundraising Sprint Zeitgeistbusters, Patch-For-Review, Fundraising Sprint Yellow hornets of kindness and healing, Fundraising Sprint Xtreme Lolcats, MediaWiki-extensions-CentralNotice, Fundraising-Backlog

Dec 14 2020

mepps updated the task description for T268646: Code review, fix major and minor issues, follow up on new requirements, write tests and release management for CN campaign filtering.
Dec 14 2020, 9:48 PM · Fundraising Sprint Esperantoland, Fundraising Sprint Downed power line jump rope, Fundraising Sprint Corrugated super slide, Schema-change, Fundraising Sprint Bee Wheel, Fundraising Sprint Airline Passenger Experience, Fundraising Sprint Zeitgeistbusters, Patch-For-Review, Fundraising Sprint Yellow hornets of kindness and healing, Fundraising Sprint Xtreme Lolcats, MediaWiki-extensions-CentralNotice, Fundraising-Backlog
mepps added a comment to T268646: Code review, fix major and minor issues, follow up on new requirements, write tests and release management for CN campaign filtering.

Special and Maintenance will be set to "On for all users" or "Force on".

Dec 14 2020, 7:18 PM · Fundraising Sprint Esperantoland, Fundraising Sprint Downed power line jump rope, Fundraising Sprint Corrugated super slide, Schema-change, Fundraising Sprint Bee Wheel, Fundraising Sprint Airline Passenger Experience, Fundraising Sprint Zeitgeistbusters, Patch-For-Review, Fundraising Sprint Yellow hornets of kindness and healing, Fundraising Sprint Xtreme Lolcats, MediaWiki-extensions-CentralNotice, Fundraising-Backlog
mepps added a comment to T268646: Code review, fix major and minor issues, follow up on new requirements, write tests and release management for CN campaign filtering.

@DStrine the campaign types are configurable so the CN admins will add those. This was just test data on my local machine.

Dec 14 2020, 7:16 PM · Fundraising Sprint Esperantoland, Fundraising Sprint Downed power line jump rope, Fundraising Sprint Corrugated super slide, Schema-change, Fundraising Sprint Bee Wheel, Fundraising Sprint Airline Passenger Experience, Fundraising Sprint Zeitgeistbusters, Patch-For-Review, Fundraising Sprint Yellow hornets of kindness and healing, Fundraising Sprint Xtreme Lolcats, MediaWiki-extensions-CentralNotice, Fundraising-Backlog
mepps added a comment to T268646: Code review, fix major and minor issues, follow up on new requirements, write tests and release management for CN campaign filtering.

And here's the user preferences.

Dec 14 2020, 6:05 PM · Fundraising Sprint Esperantoland, Fundraising Sprint Downed power line jump rope, Fundraising Sprint Corrugated super slide, Schema-change, Fundraising Sprint Bee Wheel, Fundraising Sprint Airline Passenger Experience, Fundraising Sprint Zeitgeistbusters, Patch-For-Review, Fundraising Sprint Yellow hornets of kindness and healing, Fundraising Sprint Xtreme Lolcats, MediaWiki-extensions-CentralNotice, Fundraising-Backlog
mepps added a comment to T268646: Code review, fix major and minor issues, follow up on new requirements, write tests and release management for CN campaign filtering.


Here's the Campaign type manager interface. I updated some of the labels but on second thought the one for "label message" is now too long. I'd love any thoughts from @Seddon!

Dec 14 2020, 6:02 PM · Fundraising Sprint Esperantoland, Fundraising Sprint Downed power line jump rope, Fundraising Sprint Corrugated super slide, Schema-change, Fundraising Sprint Bee Wheel, Fundraising Sprint Airline Passenger Experience, Fundraising Sprint Zeitgeistbusters, Patch-For-Review, Fundraising Sprint Yellow hornets of kindness and healing, Fundraising Sprint Xtreme Lolcats, MediaWiki-extensions-CentralNotice, Fundraising-Backlog
mepps renamed T268646: Code review, fix major and minor issues, follow up on new requirements, write tests and release management for CN campaign filtering from Code review and release management for CN to Code review and release management for CN campaign filtering.
Dec 14 2020, 4:20 PM · Fundraising Sprint Esperantoland, Fundraising Sprint Downed power line jump rope, Fundraising Sprint Corrugated super slide, Schema-change, Fundraising Sprint Bee Wheel, Fundraising Sprint Airline Passenger Experience, Fundraising Sprint Zeitgeistbusters, Patch-For-Review, Fundraising Sprint Yellow hornets of kindness and healing, Fundraising Sprint Xtreme Lolcats, MediaWiki-extensions-CentralNotice, Fundraising-Backlog

Dec 9 2020

mepps updated the task description for T268646: Code review, fix major and minor issues, follow up on new requirements, write tests and release management for CN campaign filtering.
Dec 9 2020, 8:22 PM · Fundraising Sprint Esperantoland, Fundraising Sprint Downed power line jump rope, Fundraising Sprint Corrugated super slide, Schema-change, Fundraising Sprint Bee Wheel, Fundraising Sprint Airline Passenger Experience, Fundraising Sprint Zeitgeistbusters, Patch-For-Review, Fundraising Sprint Yellow hornets of kindness and healing, Fundraising Sprint Xtreme Lolcats, MediaWiki-extensions-CentralNotice, Fundraising-Backlog
mepps updated the task description for T268646: Code review, fix major and minor issues, follow up on new requirements, write tests and release management for CN campaign filtering.
Dec 9 2020, 7:45 PM · Fundraising Sprint Esperantoland, Fundraising Sprint Downed power line jump rope, Fundraising Sprint Corrugated super slide, Schema-change, Fundraising Sprint Bee Wheel, Fundraising Sprint Airline Passenger Experience, Fundraising Sprint Zeitgeistbusters, Patch-For-Review, Fundraising Sprint Yellow hornets of kindness and healing, Fundraising Sprint Xtreme Lolcats, MediaWiki-extensions-CentralNotice, Fundraising-Backlog
mepps updated the task description for T268646: Code review, fix major and minor issues, follow up on new requirements, write tests and release management for CN campaign filtering.
Dec 9 2020, 6:28 PM · Fundraising Sprint Esperantoland, Fundraising Sprint Downed power line jump rope, Fundraising Sprint Corrugated super slide, Schema-change, Fundraising Sprint Bee Wheel, Fundraising Sprint Airline Passenger Experience, Fundraising Sprint Zeitgeistbusters, Patch-For-Review, Fundraising Sprint Yellow hornets of kindness and healing, Fundraising Sprint Xtreme Lolcats, MediaWiki-extensions-CentralNotice, Fundraising-Backlog
mepps updated the task description for T268646: Code review, fix major and minor issues, follow up on new requirements, write tests and release management for CN campaign filtering.
Dec 9 2020, 6:27 PM · Fundraising Sprint Esperantoland, Fundraising Sprint Downed power line jump rope, Fundraising Sprint Corrugated super slide, Schema-change, Fundraising Sprint Bee Wheel, Fundraising Sprint Airline Passenger Experience, Fundraising Sprint Zeitgeistbusters, Patch-For-Review, Fundraising Sprint Yellow hornets of kindness and healing, Fundraising Sprint Xtreme Lolcats, MediaWiki-extensions-CentralNotice, Fundraising-Backlog
mepps updated the task description for T268646: Code review, fix major and minor issues, follow up on new requirements, write tests and release management for CN campaign filtering.
Dec 9 2020, 4:42 PM · Fundraising Sprint Esperantoland, Fundraising Sprint Downed power line jump rope, Fundraising Sprint Corrugated super slide, Schema-change, Fundraising Sprint Bee Wheel, Fundraising Sprint Airline Passenger Experience, Fundraising Sprint Zeitgeistbusters, Patch-For-Review, Fundraising Sprint Yellow hornets of kindness and healing, Fundraising Sprint Xtreme Lolcats, MediaWiki-extensions-CentralNotice, Fundraising-Backlog
mepps updated the task description for T268646: Code review, fix major and minor issues, follow up on new requirements, write tests and release management for CN campaign filtering.
Dec 9 2020, 3:23 PM · Fundraising Sprint Esperantoland, Fundraising Sprint Downed power line jump rope, Fundraising Sprint Corrugated super slide, Schema-change, Fundraising Sprint Bee Wheel, Fundraising Sprint Airline Passenger Experience, Fundraising Sprint Zeitgeistbusters, Patch-For-Review, Fundraising Sprint Yellow hornets of kindness and healing, Fundraising Sprint Xtreme Lolcats, MediaWiki-extensions-CentralNotice, Fundraising-Backlog
mepps updated the task description for T268646: Code review, fix major and minor issues, follow up on new requirements, write tests and release management for CN campaign filtering.
Dec 9 2020, 12:57 AM · Fundraising Sprint Esperantoland, Fundraising Sprint Downed power line jump rope, Fundraising Sprint Corrugated super slide, Schema-change, Fundraising Sprint Bee Wheel, Fundraising Sprint Airline Passenger Experience, Fundraising Sprint Zeitgeistbusters, Patch-For-Review, Fundraising Sprint Yellow hornets of kindness and healing, Fundraising Sprint Xtreme Lolcats, MediaWiki-extensions-CentralNotice, Fundraising-Backlog

Dec 8 2020

mepps updated the task description for T268646: Code review, fix major and minor issues, follow up on new requirements, write tests and release management for CN campaign filtering.
Dec 8 2020, 9:57 PM · Fundraising Sprint Esperantoland, Fundraising Sprint Downed power line jump rope, Fundraising Sprint Corrugated super slide, Schema-change, Fundraising Sprint Bee Wheel, Fundraising Sprint Airline Passenger Experience, Fundraising Sprint Zeitgeistbusters, Patch-For-Review, Fundraising Sprint Yellow hornets of kindness and healing, Fundraising Sprint Xtreme Lolcats, MediaWiki-extensions-CentralNotice, Fundraising-Backlog
mepps updated the task description for T268646: Code review, fix major and minor issues, follow up on new requirements, write tests and release management for CN campaign filtering.
Dec 8 2020, 9:05 PM · Fundraising Sprint Esperantoland, Fundraising Sprint Downed power line jump rope, Fundraising Sprint Corrugated super slide, Schema-change, Fundraising Sprint Bee Wheel, Fundraising Sprint Airline Passenger Experience, Fundraising Sprint Zeitgeistbusters, Patch-For-Review, Fundraising Sprint Yellow hornets of kindness and healing, Fundraising Sprint Xtreme Lolcats, MediaWiki-extensions-CentralNotice, Fundraising-Backlog
mepps updated the task description for T268646: Code review, fix major and minor issues, follow up on new requirements, write tests and release management for CN campaign filtering.
Dec 8 2020, 6:53 PM · Fundraising Sprint Esperantoland, Fundraising Sprint Downed power line jump rope, Fundraising Sprint Corrugated super slide, Schema-change, Fundraising Sprint Bee Wheel, Fundraising Sprint Airline Passenger Experience, Fundraising Sprint Zeitgeistbusters, Patch-For-Review, Fundraising Sprint Yellow hornets of kindness and healing, Fundraising Sprint Xtreme Lolcats, MediaWiki-extensions-CentralNotice, Fundraising-Backlog
mepps updated the task description for T268646: Code review, fix major and minor issues, follow up on new requirements, write tests and release management for CN campaign filtering.
Dec 8 2020, 6:52 PM · Fundraising Sprint Esperantoland, Fundraising Sprint Downed power line jump rope, Fundraising Sprint Corrugated super slide, Schema-change, Fundraising Sprint Bee Wheel, Fundraising Sprint Airline Passenger Experience, Fundraising Sprint Zeitgeistbusters, Patch-For-Review, Fundraising Sprint Yellow hornets of kindness and healing, Fundraising Sprint Xtreme Lolcats, MediaWiki-extensions-CentralNotice, Fundraising-Backlog

Dec 3 2020

mepps added a comment to T241757: Emojis in firstname/lastname causing names to be too long for Ingenico.

Hmm there was a patch here but we're still seeing db errors as of today caused by someone putting an emoji into last name.

Dec 3 2020, 3:02 PM · Fundraising-Backlog

Dec 2 2020

mepps added a comment to T268497: Use Guzzle to make API request to CiviProxy to retrieve opt-in / opt-out fields..

This looks like what I need documentation wise: https://docs.civicrm.org/civiproxy/en/latest/outside/.

Dec 2 2020, 9:32 PM · Fundraising Sprint Esperantoland, Fundraising Sprint Downed power line jump rope, Fundraising Sprint Bee Wheel, fr-email-preference-center, MediaWiki-extensions-DonationInterface, Fundraising-Backlog
mepps added a comment to T268497: Use Guzzle to make API request to CiviProxy to retrieve opt-in / opt-out fields..

@Ejegg I was considering looking at this tomorrow. Want to post any thoughts you've had about it? I'll have to explore CiviProxy documentation a bit.

Dec 2 2020, 9:20 PM · Fundraising Sprint Esperantoland, Fundraising Sprint Downed power line jump rope, Fundraising Sprint Bee Wheel, fr-email-preference-center, MediaWiki-extensions-DonationInterface, Fundraising-Backlog

Dec 1 2020

mepps added a comment to T226747: Resolve failmail from session time outs.

From the 20th, the Omnimail forget me job delete in Silverpop failed but the error message was Could not delete OmnimailJobProgress id.

Dec 1 2020, 6:47 PM · Fundraising Sprint Zeitgeistbusters, Fundraising Sprint Yellow hornets of kindness and healing, Patch-For-Review, Fundraising Sprint Xtreme Lolcats, FR-Q2-FY2019-20-cleanup-list, Fundraising-Backlog
mepps added a comment to T226747: Resolve failmail from session time outs.

Those are the only recent silverpop failmails I see.

Dec 1 2020, 6:42 PM · Fundraising Sprint Zeitgeistbusters, Fundraising Sprint Yellow hornets of kindness and healing, Patch-For-Review, Fundraising Sprint Xtreme Lolcats, FR-Q2-FY2019-20-cleanup-list, Fundraising-Backlog
mepps added a comment to T226747: Resolve failmail from session time outs.

I also just looked at Get recipent data and the most recent failure was "Login failed", with no additional data.

Dec 1 2020, 6:42 PM · Fundraising Sprint Zeitgeistbusters, Fundraising Sprint Yellow hornets of kindness and healing, Patch-For-Review, Fundraising Sprint Xtreme Lolcats, FR-Q2-FY2019-20-cleanup-list, Fundraising-Backlog
mepps updated subscribers of T226747: Resolve failmail from session time outs.

I'm trying to figure out which failmails we're trying to mute. I just looked at the failmail for Get group member data from Silverpop and the last few runs all errored out with a DB Lock. @Eileenmcnaughton do you happen to know what's going on with that?

Dec 1 2020, 6:41 PM · Fundraising Sprint Zeitgeistbusters, Fundraising Sprint Yellow hornets of kindness and healing, Patch-For-Review, Fundraising Sprint Xtreme Lolcats, FR-Q2-FY2019-20-cleanup-list, Fundraising-Backlog

Nov 18 2020

mepps moved T268066: Request to create new $10k+ email bot from Backlog to Review on the Fundraising Sprint We all meet again board.

Since we were able to create the alert and @RLewis sent me Shenya's email, I'm moving this to review. The bug is annoying, but it is still possible to set up alerts. We'll be changing this code next year for the drupal upgrade so for now, it might make sense to pause on fixing it.

Nov 18 2020, 8:28 PM · Fundraising Sprint We all meet again, Wikimedia-Fundraising-CiviCRM, Fundraising-Backlog
mepps added a comment to T268066: Request to create new $10k+ email bot.

@CaitVirtue There is an error at the link you posted about but at https://civicrm.wikimedia.org/admin/config/large_donation/configure, it's possible to add a new threshold level. I set up one up with @RLewis's email but I don't know Shenya's. Fr-tech is looking into the other error on tech talk now.

Nov 18 2020, 6:57 PM · Fundraising Sprint We all meet again, Wikimedia-Fundraising-CiviCRM, Fundraising-Backlog

Nov 17 2020

mepps updated subscribers of T268039: Adyen issue re notifications.

After @Dwisehaupt and I chatted, we believe this is due to the server maintenance that was performed yesterday.

Nov 17 2020, 4:55 PM · Fundraising-Backlog

Nov 16 2020

mepps moved T222287: Civi: make sure Forget Me requests reach IBM from Backlog to Review on the Fundraising Sprint We all meet again board.

I put up a WIP patch trying to add the job, but I'm still learning how mgd files work. Update: It looks like I can't create a scheduled job with API v4. I added a simple bin script but we'll probably just want to install cv.

Nov 16 2020, 6:34 PM · Patch-For-Review, Fundraising Sprint We all meet again, Fundraising Sprint Vagranty McVagrantface, Fundraising Sprint Upbeat Upholstery, fr-donorservices, Wikimedia-Fundraising-CiviCRM, Fundraising-Backlog
mepps added a comment to T222287: Civi: make sure Forget Me requests reach IBM.

I'm wondering if I could add a script that calls the api call in the extension and then use that for the job.

Nov 16 2020, 4:29 PM · Patch-For-Review, Fundraising Sprint We all meet again, Fundraising Sprint Vagranty McVagrantface, Fundraising Sprint Upbeat Upholstery, fr-donorservices, Wikimedia-Fundraising-CiviCRM, Fundraising-Backlog
mepps added a comment to T222287: Civi: make sure Forget Me requests reach IBM.

So we can't access api4 calls through drush. It looks like we could use the cv tool: https://github.com/civicrm/cv but it doesn't seem to be installed, at least on staging. @Eileenmcnaughton did you have a plan for how to implement the job?

Nov 16 2020, 4:27 PM · Patch-For-Review, Fundraising Sprint We all meet again, Fundraising Sprint Vagranty McVagrantface, Fundraising Sprint Upbeat Upholstery, fr-donorservices, Wikimedia-Fundraising-CiviCRM, Fundraising-Backlog

Nov 9 2020

mepps moved T266562: Monthly convert pwk modal variant 011 (alt button text) from Pending Deployment to Done on the Fundraising Sprint Vagranty McVagrantface board.
Nov 9 2020, 6:33 PM · Fundraising Sprint Vagranty McVagrantface, Fundraising-Backlog
mepps moved T266564: Monthly convert pwk modal variant 013 (alt button text and button order) from Pending Deployment to Done on the Fundraising Sprint Vagranty McVagrantface board.
Nov 9 2020, 6:33 PM · Fundraising Sprint Vagranty McVagrantface, Fundraising-Backlog
mepps moved T266563: Monthly convert pwk modal variant 012 (alt button text and button order) from Pending Deployment to Done on the Fundraising Sprint Vagranty McVagrantface board.
Nov 9 2020, 6:33 PM · Fundraising Sprint Vagranty McVagrantface, Fundraising-Backlog
mepps moved T266590: Monthly convert pwk modal variant 014 (alt button text and button order) from Pending Deployment to Done on the Fundraising Sprint Vagranty McVagrantface board.
Nov 9 2020, 6:33 PM · Fundraising Sprint Vagranty McVagrantface, Fundraising-Backlog

Nov 4 2020

mepps added a comment to T267070: Amazon unresponsive donation form .

I see that the force class on the continue button is only supposed to be present when show_submethods is true.

Nov 4 2020, 5:43 PM · MW-1.36-notes (1.36.0-wmf.18; 2020-11-17), Fundraising Sprint Vagranty McVagrantface, FR-Amazon, fr-donorservices, Fundraising-Backlog
mepps added a comment to T267070: Amazon unresponsive donation form .

There's a lot going on in the code.

Nov 4 2020, 3:42 PM · MW-1.36-notes (1.36.0-wmf.18; 2020-11-17), Fundraising Sprint Vagranty McVagrantface, FR-Amazon, fr-donorservices, Fundraising-Backlog
mepps claimed T267070: Amazon unresponsive donation form .

On Safari I see just a continue button that doesn't work:

Nov 4 2020, 3:18 PM · MW-1.36-notes (1.36.0-wmf.18; 2020-11-17), Fundraising Sprint Vagranty McVagrantface, FR-Amazon, fr-donorservices, Fundraising-Backlog
mepps moved T267070: Amazon unresponsive donation form from Backlog to Doing on the Fundraising Sprint Vagranty McVagrantface board.
Nov 4 2020, 3:15 PM · MW-1.36-notes (1.36.0-wmf.18; 2020-11-17), Fundraising Sprint Vagranty McVagrantface, FR-Amazon, fr-donorservices, Fundraising-Backlog
mepps added a comment to T267070: Amazon unresponsive donation form .

I was able to reproduce this morning too. Not seeing console errors on prod weirdly. I wonder if I can get set up to reproduce locally..

Nov 4 2020, 2:55 PM · MW-1.36-notes (1.36.0-wmf.18; 2020-11-17), Fundraising Sprint Vagranty McVagrantface, FR-Amazon, fr-donorservices, Fundraising-Backlog

Nov 2 2020

mepps updated subscribers of T262976: Get payments wiki working on docker.

I can confirm I got this running locally with @Ejegg's patch https://gerrit.wikimedia.org/r/c/operations/docker-images/docker-pkg/+/637082.

Nov 2 2020, 8:22 PM · Fundraising Sprint We all meet again, User-brennen, Fundraising Sprint Vagranty McVagrantface, Fundraising Sprint Upbeat Upholstery, Patch-For-Review, fundraising sprint Theme songs for programming languages, MediaWiki-Docker, Fundraising Sprint 🐍 is not a valid zipcode, Fundraising-Backlog
mepps added a comment to T266562: Monthly convert pwk modal variant 011 (alt button text).

Great @spatton!

Nov 2 2020, 6:45 PM · Fundraising Sprint Vagranty McVagrantface, Fundraising-Backlog
mepps added a comment to T266562: Monthly convert pwk modal variant 011 (alt button text).

@spatton Quick question: did you want it to be "No, thanks!" or "No thanks!" as is?

Nov 2 2020, 2:22 PM · Fundraising Sprint Vagranty McVagrantface, Fundraising-Backlog

Oct 28 2020

mepps moved T264941: Adyen visa debit users see error coming back from card processor from Backlog to Done on the Fundraising Sprint Vagranty McVagrantface board.
Oct 28 2020, 2:51 PM · Fundraising Sprint Vagranty McVagrantface, MW-1.36-notes (1.36.0-wmf.16; 2020-11-03), Patch-For-Review, fr-donorservices, Fundraising Sprint Upbeat Upholstery, MediaWiki-extensions-DonationInterface, Fundraising-Backlog
mepps moved T222287: Civi: make sure Forget Me requests reach IBM from Backlog to Doing on the Fundraising Sprint Vagranty McVagrantface board.
Oct 28 2020, 2:51 PM · Patch-For-Review, Fundraising Sprint We all meet again, Fundraising Sprint Vagranty McVagrantface, Fundraising Sprint Upbeat Upholstery, fr-donorservices, Wikimedia-Fundraising-CiviCRM, Fundraising-Backlog
mepps added a comment to T266665: Civi to IBM export: No file on FTP.

Thanks @katers! Let's keep it open so fr-tech can discuss the retry code for now.

Oct 28 2020, 2:49 PM · FR-Email, Fundraising-Backlog
mepps added a comment to T266665: Civi to IBM export: No file on FTP.

It looks like there was an authentication failure last night. I've re-run the job now and it succeeded. It might be worthwhile to add re-try code into the upload job in case this happens again.

Oct 28 2020, 2:03 PM · FR-Email, Fundraising-Backlog

Oct 27 2020

mepps moved T250918: Make easy on/off switch for Monthly covert from Pending Deployment to Done on the Fundraising Sprint Upbeat Upholstery board.
Oct 27 2020, 4:21 PM · Patch-For-Review, MW-1.36-notes (1.36.0-wmf.16; 2020-11-03), Fundraising Sprint Upbeat Upholstery, fundraising sprint Theme songs for programming languages, FR-Q2-FY2020-21-cleanup-list, Fundraising-Backlog
mepps added a comment to T264663: fr-tech to look into supporting mail fail over for civi.

@Eileenmcnaughton I'm glad it works and given priorities I 'm up for +2ing, but I still had some thoughts and questions on the patches. I also think there might be one typo? I'm so glad it's moving away from the modules!

Oct 27 2020, 1:40 PM · Patch-For-Review, Fundraising Sprint Vagranty McVagrantface, Fundraising Sprint Upbeat Upholstery, Wikimedia-Fundraising-CiviCRM, Fundraising-Backlog

Oct 26 2020

mepps removed a project from T262977: Get queues working on docker: Fundraising Sprint Upbeat Upholstery.
Oct 26 2020, 8:24 PM · Fundraising Sprint We all meet again, Fundraising Sprint Vagranty McVagrantface, fundraising sprint Theme songs for programming languages, Fundraising Sprint 🐍 is not a valid zipcode, Fundraising-Backlog
mepps removed a project from T266091: Add license to fundraising-dev Docker repo: Fundraising Sprint Upbeat Upholstery.
Oct 26 2020, 8:22 PM · FR-Docker, Fundraising-Backlog
mepps moved T264941: Adyen visa debit users see error coming back from card processor from Review to Pending Deployment on the Fundraising Sprint Upbeat Upholstery board.
Oct 26 2020, 6:23 PM · Fundraising Sprint Vagranty McVagrantface, MW-1.36-notes (1.36.0-wmf.16; 2020-11-03), Patch-For-Review, fr-donorservices, Fundraising Sprint Upbeat Upholstery, MediaWiki-extensions-DonationInterface, Fundraising-Backlog
mepps moved T265700: all_Wikimedia database shows both_funds_donation_count as a decimal from Backlog to Done on the Fundraising Sprint Upbeat Upholstery board.

For now, I'm moving this to "Done" on the workboard because it looks like we might open another task for final cleanup. Feel free to move it if I'm wrong.

Oct 26 2020, 1:25 PM · Fundraising Sprint Upbeat Upholstery, Fundraising-Backlog

Oct 22 2020

mepps added a comment to T265700: all_Wikimedia database shows both_funds_donation_count as a decimal.

Thanks for the quick response @KHaggard! I'm trying to figure out where to direct my efforts :).

Oct 22 2020, 4:25 PM · Fundraising Sprint Upbeat Upholstery, Fundraising-Backlog
mepps added a comment to T265700: all_Wikimedia database shows both_funds_donation_count as a decimal.

@Eileenmcnaughton I'm trying to read from this if the primary issue is resolved now?

Oct 22 2020, 4:18 PM · Fundraising Sprint Upbeat Upholstery, Fundraising-Backlog
mepps moved T250918: Make easy on/off switch for Monthly covert from Review to Pending Deployment on the Fundraising Sprint Upbeat Upholstery board.
Oct 22 2020, 2:56 PM · Patch-For-Review, MW-1.36-notes (1.36.0-wmf.16; 2020-11-03), Fundraising Sprint Upbeat Upholstery, fundraising sprint Theme songs for programming languages, FR-Q2-FY2020-21-cleanup-list, Fundraising-Backlog

Oct 21 2020

mepps moved T265752: Not getting Adyen gateway for recurring AU & NZ donations from Pending Deployment to Done on the Fundraising Sprint Upbeat Upholstery board.

I just confirmed the adyen recurring links now work for AU and NZ.

Oct 21 2020, 6:17 PM · MW-1.36-notes (1.36.0-wmf.16; 2020-11-03), Fundraising Sprint Upbeat Upholstery, Fundraising-Backlog

Oct 19 2020

mepps moved T265752: Not getting Adyen gateway for recurring AU & NZ donations from Backlog to Review on the Fundraising Sprint Upbeat Upholstery board.
Oct 19 2020, 7:38 PM · MW-1.36-notes (1.36.0-wmf.16; 2020-11-03), Fundraising Sprint Upbeat Upholstery, Fundraising-Backlog
mepps added a comment to T254270: Dedupe donors before creating new contact.

@Eileenmcnaughton I don't find an associated patch or see a comment explaining this in review?

Oct 19 2020, 12:31 PM · Fundraising Sprint Upbeat Upholstery, FR-Q2-FY2020-21-cleanup-list, Wikimedia-Fundraising-CiviCRM, Fundraising-Backlog

Oct 15 2020

mepps added a comment to T222287: Civi: make sure Forget Me requests reach IBM.

A note that 2416641 got merged to 14901186 which doesn't explain the missing deletion. 20904192 also does have a civi contact, but again, this doesn't explain them existing in silverpop.
I'm wondering if there's any circumstance where silverpop could have duplicate emails, though I think we dedupe by email. Did we always do that? So far the commonality among these records is that they were duplicates.

Oct 15 2020, 3:51 PM · Patch-For-Review, Fundraising Sprint We all meet again, Fundraising Sprint Vagranty McVagrantface, Fundraising Sprint Upbeat Upholstery, fr-donorservices, Wikimedia-Fundraising-CiviCRM, Fundraising-Backlog
mepps added a comment to T222287: Civi: make sure Forget Me requests reach IBM.

I actually don't know that I have Zendesk access @MBeat33. That might help as I track this down. Because these contacts don't have Civi contacts I'm struggling to find more data on what happened. Could they be RML contacts? I realize RML contacts should have civi contacts and these addresses have contact ids in Acoustic so that's less likely.

Oct 15 2020, 2:23 PM · Patch-For-Review, Fundraising Sprint We all meet again, Fundraising Sprint Vagranty McVagrantface, Fundraising Sprint Upbeat Upholstery, fr-donorservices, Wikimedia-Fundraising-CiviCRM, Fundraising-Backlog

Oct 14 2020

mepps added a comment to T222287: Civi: make sure Forget Me requests reach IBM.

Ah thanks @KHaggard!

Oct 14 2020, 4:38 PM · Patch-For-Review, Fundraising Sprint We all meet again, Fundraising Sprint Vagranty McVagrantface, Fundraising Sprint Upbeat Upholstery, fr-donorservices, Wikimedia-Fundraising-CiviCRM, Fundraising-Backlog
mepps added a comment to T222287: Civi: make sure Forget Me requests reach IBM.

@KHaggard I don't know which email to search for because forgotten contacts have their emails deleted. How did you find the email address?

Oct 14 2020, 4:25 PM · Patch-For-Review, Fundraising Sprint We all meet again, Fundraising Sprint Vagranty McVagrantface, Fundraising Sprint Upbeat Upholstery, fr-donorservices, Wikimedia-Fundraising-CiviCRM, Fundraising-Backlog
mepps added a comment to T222287: Civi: make sure Forget Me requests reach IBM.

@KHaggard how do you search for these contacts on the suppression list? I was trying to look into this but without the email from civi, I'm not sure how to find them.

Oct 14 2020, 3:50 PM · Patch-For-Review, Fundraising Sprint We all meet again, Fundraising Sprint Vagranty McVagrantface, Fundraising Sprint Upbeat Upholstery, fr-donorservices, Wikimedia-Fundraising-CiviCRM, Fundraising-Backlog
mepps placed T261705: As a email manager, I'd like to see which contacts are suppressed up for grabs.

Removing my name so someone else reviews the patch above.

Oct 14 2020, 2:18 PM · Fundraising Sprint Upbeat Upholstery, fundraising sprint Theme songs for programming languages, Fundraising Sprint 🐍 is not a valid zipcode, Fundraising Sprint Raw data never hurt anyone, Fundraising-Backlog
mepps moved T261705: As a email manager, I'd like to see which contacts are suppressed from Backlog to Review on the Fundraising Sprint Upbeat Upholstery board.
Oct 14 2020, 2:13 PM · Fundraising Sprint Upbeat Upholstery, fundraising sprint Theme songs for programming languages, Fundraising Sprint 🐍 is not a valid zipcode, Fundraising Sprint Raw data never hurt anyone, Fundraising-Backlog

Oct 8 2020

mepps added a project to T265090: As a developer, I'd like GatewayPage and Mustache to be less codependent: Technical-Debt.
Oct 8 2020, 8:53 PM · Technical-Debt, Fundraising-Backlog
mepps renamed T265089: As a developer, I'd like to move resource logic out of Mustache.php from Move resource logic out of Mustache.php to As a developer, I'd like to move resource logic out of Mustache.php.
Oct 8 2020, 8:53 PM · Technical-Debt, Fundraising-Backlog
mepps created T265090: As a developer, I'd like GatewayPage and Mustache to be less codependent.
Oct 8 2020, 8:52 PM · Technical-Debt, Fundraising-Backlog
mepps created T265089: As a developer, I'd like to move resource logic out of Mustache.php.
Oct 8 2020, 8:49 PM · Technical-Debt, Fundraising-Backlog