Page MenuHomePhabricator

Rewire the federated properties entity type service definition for the EntityIdLabelFormatter
Closed, ResolvedPublic

Description

Once T251242: Rewrite LabelsProviderEntityIdHtmlLinkFormatter to remove use of the EntityTitleLookup service is complete we should be able to use this formatter for federated properties by passing in the appropriate services.
We should also delete the other LabelFormatter implementation that we created specifically for federated properties if we no longer use it.

This will switch out the implementation that we wrote in the previous sprint that does not handle deleted entities at all with the new version that we have developed throughout this sprint

Event Timeline

Restricted Application added a project: User-Addshore. · View Herald TranscriptMay 13 2020, 12:39 PM

Change 596412 had a related patch set uploaded (by Jakob; owner: Jakob):
[mediawiki/extensions/Wikibase@master] FP: Use the default LabelsProviderEntityIdHtmlLinkFormatter

https://gerrit.wikimedia.org/r/596412

Change 596412 merged by jenkins-bot:
[mediawiki/extensions/Wikibase@master] FP: Use the default LabelsProviderEntityIdHtmlLinkFormatter

https://gerrit.wikimedia.org/r/596412

Samantha_Alipio_WMDE closed this task as Resolved.May 28 2020, 2:23 PM