Page MenuHomePhabricator

Deploy new header to officewiki and testwiki
Closed, ResolvedPublic2 Estimated Story Points

Description

NOTE: deployment date Tuesday, May 12, 2020

Background

As we won't be introducing any functional changes, the first desktop improvement change (of the new header) will be deployed only to officewiki and testwiki

Acceptance criteria

For testwiki and officewiki

  • Turn legacy vector OFF/reveal setting
  • Default to new vector for officewiki
  • Default for testwiki - old vector

Developer notes

NOTE: Officewiki is not currently enabling the new Vector skin so we've been unable to check logos there. https://office.wikimedia.org/?useskinversion=2

Event Timeline

ovasileva updated the task description. (Show Details)
ovasileva set the point value for this task to 2.
Jdlrobson added a subscriber: Jdlrobson.

I believe this is unblocked. Although the gradient removal has not landed yet we agreed this was not a blocker.

Change 595597 had a related patch set uploaded (by Jdlrobson; owner: Jdlrobson):
[operations/mediawiki-config@master] Enable modern Vector on officewiki

https://gerrit.wikimedia.org/r/595597

Change 595597 merged by jenkins-bot:
[operations/mediawiki-config@master] Enable modern Vector on officewiki and reveal preference on test

https://gerrit.wikimedia.org/r/595597

Mentioned in SAL (#wikimedia-operations) [2020-05-11T18:44:16Z] <catrope@deploy1001> Synchronized wmf-config/InitialiseSettings.php: Enable modern Vector on officewiki, reveal preference on testwiki (T251285) (duration: 00m 58s)

Looks good logged in and logged out. Not seeing it on https://office.wikimedia.org/wiki/Main_Page, however

@ovasileva that's caching. We've talked about this earlier in the project. Any page which serves anonymous users is subject to caching (which typically stays live for 1 week). On larger rollout these will be unavoidable unless we arrange a cache purge with Brandon which considerably slows down roll out. Something to bear in mind in future as we roll out further. If we avoid the cache purge we can slowly roll out with the impact that the UI will not be consistent across pages.

Given Office Wikipedia only has one page subject to cache - the main page - this should now be fixed.

@ovasileva that's caching. We've talked about this earlier in the project. Any page which serves anonymous users is subject to caching (which typically stays live for 1 week). On larger rollout these will be unavoidable unless we arrange a cache purge with Brandon which considerably slows down roll out. Something to bear in mind in future as we roll out further. If we avoid the cache purge we can slowly roll out with the impact that the UI will not be consistent across pages.

Given Office Wikipedia only has one page subject to cache - the main page - this should now be fixed.

Oh that's a good point, since all other pages are private. I didn't think of that! Well, outside of that - it looks good!

ovasileva claimed this task.

Header is deployed and bug free. Thank you @Jdlrobson!