| Jdlrobson | |
| Apr 30 2020, 11:54 PM |
| F31812710: en.wikipedia.beta.wmflabs.org_wiki_Main_Page(iPad).png | |
| May 11 2020, 3:56 PM |
| F31789212: Screen Shot 2020-04-30 at 4.53.01 PM.png | |
| Apr 30 2020, 11:54 PM |
Currently there is a background gradient that displays on new Vector. While keeping it on the old Vector we don't want this on the new Vector.
Removing it is a little tricky as the required CSS rule is contained in the gigantic common.less
We will likely need to break this down first per decisions made in https://gerrit.wikimedia.org/r/587855
| AC | Status | Details |
|---|---|---|
| 1 | ✅ | T251583#6125330 |
There are 2 rules to be disabled for modern. These rules are in the huge common.less, which is not preferable to be duplicated for legacy, thus currently the best approach would be a conditional rule with the @is-legacy LESS var proposed by @Jdlrobson. The patch that demonstrates it: patch 589774.
After splitting 'common.less' the containing file 'theme.less' patch 587855 will be small enough to warrant a copy in 'legacy/' folder thus removing the need for a @is-legacy LESS var.
The task description does not say the page's gray background should be removed. That would be the 3rd rule to remove.
Change 593647 had a related patch set uploaded (by Aron Manning; owner: Aron Manning):
[mediawiki/skins/Vector@master] [modern] Drop the background gradient
@Jdlrobson, @alexhollender - is this for the header only or for the sidebar as well? I think this is the latest version of the sidebar and the gradient is still there although just for the sidebar. (now edited with the link to the prototype https://di-collapsible-sidebar-5.firebaseapp.com/Hathor)
Thanks for calling this out. We do want a gradient on the sidebar. I think a more precise title for this task might be "Remove gradient from header element and background color from body element". Currently the sidebar doesn't have its own background/gradient specified (it just picks up the background color from the page itself).
Change 595079 had a related patch set uploaded (by Aron Manning; owner: Aron Manning):
[mediawiki/skins/Vector@master] [modern] Move up color and background-color rule from content to body
Change 593647 merged by jenkins-bot:
[mediawiki/skins/Vector@master] [modern] Drop the background gradient
Change 595079 merged by jenkins-bot:
[mediawiki/skins/Vector@master] [modern] Move up color and background-color rule from content to body
Status: ✅ PASS
Environment: beta
OS: macOS Catalina
Browser: Chrome
Device: MBP
Emulated Device: NA
Test Artifact(s):
✅ AC1: Verify that the background gradient is not visible (see screenshot in task detail).
