Page MenuHomePhabricator

Using assertContains() with string haystacks is deprecated
Closed, ResolvedPublic

Description

01:19:31 1) Wikibase\Client\Tests\Integration\DataAccess\ParserFunctions\StatementsParserFunctionIntegrationTest::testStatementsParserFunction_maplink
01:19:31 === Logs generated by test case
01:19:31 [objectcache] [debug] MainWANObjectCache using store {class} {"class":"EmptyBagOStuff"}
01:19:31 [localisation] [debug] LocalisationCache using store LCStoreNull []
01:19:31 [Wikibase] [debug] {method}: setting {settingName} was given as a closure, resolve it to {logValue} {"method":"Wikibase\\Lib\\SettingsArray::getSetting","settingName":"thisWikiIsTheRepo","logValue":"true"}
01:19:31 [Wikibase] [debug] {method}: setting {settingName} was given as a closure, resolve it to {logValue} {"method":"Wikibase\\Lib\\SettingsArray::getSetting","settingName":"repoUrl","logValue":"'http:\/\/127.0.0.1:9412'"}
01:19:31 [Wikibase] [debug] {method}: setting {settingName} was given as a closure, resolve it to {logValue} {"method":"Wikibase\\Lib\\SettingsArray::getSetting","settingName":"repositories","logValue":"array (\n  '' => \n  array (\n    'repoDatabase' => false,\n    'baseUri' => 'http:\/\/127.0.0.1:9412\/entity\/',\n    'entityNamespaces' => \n    array (\n      'item' => 120,\n      'property' => 122,\n      'mediainfo' => '6\/mediainfo',\n    ),\n    'prefixMapping' => \n    array (\n      '' => '',\n    ),\n  ),\n)"}
01:19:31 [objectcache] [debug] MainWANObjectCache using store {class} {"class":"EmptyBagOStuff"}
01:19:31 [Wikibase] [debug] {method}: setting {settingName} was given as a closure, resolve it to {logValue} {"method":"Wikibase\\Lib\\SettingsArray::getSetting","settingName":"siteGlobalID","logValue":"'wikidb'"}
01:19:31 [localisation] [debug] LocalisationCache using store LCStoreNull []
01:19:31 [localisation] [debug] LocalisationCache::isExpired(de): cache missing, need to make one []
01:19:31 [wfDebug] [debug] IP: 127.0.0.1 {"private":false}
01:19:31 [objectcache] [debug] MainWANObjectCache using store {class} {"class":"EmptyBagOStuff"}
01:19:31 [wfDebug] [debug] ParserFactory: using default preprocessor {"private":false}
01:19:31 [Wikibase] [debug] {method}: No property info found for {propertyId}, but property ID could be retrieved from fallback store! {"method":"Wikibase\\Lib\\PropertyInfoDataTypeLookup::getDataTypeIdForProperty","propertyId":{}}
01:19:31 [Wikibase] [debug] {method}: No property info found for {propertyId}, but property ID could be retrieved from fallback store! {"method":"Wikibase\\Lib\\PropertyInfoDataTypeLookup::getDataTypeIdForProperty","propertyId":{}}
01:19:31 [MessageCache] [debug] MessageCache using store {class} {"class":"HashBagOStuff"}
01:19:31 [wfDebug] [debug] IP: 127.0.0.1 {"private":false}
01:19:31 [Wikibase] [debug] {method}: setting {settingName} was given as a closure, resolve it to {logValue} {"method":"Wikibase\\Lib\\SettingsArray::getSetting","settingName":"thisWikiIsTheRepo","logValue":"true"}
01:19:31 [Wikibase] [debug] {method}: setting {settingName} was given as a closure, resolve it to {logValue} {"method":"Wikibase\\Lib\\SettingsArray::getSetting","settingName":"repoUrl","logValue":"'http:\/\/127.0.0.1:9412'"}
01:19:31 [Wikibase] [debug] {method}: setting {settingName} was given as a closure, resolve it to {logValue} {"method":"Wikibase\\Lib\\SettingsArray::getSetting","settingName":"repositories","logValue":"array (\n  '' => \n  array (\n    'repoDatabase' => false,\n    'baseUri' => 'http:\/\/127.0.0.1:9412\/entity\/',\n    'entityNamespaces' => \n    array (\n      'item' => 120,\n      'property' => 122,\n      'mediainfo' => '6\/mediainfo',\n    ),\n    'prefixMapping' => \n    array (\n      '' => '',\n    ),\n  ),\n)"}
01:19:31 ===
01:19:31 Using assertContains() with string haystacks is deprecated and will not be supported in PHPUnit 9. Refactor your test to use assertStringContainsString() or assertStringContainsStringIgnoringCase() instead.
01:19:31 Using assertNotContains() with string haystacks is deprecated and will not be supported in PHPUnit 9. Refactor your test to use assertStringNotContainsString() or assertStringNotContainsStringIgnoringCase() instead.
01:19:31 
01:19:31 /workspace/src/tests/phpunit/MediaWikiIntegrationTestCase.php:423
01:19:31 /workspace/src/maintenance/doMaintenance.php:105

Event Timeline

Reedy created this task.May 2 2020, 12:23 AM
Restricted Application added subscribers: Liuxinyu970226, Aklapper. · View Herald TranscriptMay 2 2020, 12:23 AM
toan claimed this task.May 11 2020, 8:03 AM

Change 595497 had a related patch set uploaded (by Tobias Andersson; owner: Tobias Andersson):
[mediawiki/extensions/Wikibase@master] StatementsParserFunctionIntegrationTest: replace deprecated assertion functions

https://gerrit.wikimedia.org/r/595497

Change 595497 merged by jenkins-bot:
[mediawiki/extensions/Wikibase@master] StatementsParserFunctionIntegrationTest: replace deprecated assertion functions

https://gerrit.wikimedia.org/r/595497