Page MenuHomePhabricator

Following notes link results in wrong title on navigation bar
Open, LowPublic

Description

  1. Reading - In a Notes section, when you tap the letter to return to the section in context, it gives some chrome (on the top and bottom of the device) that is probably more appropriate for a citation. See image 1 below.

Image 1 - Existing App Store App / New PCS

IMG_8233.PNG (1×750 px, 1 MB)
/
PCS tap from notes section.png (1×828 px, 937 KB)

Event Timeline

Doesn't look like there is a canonical way Notes are stored across language wikis.

How notes title display
Spanish: Reference [notas 3]
French: Reference [note 1]
English: Reference [lower-alpha 1] (UPDATE this to Reference [a] to match the link you clicked. lower-alpha is translated in CSS. Which means we also need the PCS JS to translate it before sending it to the iOS side.)

How back links work
Spanish: Back link BROKEN when in ReferencesVC (tapping note in article), but works in BackLinksReferenceVC (tapping note backlink at end of article)
French: Works in all cases
English: Must CONFIRM it still works after making fix above

I think this is best solved in PCS. The current dream solution is for English to just say Reference [a] instead of Reference [lower-alpha 1]. It's saying lower-alpha because we're letting CSS do some of the enumerating. Whatever is being done so that it looks proper in the article also needs to be done when a user taps the notes link (triggering a ReferenceClicked action) and we send a message to the iOS side.