| Subject | Repo | Branch | Lines +/- | |
|---|---|---|---|---|
| Use system logger | mediawiki/services/wikispeech/mishkal | master | +47 -1 |
Details
Details
| Status | Subtype | Assigned | Task | ||
|---|---|---|---|---|---|
| Resolved | None | T252751 ☂Use system loggers | |||
| Resolved | HaraldBerthelsen | T252752 Patch Mishkal to use system logger rather than log to disk |
Event Timeline
Comment Actions
The problem with logging to disk is related to Blubber docker images builds -- they must then be marked as unsecure to allow for writing data to /srv/.
Mishkal logging seems to be semi-configurable. See interfaces/web/mishkal-webserver.py
Mishkal is Python2.7. :C
Comment Actions
Possibly it could log to stdout as we're not really that interested in the output, but it's nice to be able to inspect the log in case something goes south.
Comment Actions
Changed to use
logging.handlers.SysLogHandler(address = '/dev/log')
instead of
logging.StreamHandler()
Doesn't fully use syslog, though, there are still things printed to stdout, not sure from where.
But for each call to mishkal, a line like this shows up in syslog:
Sep 8 15:17:59 harald-Vox 2020-09-08 15:17:59,676 - Mishkal - INFO - 2020-09-08 03:17#011Tashkeel2#011 السويد
Maybe enough?
Comment Actions
Will introduce as new file to avoid future merge conflicts. Will also require updating the entrypoints.
Comment Actions
Change 634304 had a related patch set uploaded (by Karl Wettin (WMSE); owner: Karl Wettin (WMSE)):
[mediawiki/services/wikispeech/mishkal@master] Use system logger
Comment Actions
Change 634304 merged by jenkins-bot:
[mediawiki/services/wikispeech/mishkal@master] Use system logger