Page MenuHomePhabricator

Focus not visible on checkbox in high contrast dark mode
Closed, ResolvedPublicBUG REPORT

Description

Steps to Reproduce:

  • Go to a page
  • Navigate to Edit and hit enter
  • Navigate to Insert -> Images and media and hit enter
  • Switch tab to Upload
  • Change computer settings to high contrast dark mode
  • Check if focus is visible on checkbox

Actual Results:

  • Focus is not visible on checkbox in high contrast mode

image.png (579×629 px, 42 KB)

Expected Results:

  • Focus should be visible in all color modes

image.png (582×635 px, 42 KB)

Event Timeline

Change 598543 had a related patch set uploaded (by Bkudiess-msft; owner: Bkudiess-msft):
[mediawiki/core@master] Adds checkbox focus in high contrast mode

https://gerrit.wikimedia.org/r/598543

@Bkudiess-msft It would be helpful to have before/after screenshots in the task description! Thanks.

Change 602438 had a related patch set uploaded (by VolkerE; owner: VolkerE):
[oojs/ui@master] [dnm] WikimediaUI theme: CheckboxInputWidget in high-contrast mode

https://gerrit.wikimedia.org/r/602438

Change 598543 abandoned by VolkerE:
Adds checkbox focus in high contrast mode

Reason:
for Ie7fa555e822c1b83dac80a55728e11669bf8a08d

https://gerrit.wikimedia.org/r/598543

Volker_E triaged this task as Lowest priority.Jun 4 2020, 6:18 PM

@Bkudiess-msft I've looked into this a bit further and don't see easy or useful support for the non-standards way of supporting high contrast to be covered in the library for now.

The opacity proposal added by you would result in a UI glitch for non high-contrast users

image.png (332×624 px, 37 KB)

By the way, it would need to be added for RadioInputWidgets as well.

The media feature -ms-high-contrast is proprietary, has changed in the past and the further support with standards support and Edge changing over to Chromium base doesn't make it clearer. See https://developer.mozilla.org/en-US/docs/Web/CSS/@media/-ms-high-contrast for further information.

Change 607639 had a related patch set uploaded (by Bkudiess-msft; owner: Bkudiess-msft):
[oojs/ui@master] Adds checkbox focus in high contrast mode

https://gerrit.wikimedia.org/r/607639

Change 602438 abandoned by VolkerE:
[dnm] WikimediaUI theme: CheckboxInputWidget in high-contrast mode

Reason:
Was mostly a proof of failed concept. We've got alternative approaches proposed and discussed in I0a3aab39c2d97 & I0a3aab39c2d

https://gerrit.wikimedia.org/r/602438

Change 607639 abandoned by Bartosz Dziewoński:
[oojs/ui@master] Adds checkbox focus in high contrast mode

Reason:
Already merged as part of https://gerrit.wikimedia.org/r/c/oojs/ui/ /607640

https://gerrit.wikimedia.org/r/607639

Volker_E moved this task from Next-up to OOUI-0.38.0 on the OOUI board.
Volker_E edited projects, added OOUI (OOUI-0.38.0); removed OOUI.
Volker_E moved this task from OOUI-0.38.0 to OOUI-0.39.3 on the OOUI board.
Volker_E edited projects, added OOUI (OOUI-0.39.3); removed OOUI (OOUI-0.38.0).