Page MenuHomePhabricator

SpecialSetSiteLinkTest::testExecutePostRemoveSiteLink & testExecutePostModifySiteLink failing for no apparent reason
Closed, ResolvedPublic

Description

On head of Wikibase master & mediawiki.

The following two tests keep failing.

There were 2 errors:

1) Wikibase\Repo\Tests\Specials\SpecialSetSiteLinkTest::testExecutePostModifySiteLink
TypeError: Argument 2 passed to PHPUnit\Framework\Assert::assertStringContainsString() must be of the type string, null given, called in /home/toan/Documents/dev/Wikibase/repo/tests/phpunit/includes/Specials/SpecialSetSiteLinkTest.php on line 270

/home/toan/Documents/dev/Wikibase/repo/tests/phpunit/includes/Specials/SpecialSetSiteLinkTest.php:270
/var/www/mediawiki/tests/phpunit/MediaWikiIntegrationTestCase.php:437
/var/www/mediawiki/maintenance/doMaintenance.php:105
=== Logs generated by test case
[objectcache] [debug] MainWANObjectCache using store {class} {"class":"EmptyBagOStuff"}
[localisation] [debug] LocalisationCache using store LCStoreNull []
[Wikibase] [debug] {method}: setting {settingName} was given as a closure, resolve it to {logValue} {"method":"Wikibase\\Lib\\SettingsArray::getSetting","settingName":"conceptBaseUri","logValue":"'http:\/\/default.web.mw.localhost:80\/entity\/'"}
[objectcache] [debug] MainWANObjectCache using store {class} {"class":"EmptyBagOStuff"}
[localisation] [debug] LocalisationCache::isExpired(en): cache missing, need to make one []
[MessageCache] [debug] MessageCache using store {class} {"class":"HashBagOStuff"}
[wfDebug] [debug] ParserFactory: using default preprocessor {"private":false}
[localisation] [debug] LocalisationCache::isExpired(qqx): cache missing, need to make one []
[Wikibase] [debug] {method}: setting {settingName} was given as a closure, resolve it to {logValue} {"method":"Wikibase\\Lib\\SettingsArray::getSetting","settingName":"dataRightsUrl","logValue":"NULL"}
[Wikibase] [debug] {method}: setting {settingName} was given as a closure, resolve it to {logValue} {"method":"Wikibase\\Lib\\SettingsArray::getSetting","settingName":"dataRightsText","logValue":"NULL"}
[GlobalTitleFail] [info] RequestContext::getTitle called with no title set. {"exception":{}}
[wfDebug] [debug] User::getBlockedStatus: checking... {"private":false}
[GlobalTitleFail] [info] RequestContext::getTitle called with no title set. {"exception":{}}
[Wikibase] [debug] {method}: Looking up entity {entityId} (revision {revisionId}). {"method":"Wikibase\\Lib\\Store\\Sql\\WikiPageEntityRevisionLookup::getEntityRevision","entityId":{},"revisionId":0}
[objectcache] [debug] fetchOrRegenerate(global:NameTableSqlStore:slot_roles:default-unittest_): miss, new value computed []
[objectcache] [debug] fetchOrRegenerate(global:NameTableSqlStore:content_models:default-unittest_): miss, new value computed []
[objectcache] [debug] fetchOrRegenerate(global:SqlBlobStore-blob:default-unittest_:tt%3A3): miss, new value computed []
[GlobalTitleFail] [info] MessageCache::parse called with no title set. {"exception":{}}
[objectcache] [debug] fetchOrRegenerate(global:NameTableSqlStore:wbt_type:default-unittest_): miss, new value computed []
===

2) Wikibase\Repo\Tests\Specials\SpecialSetSiteLinkTest::testExecutePostRemoveSiteLink
TypeError: Argument 2 passed to PHPUnit\Framework\Assert::assertStringContainsString() must be of the type string, null given, called in /home/toan/Documents/dev/Wikibase/repo/tests/phpunit/includes/Specials/SpecialSetSiteLinkTest.php on line 294

/home/toan/Documents/dev/Wikibase/repo/tests/phpunit/includes/Specials/SpecialSetSiteLinkTest.php:294
/var/www/mediawiki/tests/phpunit/MediaWikiIntegrationTestCase.php:437
/var/www/mediawiki/maintenance/doMaintenance.php:105
=== Logs generated by test case
[objectcache] [debug] MainWANObjectCache using store {class} {"class":"EmptyBagOStuff"}
[localisation] [debug] LocalisationCache using store LCStoreNull []
[Wikibase] [debug] {method}: setting {settingName} was given as a closure, resolve it to {logValue} {"method":"Wikibase\\Lib\\SettingsArray::getSetting","settingName":"conceptBaseUri","logValue":"'http:\/\/default.web.mw.localhost:80\/entity\/'"}
[objectcache] [debug] MainWANObjectCache using store {class} {"class":"EmptyBagOStuff"}
[localisation] [debug] LocalisationCache::isExpired(en): cache missing, need to make one []
[MessageCache] [debug] MessageCache using store {class} {"class":"HashBagOStuff"}
[wfDebug] [debug] ParserFactory: using default preprocessor {"private":false}
[localisation] [debug] LocalisationCache::isExpired(qqx): cache missing, need to make one []
[Wikibase] [debug] {method}: setting {settingName} was given as a closure, resolve it to {logValue} {"method":"Wikibase\\Lib\\SettingsArray::getSetting","settingName":"dataRightsUrl","logValue":"NULL"}
[Wikibase] [debug] {method}: setting {settingName} was given as a closure, resolve it to {logValue} {"method":"Wikibase\\Lib\\SettingsArray::getSetting","settingName":"dataRightsText","logValue":"NULL"}
[GlobalTitleFail] [info] RequestContext::getTitle called with no title set. {"exception":{}}
[wfDebug] [debug] User::getBlockedStatus: checking... {"private":false}
[GlobalTitleFail] [info] RequestContext::getTitle called with no title set. {"exception":{}}
[Wikibase] [debug] {method}: Looking up entity {entityId} (revision {revisionId}). {"method":"Wikibase\\Lib\\Store\\Sql\\WikiPageEntityRevisionLookup::getEntityRevision","entityId":{},"revisionId":0}
[objectcache] [debug] fetchOrRegenerate(global:NameTableSqlStore:slot_roles:default-unittest_): miss, new value computed []
[objectcache] [debug] fetchOrRegenerate(global:NameTableSqlStore:content_models:default-unittest_): miss, new value computed []
[objectcache] [debug] fetchOrRegenerate(global:SqlBlobStore-blob:default-unittest_:tt%3A3): miss, new value computed []
[GlobalTitleFail] [info] MessageCache::parse called with no title set. {"exception":{}}
[objectcache] [debug] fetchOrRegenerate(global:NameTableSqlStore:wbt_type:default-unittest_): miss, new value computed []
===

Event Timeline

Restricted Application added subscribers: Liuxinyu970226, Aklapper. · View Herald Transcript
Ladsgroup added a subscriber: Ladsgroup.

Let me take a look at this.

Change 602163 had a related patch set uploaded (by Ladsgroup; owner: Ladsgroup):
[mediawiki/extensions/Wikibase@master] Do not depend on the test runner's setting of sitelink groups

https://gerrit.wikimedia.org/r/602163

Change 602163 merged by jenkins-bot:
[mediawiki/extensions/Wikibase@master] Do not depend on the test runner's setting of sitelink groups

https://gerrit.wikimedia.org/r/602163