Maniphest T254740

Prefetch entities as part of federated properties
Closed, ResolvedPublic13 Estimated Story Points
Actions

Assigned To

None

Authored By

	Addshore
	Jun 8 2020, 11:27 AM

Tags

Referenced Files

None

Subscribers

Description

Background

In T253125 we realized that prefetching wasn't working correctly.
We were planing on the terms related prefetching always resulting in correctly prefetched entities, however, that prefetching did not happen in time for some needed data, thus when we switched to requiring prefetching, we got exceptions as things were not prefetched in time. (see the ticket filed).

In T253125#6162897 we performed a task breakdown where we were thinking about using EntityInfo for prefetching, however, shortly after the breakdown we realized that EntityInfo is not really used any more and already should have been removed (see a big comment at T253125#6163636 and also T254283: Remove legacy EntityInfo based prefetching that has now been created).

Criteria
Prefetching of properties should happen when:

Entity pages are rendered
Pages with edit summaries that we format are rendered

Other links and reading

Breakdown from the previous hike when EntityInfo was still a thing T253125#6162897
Previous EntityInfo based prefetching collected referenced entities for prefetching in parser output generator https://gerrit.wikimedia.org/r/c/mediawiki/extensions/Wikibase/+/604121/8/repo/includes/ParserOutput/FullEntityParserOutputGenerator.php#b197

Related Objects
Search...

		Status	Subtype	Assigned	Task
		Resolved		None	T254740 Prefetch entities as part of federated properties
		Resolved		• toan	T258041 Prefetch entities in fed props for entity page rendering
		Resolved		• toan	T258042 Prefetch entities in fed props for pages using summary formatting
		Resolved		• toan	T258044 Measure the difference in performance loading large item pages and history pages before and after prefetching

Event Timeline

Addshore created this task.Jun 8 2020, 11:27 AM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptJun 8 2020, 11:27 AM

Addshore updated the task description. (Show Details)Jun 8 2020, 11:28 AM

Rosalie_WMDE updated the task description. (Show Details)Jun 8 2020, 12:37 PM

• Samantha_Alipio_WMDE moved this task from Backlog to Prioritized backlog (aka Ready to pick up) on the Wikibase - Federated Properties board.Jun 12 2020, 8:28 AM

• Samantha_Alipio_WMDE moved this task from Prioritized backlog (aka Ready to pick up) to Ready for Breakdown on the Wikibase - Federated Properties board.

• Samantha_Alipio_WMDE moved this task from Ready for Breakdown to Backlog on the Wikibase - Federated Properties board.Jun 15 2020, 9:58 AM

• Samantha_Alipio_WMDE moved this task from Backlog to Ready to estimate on the Wikibase - Federated Properties board.Jul 8 2020, 8:56 AM

• Samantha_Alipio_WMDE set the point value for this task to 13.Jul 13 2020, 1:37 PM

• Samantha_Alipio_WMDE moved this task from Ready to estimate to Ready for Breakdown on the Wikibase - Federated Properties board.

Addshore updated the task description. (Show Details)Jul 15 2020, 10:37 AM

Addshore updated the task description. (Show Details)

Addshore updated the task description. (Show Details)

Addshore mentioned this in T258044: Measure the difference in performance loading large item pages and history pages before and after prefetching.Jul 15 2020, 10:56 AM

Addshore moved this task from Ready for Breakdown to Prioritized backlog (aka Ready to pick up) on the Wikibase - Federated Properties board.

Addshore added a project: Story.Jul 21 2020, 3:05 PM

• toan moved this task from Prioritized backlog (aka Ready to pick up) to Sprint 4/6 (Hike 2) on the Wikibase - Federated Properties board.Aug 14 2020, 7:45 AM

• toan edited projects, added Wikibase - Federated Properties (Sprint 4/6 (Hike 2)); removed Wikibase - Federated Properties.

• toan moved this task from To do to Doing on the Wikibase - Federated Properties (Sprint 4/6 (Hike 2)) board.

• Samantha_Alipio_WMDE edited projects, added Wikibase - Federated Properties (Sprint 5/6 (Hike 2)); removed Wikibase - Federated Properties (Sprint 4/6 (Hike 2)).Aug 19 2020, 8:37 AM

• Samantha_Alipio_WMDE moved this task from To do to Doing on the Wikibase - Federated Properties (Sprint 5/6 (Hike 2)) board.

• toan moved this task from Doing to Peer Review on the Wikibase - Federated Properties (Sprint 5/6 (Hike 2)) board.Aug 25 2020, 8:27 AM

Rosalie_WMDE moved this task from Peer Review to Doing on the Wikibase - Federated Properties (Sprint 5/6 (Hike 2)) board.Aug 27 2020, 8:57 AM

Rosalie_WMDE moved this task from Doing to Peer Review on the Wikibase - Federated Properties (Sprint 5/6 (Hike 2)) board.Sep 1 2020, 8:38 AM

Addshore moved this task from Peer Review to Product Verification on the Wikibase - Federated Properties (Sprint 5/6 (Hike 2)) board.Sep 1 2020, 12:12 PM

• Samantha_Alipio_WMDE moved this task from Product Verification to Done on the Wikibase - Federated Properties (Sprint 5/6 (Hike 2)) board.Sep 2 2020, 1:05 PM

• Samantha_Alipio_WMDE closed subtask T258041: Prefetch entities in fed props for entity page rendering as Resolved.Sep 4 2020, 10:47 AM

• Samantha_Alipio_WMDE closed subtask T258044: Measure the difference in performance loading large item pages and history pages before and after prefetching as Resolved.

Addshore closed this task as Resolved.Oct 30 2020, 5:50 PM

Addshore closed subtask T258042: Prefetch entities in fed props for pages using summary formatting as Resolved.