Make common implementation of findVariantLink functions of Language Converters.
Closed, ResolvedPublic0.5 Estimated Story Points
Actions

Assigned To

Authored By

	Art.tsymbar
	Jun 8 2020, 3:40 PM

Description

Story

The function "findVariantLink " is implemented with the same code in every Language converter. So there is a code duplication which should be avoided.

Context

public function findVariantLink( &$link, &$nt, $ignoreOtherCond = false )

Expected result

Common realisation of the function in parent class.
Specific realisation in the Converters if there is any logic difference.

Details

	Subject	Repo	Branch	Lines +/-
	Language: Make common implementation of findVariantLink functions of Language Converters.	mediawiki/core	master	+75 -162

Customize query in gerrit

Event Timeline

Art.tsymbar created this task.Jun 8 2020, 3:40 PM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptJun 8 2020, 3:40 PM

Art.tsymbar set the point value for this task to 0.5.Jun 9 2020, 8:47 AM

Peter.ovchyn triaged this task as Medium priority.Jun 9 2020, 9:11 AM

Peter.ovchyn updated the task description. (Show Details)

Peter.ovchyn subscribed.

Peter.ovchyn renamed this task from Make common realisation of findVariantLink functions of Language Converters. to Make common implementation of findVariantLink functions of Language Converters. .Jun 9 2020, 9:23 AM

Art.tsymbar moved this task from Backlog to In Progress/Doing on the Platform Team Workboards (S&F Workboard) board.Jun 9 2020, 2:40 PM

Helga_sf moved this task from In Progress/Doing to Current sprint Backlog on the Platform Team Workboards (S&F Workboard) board.Jun 11 2020, 11:25 AM

Change 605414 had a related patch set uploaded (by Art.tsymbar; owner: arttsymbar):
[mediawiki/core@master] Language: Make common implementation of findVariantLink functions of Language Converters.

https://gerrit.wikimedia.org/r/605414

gerritbot added a project: Patch-For-Review.Jun 14 2020, 4:18 PM

Art.tsymbar moved this task from Current sprint Backlog to In Progress/Doing on the Platform Team Workboards (S&F Workboard) board.Jun 14 2020, 4:19 PM

Art.tsymbar moved this task from In Progress/Doing to In Progress/In Review on the Platform Team Workboards (S&F Workboard) board.

Reedy updated the task description. (Show Details)Jun 14 2020, 5:32 PM

Change 605414 merged by jenkins-bot:
[mediawiki/core@master] Language: Make common implementation of findVariantLink functions of Language Converters.

https://gerrit.wikimedia.org/r/c/mediawiki/core/ /605414

ReleaseTaggerBot added a project: MW-1.35-notes (1.35.0-wmf.40; 2020-07-07).Jul 2 2020, 8:00 PM

Maintenance_bot removed a project: Patch-For-Review.Jul 2 2020, 8:10 PM

Art.tsymbar moved this task from In Progress/In Review to Done on the Platform Team Workboards (S&F Workboard) board.Jul 3 2020, 10:35 AM

Reedy closed this task as Resolved.Oct 25 2020, 8:28 PM

Winston_Sung moved this task from Backlog to Core on the MediaWiki-Language-converter board.Dec 27 2023, 6:31 PM

Make common implementation of findVariantLink functions of Language Converters. Closed, ResolvedPublic0.5 Estimated Story PointsActions

Description

Details

Event Timeline

Make common implementation of findVariantLink functions of Language Converters.
Closed, ResolvedPublic0.5 Estimated Story Points
Actions