Page MenuHomePhabricator

Drop the `.menu` and `.vectorMenu` class from Vector
Open, MediumPublic

Description

The menu class is used in several gadgets but not a significant amount to warrant being kept around.

https://global-search.toolforge.org/?q=%5B+%5C%27%5E%5D%5C.menu%5B+%2C%5C%7B%5D&regex=1&namespaces=2%2C4%2C8&title=

A/C

  • Wait for the usernotice T254797 to go out
  • Give users 2-4 weeks to respond.
  • Remove code

Event Timeline

Jdlrobson created this task.Jun 8 2020, 6:27 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptJun 8 2020, 6:27 PM
Jdlrobson updated the task description. (Show Details)Jun 8 2020, 6:27 PM
Amorymeltzer added a subscriber: Amorymeltzer.EditedJun 8 2020, 8:18 PM

@Jdlrobson Presumably this will include .vectorMenuCheckbox -> .vector-menu-checkbox (added in T253329/https://gerrit.wikimedia.org/r/c/mediawiki/skins/Vector/+/59784) or is that to be done separately? I note that T254797 doesn't mention it in the search query.

@Amorymeltzer eventually that will go yes but I'm not focusing that on right now. In general refamiliarizing gadgets with the current HTML markup is probably a good idea if you want to avoid responding to more of these notices in future :)

Jdlrobson triaged this task as Medium priority.Jun 9 2020, 3:39 PM
Jdlrobson moved this task from Needs triage to Menus on the Vector board.Jul 21 2020, 11:42 PM