Typo: HTTP options are not passed
Closed, ResolvedPublicBUG REPORT
Actions

Assigned To

Authored By

	alex-mashin
	Jun 9 2020, 5:56 AM

Description

In the line 923 of includes/EDUtils.php $options are not passed to EDHttpWithHeaders::get():

$page = EDHttpWithHeaders::get( $url);

In the line 903 they are.

Also, __METHOD__ is not passed in both cases.

A patch will follow soon.

Details

	Subject	Repo	Branch	Lines +/-
	Fix typo: pass $options to EDHttpWithHeaders::get()	mediawiki/extensions/ExternalData	master	+3 -3

Customize query in gerrit

Event Timeline

alex-mashin created this task.Jun 9 2020, 5:56 AM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptJun 9 2020, 5:56 AM

alex-mashin claimed this task.Jun 9 2020, 5:56 AM

alex-mashin triaged this task as Unbreak Now! priority.

Restricted Application added a subscriber: Liuxinyu970226. · View Herald TranscriptJun 9 2020, 5:56 AM

Change 603813 had a related patch set uploaded (by Alex Mashin; owner: mashin):
[mediawiki/extensions/ExternalData@master] Fix typo: pass $options to EDHttpWithHeaders::get()

https://gerrit.wikimedia.org/r/603813

gerritbot added a project: Patch-For-Review.Jun 9 2020, 7:09 AM

Change 603813 merged by jenkins-bot:
[mediawiki/extensions/ExternalData@master] Fix typo: pass $options to EDHttpWithHeaders::get()

https://gerrit.wikimedia.org/r/603813

Maintenance_bot removed a project: Patch-For-Review.Jun 9 2020, 3:10 PM

tstarling lowered the priority of this task from Unbreak Now! to High.Jun 10 2020, 6:28 AM

alex-mashin closed this task as Resolved.Jun 10 2020, 6:38 AM

Typo: HTTP options are not passedClosed, ResolvedPublicBUG REPORTActions

Description

Details

Event Timeline

Typo: HTTP options are not passed
Closed, ResolvedPublicBUG REPORT
Actions