Page MenuHomePhabricator

CologneBlue should not run BaseTemplateAfterPortlet
Closed, ResolvedPublic

Description

The BaseTemplateAfterPortlet hook was deprecated in T253797. It should not be run directly in CologneBlue.

Instead CologneBlue should use Skin::getAfterPortlet

The hook is currently deprecated silently.

Event Timeline

Jdlrobson created this task.Jun 9 2020, 9:59 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptJun 9 2020, 9:59 PM
Mainframe98 added a subscriber: Mainframe98.

I wrote a patch for this earlier but didn't get around to uploading it.

Change 604313 had a related patch set uploaded (by Mainframe98; owner: Mainframe98):
[mediawiki/skins/CologneBlue@master] Use Skin::afterPortlet

https://gerrit.wikimedia.org/r/604313

Change 604313 merged by jenkins-bot:
[mediawiki/skins/CologneBlue@master] Use Skin::afterPortlet

https://gerrit.wikimedia.org/r/604313

Jdlrobson closed this task as Resolved.Jun 11 2020, 10:16 PM