Maniphest T254945

CologneBlue should not run BaseTemplateAfterPortlet
Closed, ResolvedPublic
Actions

Assigned To

Authored By

	Jdlrobson
	Jun 9 2020, 9:59 PM

Tags

Referenced Files

None

Subscribers

Description

The BaseTemplateAfterPortlet hook was deprecated in T253797. It should not be run directly in CologneBlue.

Instead CologneBlue should use Skin::getAfterPortlet

The hook is currently deprecated silently.

Details

	Subject	Repo	Branch	Lines +/-
	Use Skin::afterPortlet	mediawiki/skins/CologneBlue	master	+4 -8

Customize query in gerrit

Related Objects
Search...

		Status	Subtype	Assigned	Task
		Resolved		Mainframe98	T254945 CologneBlue should not run BaseTemplateAfterPortlet
		Resolved		Jdlrobson	T254949 BaseTemplateAfterPortlet is silent deprecated - use SkinAfterPortlet in Wikibase

Event Timeline

Jdlrobson created this task.Jun 9 2020, 9:59 PM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptJun 9 2020, 9:59 PM

Jdlrobson moved this task from Phase 1 - simplify hook contracts to Phase 3 - standardise template data on the MediaWiki-Core-Skin-Architecture board.Jun 9 2020, 9:59 PM

I wrote a patch for this earlier but didn't get around to uploading it.

Change 604313 had a related patch set uploaded (by Mainframe98; owner: Mainframe98):
[mediawiki/skins/CologneBlue@master] Use Skin::afterPortlet

https://gerrit.wikimedia.org/r/604313

gerritbot added a project: Patch-For-Review.Jun 10 2020, 9:13 AM

Jdlrobson mentioned this in T254949: BaseTemplateAfterPortlet is silent deprecated - use SkinAfterPortlet in Wikibase.Jun 10 2020, 5:15 PM

Mainframe98 added a subtask: T254949: BaseTemplateAfterPortlet is silent deprecated - use SkinAfterPortlet in Wikibase.Jun 10 2020, 5:19 PM

Jdlrobson closed subtask T254949: BaseTemplateAfterPortlet is silent deprecated - use SkinAfterPortlet in Wikibase as Resolved.Jun 11 2020, 10:08 PM

Jdlrobson moved this task from Phase 3 - standardise template data to Phase 1 - simplify hook contracts on the MediaWiki-Core-Skin-Architecture board.

Change 604313 merged by jenkins-bot:
[mediawiki/skins/CologneBlue@master] Use Skin::afterPortlet

https://gerrit.wikimedia.org/r/604313

Jdlrobson closed this task as Resolved.Jun 11 2020, 10:16 PM

ReleaseTaggerBot added a project: MW-1.35-notes (1.35.0-wmf.37; 2020-06-16).Jun 11 2020, 11:01 PM

Maintenance_bot removed a project: Patch-For-Review.Jun 11 2020, 11:10 PM