Handling failed requests to the federation source Wiki when formatting edit summaries
Closed, ResolvedPublic8 Estimated Story Points
Actions

Assigned To

None

Authored By

	• Samantha_Alipio_WMDE
	Jun 22 2020, 8:37 AM

Description

Currently, any failed request to the source Wiki will result in the target Wikibase entering an error state. This behavior is the case even in non-critical situations such as displaying property labels on the revision history page for an item. Please note when discussing this story that a similar issue exists on the Special:RecentChanges page and diff pages when the federation source wiki is unavailable.

If displaying federated properties is not possible when loading an edit summary due to a failed call to the source Wiki, then we should format the edit summaries differently, displaying only PIDs rather than displaying an error page.

BDD
Given My connection to the source Wiki is unavailable
When I load a revision history page or recent changes page that involves statements with federated properties
Then the page loads without labels for the properties, just linked PIDs.

Note: This should be testable using ModHeader in the test system.

Estimated Remainder
5

Related Objects
Search...

Status	Subtype	Assigned	Task
Resolved		None	T252015 [EPIC] Handling failed requests when federated properties are enabled
Resolved		None	T255972 Handling failed requests to the federation source Wiki when formatting edit summaries
Resolved		hoo	T257217 Catch the FederatedPropertiesException for summary formatting and just show the "linked PIDs" instead in those cases
Resolved	BUG REPORT	Addshore	T258564 Revision history page no longer properly displays federated properties

Event Timeline

• Samantha_Alipio_WMDE created this task.Jun 22 2020, 8:37 AM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptJun 22 2020, 8:37 AM

• Samantha_Alipio_WMDE updated the task description. (Show Details)Jun 22 2020, 8:44 AM

• Samantha_Alipio_WMDE updated the task description. (Show Details)Jun 25 2020, 11:55 AM

• Samantha_Alipio_WMDE moved this task from Ready for story writing to Ready to estimate on the Wikibase - Federated Properties board.

• Samantha_Alipio_WMDE renamed this task from Handling failed requests to the federation source Wiki when loading item history page to Handling failed requests to the federation source Wiki when formatting edit summaries.Jun 25 2020, 12:26 PM

• Samantha_Alipio_WMDE updated the task description. (Show Details)

• Samantha_Alipio_WMDE set the point value for this task to 8.

• Samantha_Alipio_WMDE moved this task from Ready to estimate to Ready for Breakdown on the Wikibase - Federated Properties board.

• Samantha_Alipio_WMDE added a parent task: T252015: [EPIC] Handling failed requests when federated properties are enabled.Jun 26 2020, 11:02 AM

Addshore moved this task from Ready for Breakdown to Prioritized backlog (aka Ready to pick up) on the Wikibase - Federated Properties board.Jul 6 2020, 2:09 PM

hoo edited projects, added Wikibase - Federated Properties (Sprint 3/6 (Hike 2)); removed Wikibase - Federated Properties.Jul 10 2020, 1:42 PM

hoo moved this task from To do to Doing on the Wikibase - Federated Properties (Sprint 3/6 (Hike 2)) board.

Addshore moved this task from Doing to Peer Review on the Wikibase - Federated Properties (Sprint 3/6 (Hike 2)) board.Jul 13 2020, 12:56 PM

Addshore moved this task from Peer Review to Doing on the Wikibase - Federated Properties (Sprint 3/6 (Hike 2)) board.Jul 15 2020, 8:51 AM

hoo moved this task from Doing to Peer Review on the Wikibase - Federated Properties (Sprint 3/6 (Hike 2)) board.Jul 15 2020, 8:34 PM

Addshore added a subtask: T258173: Diff pages throw an exception when the connection to fed props repo is gone.Jul 16 2020, 2:00 PM

Moved this to product verification for now (to get it out of peer review) despite the fact I also just added another sub task.
Perhaps, in that case, it should be hidden from the current sprint for now? ;)

Can't verify the behavior and have moved this back into peer review. Here's what I find:

Revision History page

With modheader off: Revision history pages now display all properties as deleted and linked to a non-existent local page (this is not the expected behavior per resolved story T249836)
With modheader on: the behavior is the same, which does not conform to the BDD

Addshore added a project: Story.Jul 21 2020, 3:03 PM

Rosalie_WMDE moved this task from Peer Review to To do on the Wikibase - Federated Properties (Sprint 3/6 (Hike 2)) board.Jul 21 2020, 4:11 PM

• Samantha_Alipio_WMDE edited projects, added Wikibase - Federated Properties; removed Wikibase - Federated Properties (Sprint 3/6 (Hike 2)).Jul 22 2020, 7:54 AM

• Samantha_Alipio_WMDE moved this task from Sprint 3/6 (Hike 2) to Prioritized backlog (aka Ready to pick up) on the Wikibase - Federated Properties board.

Addshore closed subtask T257217: Catch the FederatedPropertiesException for summary formatting and just show the "linked PIDs" instead in those cases as Resolved.Jul 22 2020, 8:08 AM

• Samantha_Alipio_WMDE updated the task description. (Show Details)Jul 22 2020, 8:29 AM

Addshore removed a subtask: T258173: Diff pages throw an exception when the connection to fed props repo is gone.Jul 22 2020, 8:36 AM

Addshore updated the task description. (Show Details)

Addshore triaged this task as High priority.Jul 22 2020, 8:42 AM

Addshore moved this task from Prioritized backlog (aka Ready to pick up) to Sprint 4/6 (Hike 2) on the Wikibase - Federated Properties board.Jul 22 2020, 8:45 AM

Addshore edited projects, added Wikibase - Federated Properties (Sprint 4/6 (Hike 2)); removed Wikibase - Federated Properties.

Addshore mentioned this in Wikibase - Federated Properties (Sprint 4/6 (Hike 2)).Jul 22 2020, 8:49 AM