Page MenuHomePhabricator

Dropdown menus don't work on Timeless in mobile mode
Closed, ResolvedPublic

Description

In Timeless's "tablet" layout there are multiple dropdown menus at the top of the page. They work fine in desktop mode, but when used with MobileFrontend's mobile mode, they can't be expanded.
This was tested on 1.34 and current master using Chrome 81 and Firefox 68.

image.png (840×1 px, 143 KB)

Steps to Reproduce:

  • Install both MobileFrontend and Timeless.
  • Go to any page on the wiki and append ?useformat=mobile&useskin=timeless to page's adress.
  • Size the window so that tablet mode kicks in (as shown on screenshot above).
  • Try expanding any menu at the top of the page.

Possible cause
Something is broken with Timeless's JS. I'm not sure how this works, but I could resolve the issue by:

  1. Making skins.timeless.mobile depend on skins.timeless.js
  2. Making skins.timeless.js target both desktop and mobile

This is probably wrong, but it does fix the issue.

Event Timeline

Change 645457 had a related patch set uploaded (by Isarra; owner: Isarra):
[mediawiki/skins/Timeless@master] Fix some annoying things

https://gerrit.wikimedia.org/r/645457

Change 645457 merged by jenkins-bot:
[mediawiki/skins/Timeless@master] Fix some annoying things

https://gerrit.wikimedia.org/r/645457

Isarra claimed this task.
Isarra added a subscriber: Isarra.

In theory this should now be resolved (though not deployed anywhere). I haven't actually tested it.