Page MenuHomePhabricator

Make atsmtail-backend.service depend on fifo-log-demux
Closed, ResolvedPublic

Description

@Volans noticed in T256449 that atsmtail-backend spams the logs if it cannot connect to the notpurge socket. We should make atsmtail-backend.service depend on fifo-log-demux.

Event Timeline

Restricted Application added a subscriber: Aklapper. · View Herald Transcript
ema triaged this task as Low priority.Jun 26 2020, 10:29 AM
ema moved this task from Triage to Caching on the Traffic board.

Change 643922 had a related patch set uploaded (by Ema; owner: Ema):
[operations/puppet@production] atsmtail: make systemd unit depend on fifo-log-demux@

https://gerrit.wikimedia.org/r/643922

Change 643934 had a related patch set uploaded (by Ema; owner: Ema):
[operations/puppet@production] Systemd::Servicename: add '@' to Pattern

https://gerrit.wikimedia.org/r/643934

Change 643934 merged by Ema:
[operations/puppet@production] Systemd::Servicename: add '@' to Pattern

https://gerrit.wikimedia.org/r/643934

Change 643922 merged by Ema:
[operations/puppet@production] atsmtail: make systemd unit depend on fifo-log-demux@

https://gerrit.wikimedia.org/r/643922

Mentioned in SAL (#wikimedia-operations) [2020-11-30T10:18:09Z] <ema> cp4031: reboot to test atsmtail/fifo-log-demux service dependencies -- https://gerrit.wikimedia.org/r/c/operations/puppet/+/643922 T256467

ema claimed this task.

Unit ordering at boot time is now correct:

root@cp4031:~# journalctl -u trafficserver-tls.service | grep Started
Nov 30 10:22:11 cp4031 systemd[1]: Started trafficserver-tls.service.
root@cp4031:~# journalctl -u fifo-log-demux@analytics.service | grep Started
Nov 30 10:22:11 cp4031 systemd[1]: Started FIFO log demultiplexer (instance analytics).
root@cp4031:~# journalctl -u atsmtail@tls.service | grep Started
Nov 30 10:22:12 cp4031 systemd[1]: Started mtail instance for Apache Traffic Server tls.

A few Unable to read from socket errors (T256449) are still shown in atsmtail's journal due to the fact that it takes a second for the socket to show up and T268883, but as far as systemd service dependencies are concerned this is now done.