FileRepo: Move File::isLocal() to FileRepo::isLocal()
Closed, ResolvedPublic
Actions

Assigned To

None

Authored By

	Umherirrender
	May 25 2010, 5:53 PM

Description

It is useful to have a isLocal() method in FileRepo, to check easily, if a repo is the local repo.

Version: unspecified
Severity: enhancement

• bzimport raised the priority of this task from to Medium.Nov 21 2014, 11:12 PM

• bzimport set Reference to bz23666.

Created attachment 7406
patch to move isLocal from File to FileRepo

Thanks.

attachment bug23666.patch ignored as obsolete

What's the use case for this? Where would you have a FileRepo object that you need to know local/non-local, but you're not already using some file?

The method FileRepo::getDisplayName() can use this method.

With this method in FileRepo there is only one check of 'local' and not two hardcoded strings.

Created attachment 7407
patch-2: add missing null check

Attached:

bug23666-2.patch1 KBDownload

Bryan.TongMinh wrote:

Fixed in r68235.

• Gilles moved this task from Untriaged to Done on the Multimedia board.

	F6984: bug23666-2.patch
	Nov 21 2014, 11:12 PM