Page MenuHomePhabricator
Create Task
Maniphest T256756

Remove $wgWBRepoDataTypes and $wgWBClientDataTypes global variables
Closed, ResolvedPublic
Actions

Description

Instead, load the data types files directly in WikibaseRepo or WikibaseClient, similar to how entity types are loaded since rEWBA93557f43aaff: Entity types are not in global scope anymore.

Details

SubjectRepoBranchLines +/-
Remove $wgWBRepoDataTypes and $wgWBClientDataTypesmediawiki/extensions/Wikibasemaster+60 -95
Remove mentions of Wikibase data/entity type globalsmediawiki/extensions/WikibaseLexememaster+2 -2
Customize query in gerrit

Related Objects
Search...

View Standalone Graph
This task is connected to more than 200 other tasks. Only direct parents and subtasks are shown here. Use View Standalone Graph to show more of the graph.
StatusSubtypeAssignedTask
· · ·
ResolvedLucas_Werkmeister_WMDET256252 Migrate wgWBClientDataTypes + wgWBClientSettings loading out of Client PHP entry point
ResolvedLucas_Werkmeister_WMDET256756 Remove $wgWBRepoDataTypes and $wgWBClientDataTypes global variables
· · ·

Event Timeline

Lucas_Werkmeister_WMDE created this task.Jun 30 2020, 1:22 PM
Lucas_Werkmeister_WMDE moved this task from Backlog to Doing on the Wikibase Extension Decoupling and Registration (Sprint 2) board.
Lucas_Werkmeister_WMDE mentioned this in T256252: Migrate wgWBClientDataTypes + wgWBClientSettings loading out of Client PHP entry point.
gerritbot added a comment.Jun 30 2020, 2:21 PM

Change 608632 had a related patch set uploaded (by Lucas Werkmeister (WMDE); owner: Lucas Werkmeister (WMDE)):
[mediawiki/extensions/Wikibase@master] Remove $wgWBRepoDataTypes and $wgWBClientDataTypes

https://gerrit.wikimedia.org/r/c/mediawiki/extensions/Wikibase/ /608632

gerritbot added a project: Patch-For-Review.Jun 30 2020, 2:21 PM
gerritbot added a comment.Jun 30 2020, 2:25 PM

Change 608634 had a related patch set uploaded (by Lucas Werkmeister (WMDE); owner: Lucas Werkmeister (WMDE)):
[mediawiki/extensions/WikibaseLexeme@master] Remove mentions of Wikibase data/entity type globals

https://gerrit.wikimedia.org/r/c/mediawiki/extensions/WikibaseLexeme/ /608634

Lucas_Werkmeister_WMDE moved this task from Doing to Peer Review on the Wikibase Extension Decoupling and Registration (Sprint 2) board.Jun 30 2020, 2:26 PM
gerritbot added a comment.Jun 30 2020, 11:33 PM

Change 608634 merged by jenkins-bot:
[mediawiki/extensions/WikibaseLexeme@master] Remove mentions of Wikibase data/entity type globals

https://gerrit.wikimedia.org/r/c/mediawiki/extensions/WikibaseLexeme/ /608634

ReleaseTaggerBot added a project: MW-1.35-notes (1.35.0-wmf.40; 2020-07-07).Jul 1 2020, 12:00 AM
gerritbot added a comment.Jul 1 2020, 9:53 PM

Change 608632 merged by jenkins-bot:
[mediawiki/extensions/Wikibase@master] Remove $wgWBRepoDataTypes and $wgWBClientDataTypes

https://gerrit.wikimedia.org/r/c/mediawiki/extensions/Wikibase/ /608632

Maintenance_bot removed a project: Patch-For-Review.Jul 1 2020, 10:10 PM
Ladsgroup moved this task from Peer Review to Verification on the Wikibase Extension Decoupling and Registration (Sprint 2) board.Jul 1 2020, 10:18 PM
Lucas_Werkmeister_WMDE closed this task as Resolved.Jul 2 2020, 9:27 AM
Lucas_Werkmeister_WMDE moved this task from Verification to Done on the Wikibase Extension Decoupling and Registration (Sprint 2) board.
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits