Page MenuHomePhabricator
Create Task
Maniphest T256911

Translate patches failing on mwext-php72-phan-docker
Closed, ResolvedPublic
Actions

Description

Example: https://gerrit.wikimedia.org/r/c/mediawiki/extensions/Translate/+/608825 -> https://integration.wikimedia.org/ci/job/mwext-php72-phan-docker/61377/console

21:39:38 <?xml version="1.0" encoding="ISO-8859-15"?>
21:39:38 <checkstyle version="6.5">
21:39:38   <file name="tag/SpecialPageTranslation.php">
21:39:38     <error line="886" severity="error" message="Call to undeclared method \MediaWiki\Revision\RevisionRecord::getRevisionRecord" source="PhanUndeclaredMethod"/>
21:39:38   </file>
21:39:38 </checkstyle>

I do not know if there is a way to get more info.

Details

SubjectRepoBranchLines +/-
Fix phan confusion in SpecialPageTranslationmediawiki/extensions/Translatemaster+5 -1
Customize query in gerrit

Event Timeline

Nikerabbit created this task.Jul 1 2020, 7:03 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptJul 1 2020, 7:03 PM
gerritbot added a comment.Jul 1 2020, 8:28 PM

Change 608841 had a related patch set uploaded (by DannyS712; owner: DannyS712):
[mediawiki/extensions/Translate@master] Fix phan confusion in SpecialPageTranslation

https://gerrit.wikimedia.org/r/c/mediawiki/extensions/Translate/ /608841

gerritbot added a project: Patch-For-Review.Jul 1 2020, 8:28 PM
DannyS712 claimed this task.Jul 1 2020, 8:34 PM
DannyS712 added a project: ci-test-error (WMF-deployed Build Failure).

This is actually a false positive - the actual method called is Revision::getRevisionRecord; I've sent a patch to make this clearer to phan

Restricted Application added a project: User-DannyS712. · View Herald TranscriptJul 1 2020, 8:34 PM
DannyS712 moved this task from Unsorted to Awaiting review and deployment on the User-DannyS712 board.Jul 1 2020, 8:35 PM
gerritbot added a comment.Jul 2 2020, 6:55 AM

Change 608841 merged by jenkins-bot:
[mediawiki/extensions/Translate@master] Fix phan confusion in SpecialPageTranslation

https://gerrit.wikimedia.org/r/c/mediawiki/extensions/Translate/ /608841

ReleaseTaggerBot added a project: MW-1.35-notes (1.35.0-wmf.40; 2020-07-07).Jul 2 2020, 7:00 AM
DannyS712 removed a project: Patch-For-Review.Jul 2 2020, 7:07 AM

@Nikerabbit is it working now?

Nikerabbit added a comment.Jul 2 2020, 7:13 AM

I just rebased a dozen of patches: https://integration.wikimedia.org/zuul/

Should know soon if at least some of them pass tests.

abi_ subscribed.Jul 2 2020, 7:44 AM

@DannyS712 - Works now: https://gerrit.wikimedia.org/r/c/mediawiki/extensions/Translate/+/608602

DannyS712 closed this task as Resolved.Jul 2 2020, 7:52 AM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL