Page MenuHomePhabricator

Translate patches failing on mwext-php72-phan-docker
Closed, ResolvedPublic

Description

Example: https://gerrit.wikimedia.org/r/c/mediawiki/extensions/Translate/+/608825 -> https://integration.wikimedia.org/ci/job/mwext-php72-phan-docker/61377/console

21:39:38 <?xml version="1.0" encoding="ISO-8859-15"?>
21:39:38 <checkstyle version="6.5">
21:39:38   <file name="tag/SpecialPageTranslation.php">
21:39:38     <error line="886" severity="error" message="Call to undeclared method \MediaWiki\Revision\RevisionRecord::getRevisionRecord" source="PhanUndeclaredMethod"/>
21:39:38   </file>
21:39:38 </checkstyle>

I do not know if there is a way to get more info.

Event Timeline

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptJul 1 2020, 7:03 PM

Change 608841 had a related patch set uploaded (by DannyS712; owner: DannyS712):
[mediawiki/extensions/Translate@master] Fix phan confusion in SpecialPageTranslation

https://gerrit.wikimedia.org/r/c/mediawiki/extensions/Translate/ /608841

DannyS712 claimed this task.Jul 1 2020, 8:34 PM

This is actually a false positive - the actual method called is Revision::getRevisionRecord; I've sent a patch to make this clearer to phan

Restricted Application added a project: User-DannyS712. · View Herald TranscriptJul 1 2020, 8:34 PM

Change 608841 merged by jenkins-bot:
[mediawiki/extensions/Translate@master] Fix phan confusion in SpecialPageTranslation

https://gerrit.wikimedia.org/r/c/mediawiki/extensions/Translate/ /608841

I just rebased a dozen of patches: https://integration.wikimedia.org/zuul/

Should know soon if at least some of them pass tests.

DannyS712 closed this task as Resolved.Jul 2 2020, 7:52 AM