Page MenuHomePhabricator

Username suggestions from API not showing until second update
Closed, ResolvedPublic

Description

One more hint would be to show more users. It seems to me the logic does not lists users, that will appear later when I type more characters. An example to demonstrate what I mean:

  1. I type @p -> the list shows only 2 users: PauTest, PPelberg-test
  2. @pp -> PPelberg-test
  3. @ppp -> Ppppowerup
  4. I delete that last character, @pp -> PPelberg-test, Ppppowerup

I'd expect Ppppowerup or another name with "pp" in it to show up for ˙@pp` and possibly @p initially too, not just after backspace-ing.

Expected behaviour:
Typing @p should show a list of "local" users beginning with 'p', followed by results from the API ("local" being users who have commented in the thread).

Event Timeline

Esanders created this task.Jul 2 2020, 2:11 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptJul 2 2020, 2:11 PM
Esanders updated the task description. (Show Details)Jul 2 2020, 2:15 PM

Change 609163 had a related patch set uploaded (by Esanders; owner: Esanders):
[mediawiki/extensions/DiscussionTools@master] Wait for API response before updating suggestion list

https://gerrit.wikimedia.org/r/c/mediawiki/extensions/DiscussionTools/ /609163

Change 609163 merged by jenkins-bot:
[mediawiki/extensions/DiscussionTools@master] Wait for API response before updating suggestion list

https://gerrit.wikimedia.org/r/c/mediawiki/extensions/DiscussionTools/ /609163

@Esanders thank you for picking up this report and fixing it!

JTannerWMF closed this task as Resolved.Jul 22 2020, 5:18 PM