Page MenuHomePhabricator
Create Task
Maniphest T257279

Standardize 'mediawiki.ui' variables to CSS variables naming scheme in preparation for WikimediaUI Base variables takeover
Closed, ResolvedPublic2 Estimated Story Points
Actions

Description

As of current, MW core's deprecated mediawiki.ui variables rely on a mix of variables that don't follow the CSS naming scheme guidelines.

While we're moving forward to rely on a standardized set of variables to enable using general variables with an override/call of WikimediaUI Base variables for Wikimedia projects to be relied on,

  • it's necessary to deprecate mediawiki.ui's variables and
  • rename the remaining variables to new naming scheme resulting in equal variables like in WikimediaUI Base in a go

This task is limited to MediaWiki core. Skins and extensions are targeted in separate tasks.

Details

Show related patches Customize query in gerrit

Related Objects

Event Timeline

Volker_E created this task.Jul 7 2020, 12:15 AM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptJul 7 2020, 12:15 AM
Volker_E renamed this task from Standardize to Standardize 'mediawiki.ui' variables to CSS variables naming scheme in preparation for WikimediaUI Base variables takeover.Jul 7 2020, 12:22 AM
Volker_E added projects: CSS, MediaWiki-Core-Skin-Architecture, MediaWiki-General, Web-Team-Backlog (Kanbanana-2019-20-Q4).
Volker_E updated the task description. (Show Details)
gerritbot added a comment.Jul 9 2020, 12:31 AM

Change 610438 had a related patch set uploaded (by VolkerE; owner: VolkerE):
[mediawiki/core@master] mediawiki.ui: Deprecate all '@colorButton*' and @colorDisabledText variables

https://gerrit.wikimedia.org/r/610438

gerritbot added a project: Patch-For-Review.Jul 9 2020, 12:31 AM
gerritbot added a comment.Jul 9 2020, 6:01 AM

Change 610601 had a related patch set uploaded (by VolkerE; owner: VolkerE):
[mediawiki/core@master] mediawiki.ui: Deprecate @sizeInputBinary and replace with @size-input-binary

https://gerrit.wikimedia.org/r/610601

gerritbot added a comment.Jul 9 2020, 7:16 AM

Change 610688 had a related patch set uploaded (by VolkerE; owner: VolkerE):
[mediawiki/core@master] mediawiki.ui: Deprecate *InputBinary* variables

https://gerrit.wikimedia.org/r/610688

MBinder_WMF edited projects, added Web-Team-Backlog (Kanbanana-FY-2020-21); removed Web-Team-Backlog (Kanbanana-2019-20-Q4).Jul 9 2020, 5:22 PM
gerritbot added a comment.Jul 9 2020, 7:23 PM

Change 610438 merged by jenkins-bot:
[mediawiki/core@master] mediawiki.ui: Deprecate all '@colorButton*' and @colorDisabledText variables

https://gerrit.wikimedia.org/r/610438

ReleaseTaggerBot added a project: MW-1.35-notes (1.35.0-wmf.41; 2020-07-14).Jul 9 2020, 8:00 PM
gerritbot added a comment.Jul 9 2020, 8:47 PM

Change 610601 merged by jenkins-bot:
[mediawiki/core@master] mediawiki.ui: Deprecate @sizeInputBinary and replace with @size-input-binary

https://gerrit.wikimedia.org/r/610601

Jdlrobson moved this task from Backlog to It's complicated on the MediaWiki-Core-Skin-Architecture board.Jul 9 2020, 9:30 PM
gerritbot added a comment.Jul 9 2020, 9:52 PM

Change 610688 merged by jenkins-bot:
[mediawiki/core@master] mediawiki.ui: Deprecate *InputBinary* variables

https://gerrit.wikimedia.org/r/610688

gerritbot added a comment.Jul 9 2020, 10:08 PM

Change 610937 had a related patch set uploaded (by VolkerE; owner: VolkerE):
[mediawiki/core@master] mediawiki.ui: Deprecate @colorShadow

https://gerrit.wikimedia.org/r/610937

gerritbot added a comment.Jul 9 2020, 10:17 PM

Change 610939 had a related patch set uploaded (by VolkerE; owner: VolkerE):
[mediawiki/core@master] mediawiki.ui: Deprecate @borderWidthRadioChecked var and replace it

https://gerrit.wikimedia.org/r/610939

gerritbot added a comment.Jul 9 2020, 10:50 PM

Change 610937 merged by jenkins-bot:
[mediawiki/core@master] mediawiki.ui: Deprecate @colorShadow

https://gerrit.wikimedia.org/r/610937

gerritbot added a comment.Jul 9 2020, 10:50 PM

Change 610939 merged by jenkins-bot:
[mediawiki/core@master] mediawiki.ui: Deprecate @borderWidthRadioChecked var and replace it

https://gerrit.wikimedia.org/r/610939

gerritbot added a comment.Jul 10 2020, 1:53 AM

Change 611013 had a related patch set uploaded (by VolkerE; owner: VolkerE):
[mediawiki/core@master] mediawiki.ui: Deprecate @icon* vars and replace them

https://gerrit.wikimedia.org/r/611013

gerritbot added a comment.Jul 10 2020, 5:45 AM

Change 611091 had a related patch set uploaded (by VolkerE; owner: VolkerE):
[mediawiki/core@master] mediawiki.ui: Deprecate @colorRegressive

https://gerrit.wikimedia.org/r/611091

gerritbot added a comment.Jul 10 2020, 6:36 PM

Change 611013 merged by jenkins-bot:
[mediawiki/core@master] mediawiki.ui: Deprecate @icon* vars and replace them

https://gerrit.wikimedia.org/r/611013

gerritbot added a comment.Jul 10 2020, 7:25 PM

Change 611414 had a related patch set uploaded (by VolkerE; owner: VolkerE):
[mediawiki/core@master] mediawiki.ui: Deprecate @boxShadow* variables

https://gerrit.wikimedia.org/r/611414

Jdlrobson moved this task from Needs Analysis to Doing on the Web-Team-Backlog (Kanbanana-FY-2020-21) board.Jul 10 2020, 9:26 PM
Jdlrobson mentioned this in T256373: New logo overlaps with the top menu (personal menu) in portrait mode.Jul 10 2020, 9:40 PM
gerritbot added a comment.Jul 10 2020, 9:47 PM

Change 611414 merged by jenkins-bot:
[mediawiki/core@master] mediawiki.ui: Deprecate @boxShadow* variables

https://gerrit.wikimedia.org/r/611414

gerritbot added a comment.Jul 10 2020, 9:47 PM

Change 611091 merged by jenkins-bot:
[mediawiki/core@master] mediawiki.ui: Deprecate @colorRegressive

https://gerrit.wikimedia.org/r/611091

gerritbot added a comment.Jul 11 2020, 11:03 PM

Change 611865 had a related patch set uploaded (by VolkerE; owner: VolkerE):
[mediawiki/core@master] mediawiki.ui: Deprecate @colorProgressive & @colorDestructive* variables

https://gerrit.wikimedia.org/r/611865

gerritbot added a comment.Jul 13 2020, 2:37 AM

Change 611954 had a related patch set uploaded (by VolkerE; owner: VolkerE):
[mediawiki/core@master] mediawiki.ui: Deprecate message (boxes) related variables

https://gerrit.wikimedia.org/r/611954

gerritbot added a comment.Jul 13 2020, 4:45 AM

Change 611956 had a related patch set uploaded (by VolkerE; owner: VolkerE):
[mediawiki/core@master] mediawiki.ui: Deprecate @colorMediumSevere & colorLowSevere vars

https://gerrit.wikimedia.org/r/611956

ovasileva triaged this task as Medium priority.Jul 13 2020, 10:13 AM
Volker_E moved this task from Doing to Code Review on the Web-Team-Backlog (Kanbanana-FY-2020-21) board.Jul 13 2020, 5:16 PM
Jdlrobson assigned this task to Volker_E.Jul 13 2020, 5:16 PM
gerritbot added a comment.Jul 13 2020, 11:14 PM

Change 611865 merged by jenkins-bot:
[mediawiki/core@master] mediawiki.ui: Deprecate @colorProgressive* & @colorDestructive* variables

https://gerrit.wikimedia.org/r/611865

gerritbot added a comment.Jul 14 2020, 12:30 AM

Change 611954 merged by jenkins-bot:
[mediawiki/core@master] mediawiki.ui: Deprecate message (boxes) related variables

https://gerrit.wikimedia.org/r/611954

gerritbot added a comment.Jul 14 2020, 1:47 AM

Change 611956 merged by jenkins-bot:
[mediawiki/core@master] mediawiki.ui: Deprecate @colorMediumSevere & @colorLowSevere vars

https://gerrit.wikimedia.org/r/611956

ReleaseTaggerBot added a project: MW-1.36-notes (1.36.0-wmf.1; 2020-07-21).Jul 14 2020, 2:00 AM
Jdlrobson moved this task from Code Review to Ready for Signoff on the Web-Team-Backlog (Kanbanana-FY-2020-21) board.Jul 14 2020, 5:08 PM
Volker_E removed a project: Patch-For-Review.Jul 14 2020, 10:22 PM
Jdlrobson claimed this task.Jul 15 2020, 12:09 AM
Jdlrobson subscribed.

i can sign off

Jdlrobson moved this task from Ready for Signoff to Needs More Work on the Web-Team-Backlog (Kanbanana-FY-2020-21) board.Jul 28 2020, 12:39 AM

The gray colors do not seem to meet the standardized names and do not appear to be deprecated in 1.35. Was this intentional? If not should this be addressed and backported?

(@colorGray1..15)

Volker_E added a comment.Jul 28 2020, 6:14 PM

@Jdlrobson The comment states for several months, and in time for MW 1.35, that those colors are only for reference and will be replaced.
The only thing that might be disputed here, is to not have the term “deprecated” in this comment. I think that's debatable and possible neglibe, as CSS/Less is more of a social contract then a technical contract on its deprecation policy.

Volker_E updated the task description. (Show Details)Jul 28 2020, 6:18 PM
Jdlrobson added a comment.Jul 28 2020, 6:38 PM

@Volker_E it was a little unclear, but I agree reading the comments more closely it should be clear that they are not to be used. I think at minimum I would however recommend adding a note about the deprecated LESS variables in the 1.35 release notes out of courtesy to 3rd parties with a timeline for their eventual removal so 3rd parties know to look at the file in the first place.

Volker_E added a comment.Jul 28 2020, 6:40 PM

@Jdlrobson Are you aiming at a backported addition to RELEASE-NOTES-1.35?

Jdlrobson added a comment.Jul 28 2020, 7:48 PM

That's my suggestion. That way nobody can accuse you of not going through the normal deprecation channels.

MBinder_WMF set the point value for this task to 2.Jul 29 2020, 5:18 PM
Jdlrobson reassigned this task from Jdlrobson to Volker_E.Aug 3 2020, 5:17 PM
gerritbot added a comment.Aug 3 2020, 5:45 PM

Change 618111 had a related patch set uploaded (by VolkerE; owner: VolkerE):
[mediawiki/core@master] Add mediawiki.ui Less variable deprecation note

https://gerrit.wikimedia.org/r/618111

gerritbot added a project: Patch-For-Review.Aug 3 2020, 5:45 PM
gerritbot added a comment.Aug 3 2020, 5:50 PM

Change 618036 had a related patch set uploaded (by VolkerE; owner: VolkerE):
[mediawiki/core@REL1_35] Add mediawiki.ui Less variable deprecation note

https://gerrit.wikimedia.org/r/618036

Jdlrobson moved this task from Needs More Work to Ready for Signoff on the Web-Team-Backlog (Kanbanana-FY-2020-21) board.Aug 4 2020, 5:59 PM
gerritbot added a comment.Aug 4 2020, 6:08 PM

Change 618111 merged by jenkins-bot:
[mediawiki/core@master] Add mediawiki.ui Less variable deprecation note

https://gerrit.wikimedia.org/r/618111

gerritbot added a comment.Aug 4 2020, 6:17 PM

Change 618036 merged by jenkins-bot:
[mediawiki/core@REL1_35] Add mediawiki.ui Less variable deprecation note

https://gerrit.wikimedia.org/r/618036

ReleaseTaggerBot edited projects, added MW-1.35-notes, MW-1.36-notes (1.36.0-wmf.4; 2020-08-11); removed MW-1.36-notes (1.36.0-wmf.1; 2020-07-21), MW-1.35-notes (1.35.0-wmf.41; 2020-07-14).Aug 4 2020, 7:00 PM
Jdlrobson closed this task as Resolved.Aug 5 2020, 5:08 PM
Volker_E reassigned this task from Volker_E to Jdlrobson.Aug 5 2020, 5:08 PM
Volker_E removed a project: Patch-For-Review.
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits