Page MenuHomePhabricator

Unknown module: util.inherit on client wikis in Beta
Closed, ResolvedPublic

Description

On Beta (example article), the “Add links” sidebar portlet fails with “An unknown error occurred.” WikibaseClient only produces this message in one place, as the failure case for an mw.loader.using call:

wikibase.client.linkitem.init.js
mw.loader.using(
	[
		'jquery.wikibase.linkitem',
		'mediawiki.Title',
		'mw.config.values.wbRepo'
	],
	function () {
		// ...
	},
	function () {
		// Failure: This isn't very likely, but who knows
		$spinner.remove();
		$linkItemLink.show();
		mw.notify( mw.msg( 'unknown-error' ) );
	}
);

This doesn’t show any error details, but we can reveal them with a similar function call in dev tools:

mw.loader.using(
	[
		'jquery.wikibase.linkitem',
		'mediawiki.Title',
		'mw.config.values.wbRepo'
	],
	console.log,
	console.error
);

And this prints:

Error: "Unknown module: util.inherit"

Event Timeline

We moved the util.inherit module to View in Icad3c338cf (for T256054, T257452), but it’s still referenced in Lib:

Resources.php
'wikibase.api.RepoApi' => $wikibaseApiPaths + [
	// ...
	'dependencies' => [
		'mediawiki.api',
		'mediawiki.ForeignApi',
		'util.inherit',
	],
	// ...
],
LibHooks.php
'wikibase.Site' => $moduleTemplate + [
	'scripts' => [
		'resources/wikibase.Site.js',
	],
	'dependencies' => [
		'mediawiki.util',
		'util.inherit',
		'wikibase',
	],
],

We need to fix this.

Change 612380 had a related patch set uploaded (by Ladsgroup; owner: Ladsgroup):
[mediawiki/extensions/Wikibase@master] Remove util.inherit from dependencies of wikibase.Site

https://gerrit.wikimedia.org/r/612380

Change 612382 had a related patch set uploaded (by Ladsgroup; owner: Ladsgroup):
[wikibase/javascript-api@master] Avoid using util.inherit

https://gerrit.wikimedia.org/r/612382

Change 612382 merged by jenkins-bot:
[wikibase/javascript-api@master] Avoid using util.inherit

https://gerrit.wikimedia.org/r/612382

Change 612387 had a related patch set uploaded (by Ladsgroup; owner: Ladsgroup):
[mediawiki/extensions/Wikibase@master] Bump wikibase-api to HEAD

https://gerrit.wikimedia.org/r/612387

Change 612380 merged by jenkins-bot:
[mediawiki/extensions/Wikibase@master] Remove util.inherit from dependencies of wikibase.Site

https://gerrit.wikimedia.org/r/612380

Change 612387 merged by jenkins-bot:
[mediawiki/extensions/Wikibase@master] Bump wikibase-api to HEAD

https://gerrit.wikimedia.org/r/612387