Page MenuHomePhabricator
Create Task
Maniphest T256054

Copy dependencies of "jquery.wikibase.linkitem" Resource Loader module to Wikibase client JS code
Closed, ResolvedPublic
Actions

Description

As a Wikibase Client JS developer I want quickly make jquery.wikibase.linkitem independent from modules outside of Wikibase client, in order to be able to change it freely without loading non-client modules.

Following on the finding of T255115, as an intermediate step "jquery.wikibase.linkitem" is to be made independent from Resource Loader modules defined outside of Wikibase client by copying over its dependencies to client directory, and making the said modules depend on those copies.

Dependencies:

Direct ResourceLoader Modules

//...

'dependencies' => [
    'jquery.spinner', // Not in Wikibase
    'jquery.ui', // Not in wikibase
    'jquery.ui.suggester', // WikibaseLib
    'jquery.wikibase.siteselector', // WikibaseLib
    'jquery.wikibase.wbtooltip', // WikibaseLib
    'mediawiki.api', // Not in wikibase
    'mediawiki.util', // Not in wikibase
    'mediawiki.jqueryMsg', // Not in wikibase
    'jquery.event.special.eachchange', // WikibaseLib
    'wikibase.sites', // WikibaseLib
    'wikibase.api.RepoApi', // WikibaseLib
]

//...

jQuery Widgets

Direct usage:

  • wikibase.siteselector
  • wikibase.wbtooltip
  • ui.suggester

Transitive Usage:

  • ui.ooMenu

Global Variables

  • wikibase.sites <-- Defined in WikibaseLib
  • wikibase.api <-- Defined in WikibaseLib

Copies are to not be prevented from possibly diverging from their source files.

Acceptance criteria:

  • jquery.wikibase.linkitem only depends on modules defined and containing files from the wikbase client part

Details

Show related patches Customize query in gerrit

Related Objects
Search...

Event Timeline

There are a very large number of changes, so older changes are hidden. Show Older Changes
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptJun 22 2020, 8:28 PM
ItamarWMDE updated the task description. (Show Details)Jun 23 2020, 2:22 PM
Lucas_Werkmeister_WMDE moved this task from Backlog to Backlog (prioritised) on the Wikibase Extension Decoupling and Registration board.Jun 24 2020, 10:56 AM
Ladsgroup claimed this task.Jul 3 2020, 12:33 AM
Ladsgroup edited projects, added Wikibase Extension Decoupling and Registration (Sprint 2); removed Wikibase Extension Decoupling and Registration.
Restricted Application added a project: User-Ladsgroup. · View Herald TranscriptJul 3 2020, 12:33 AM
Ladsgroup moved this task from Backlog to Doing on the Wikibase Extension Decoupling and Registration (Sprint 2) board.Jul 3 2020, 12:33 AM
gerritbot added a comment.Jul 3 2020, 1:09 AM

Change 609275 had a related patch set uploaded (by Ladsgroup; owner: Ladsgroup):
[mediawiki/extensions/Wikibase@master] Make linkitem module use packageFiles instead of scripts

https://gerrit.wikimedia.org/r/609275

gerritbot added a project: Patch-For-Review.Jul 3 2020, 1:09 AM
gerritbot added a comment.Jul 3 2020, 12:12 PM

Change 609416 had a related patch set uploaded (by Ladsgroup; owner: Ladsgroup):
[mediawiki/extensions/Wikibase@master] Decouple wikibase.sites RL modules between repo and client

https://gerrit.wikimedia.org/r/609416

Ladsgroup moved this task from Doing to Peer Review on the Wikibase Extension Decoupling and Registration (Sprint 2) board.Jul 3 2020, 12:37 PM
Ladsgroup removed Ladsgroup as the assignee of this task.Jul 3 2020, 1:58 PM
Ladsgroup moved this task from Peer Review to Backlog on the Wikibase Extension Decoupling and Registration (Sprint 2) board.

I give up on this for now, everything is entangled :((

Ladsgroup claimed this task.Jul 6 2020, 2:12 PM
Ladsgroup moved this task from Backlog to Doing on the Wikibase Extension Decoupling and Registration (Sprint 2) board.

Cleaning up the code a bit before moving them around.

gerritbot added a comment.Jul 6 2020, 2:50 PM

Change 609793 had a related patch set uploaded (by Ladsgroup; owner: Ladsgroup):
[mediawiki/extensions/Wikibase@master] Bump wikibase-api and wikibase-data-model

https://gerrit.wikimedia.org/r/609793

gerritbot added a comment.Jul 6 2020, 4:39 PM

Change 609807 had a related patch set uploaded (by Ladsgroup; owner: Ladsgroup):
[mediawiki/extensions/Wikibase@master] [WIP] Decouple eachchange.js

https://gerrit.wikimedia.org/r/609807

Ladsgroup moved this task from Doing to Verification on the Wikibase Extension Decoupling and Registration (Sprint 2) board.Jul 6 2020, 6:07 PM
Ladsgroup moved this task from Verification to Peer Review on the Wikibase Extension Decoupling and Registration (Sprint 2) board.
gerritbot added a comment.Jul 6 2020, 6:37 PM

Change 609793 merged by jenkins-bot:
[mediawiki/extensions/Wikibase@master] Bump wikibase-api and wikibase-data-model

https://gerrit.wikimedia.org/r/609793

gerritbot added a comment.Jul 6 2020, 6:58 PM

Change 609836 had a related patch set uploaded (by Ladsgroup; owner: Ladsgroup):
[data-values/value-view@master] Remove unused code

https://gerrit.wikimedia.org/r/609836

ReleaseTaggerBot added a project: MW-1.35-notes (1.35.0-wmf.40; 2020-07-07).Jul 6 2020, 7:00 PM
Ladsgroup added a comment.Jul 6 2020, 7:40 PM

https://github.com/wmde/DataValuesJavaScript/pull/134

gerritbot added a comment.Jul 7 2020, 8:33 AM

Change 609836 merged by jenkins-bot:
[data-values/value-view@master] Remove unused code

https://gerrit.wikimedia.org/r/609836

gerritbot added a comment.Jul 7 2020, 4:19 PM

Change 610110 had a related patch set uploaded (by Ladsgroup; owner: Ladsgroup):
[mediawiki/extensions/Wikibase@master] Bump wikibase-data-values-value-view to HEAD

https://gerrit.wikimedia.org/r/610110

gerritbot added a comment.Jul 8 2020, 10:19 AM

Change 609275 merged by jenkins-bot:
[mediawiki/extensions/Wikibase@master] Make linkitem module use packageFiles instead of scripts

https://gerrit.wikimedia.org/r/609275

gerritbot added a comment.Jul 8 2020, 10:21 AM

Change 610110 merged by jenkins-bot:
[mediawiki/extensions/Wikibase@master] Bump value view and data values libs to HEAD

https://gerrit.wikimedia.org/r/610110

ReleaseTaggerBot edited projects, added MW-1.35-notes (1.35.0-wmf.41; 2020-07-14); removed MW-1.35-notes (1.35.0-wmf.40; 2020-07-07).Jul 8 2020, 11:00 AM
Ladsgroup edited projects, added Wikibase Extension Decoupling and Registration (Sprint 3); removed Wikibase Extension Decoupling and Registration (Sprint 2).Jul 8 2020, 12:22 PM
gerritbot added a comment.Jul 8 2020, 12:29 PM

Change 609416 merged by jenkins-bot:
[mediawiki/extensions/Wikibase@master] Decouple wikibase.sites RL modules between repo and client

https://gerrit.wikimedia.org/r/609416

Tarrow moved this task from Backlog to Peer Review on the Wikibase Extension Decoupling and Registration (Sprint 3) board.Jul 8 2020, 1:00 PM
Tarrow moved this task from Peer Review to Doing on the Wikibase Extension Decoupling and Registration (Sprint 3) board.
gerritbot added a comment.Jul 9 2020, 6:32 PM

Change 610898 had a related patch set uploaded (by Ladsgroup; owner: Ladsgroup):
[mediawiki/extensions/Wikibase@master] Decouple jquery.event.special.eachchange and util.inherit

https://gerrit.wikimedia.org/r/610898

Restricted Application added a project: Wikidata. · View Herald TranscriptJul 9 2020, 6:32 PM
gerritbot added a comment.Jul 9 2020, 6:56 PM

Change 609807 abandoned by Ladsgroup:
[mediawiki/extensions/Wikibase@master] Decouple eachchange.js

Reason:
Done in Icad3c338cf

https://gerrit.wikimedia.org/r/609807

gerritbot added a comment.Jul 9 2020, 7:03 PM

Change 610903 had a related patch set uploaded (by Ladsgroup; owner: Ladsgroup):
[mediawiki/extensions/Wikibase@master] Clean up qunit tests in lib

https://gerrit.wikimedia.org/r/610903

Ladsgroup moved this task from Doing to Peer Review on the Wikibase Extension Decoupling and Registration (Sprint 3) board.Jul 9 2020, 7:07 PM
gerritbot added a comment.Jul 10 2020, 10:35 AM

Change 610903 merged by jenkins-bot:
[mediawiki/extensions/Wikibase@master] Clean up qunit tests in lib

https://gerrit.wikimedia.org/r/610903

Ladsgroup moved this task from Peer Review to Verification on the Wikibase Extension Decoupling and Registration (Sprint 3) board.Jul 10 2020, 7:46 PM
gerritbot added a comment.Jul 10 2020, 7:55 PM

Change 611415 had a related patch set uploaded (by Ladsgroup; owner: Ladsgroup):
[mediawiki/extensions/Wikibase@master] Fix use of wb.sites in PageConnector

https://gerrit.wikimedia.org/r/611415

gerritbot added a comment.Jul 11 2020, 11:26 AM

Change 611415 merged by jenkins-bot:
[mediawiki/extensions/Wikibase@master] Fix use of wb.sites in PageConnector

https://gerrit.wikimedia.org/r/611415

gerritbot added a comment.Jul 13 2020, 9:49 AM

Change 610898 merged by jenkins-bot:
[mediawiki/extensions/Wikibase@master] Decouple jquery.event.special.eachchange and util.inherit

https://gerrit.wikimedia.org/r/610898

Lucas_Werkmeister_WMDE closed subtask T257454: Decouple jquery.wikibase.wbtooltip RL module from client and repo as Resolved.Jul 13 2020, 4:13 PM
Lucas_Werkmeister_WMDE closed subtask T257457: Decouple wikibase.buildErrorOutput RL module from client and repo as Resolved.
Lucas_Werkmeister_WMDE closed this task as Resolved.Jul 13 2020, 4:26 PM
Lucas_Werkmeister_WMDE mentioned this in T257857: Unknown module: util.inherit on client wikis in Beta.
Lucas_Werkmeister_WMDE moved this task from Verification to Done on the Wikibase Extension Decoupling and Registration (Sprint 3) board.
Lucas_Werkmeister_WMDE reopened this task as Open.Jul 13 2020, 4:28 PM
Lucas_Werkmeister_WMDE closed subtask T257452: Decouple jquery.event.special.eachchange RL module from client and repo as Resolved.
Lucas_Werkmeister_WMDE moved this task from Done to Verification on the Wikibase Extension Decoupling and Registration (Sprint 3) board.

Wait, I’m not sure if this task is done, I thought this was one of the subtasks.

gerritbot added a comment.Jul 13 2020, 7:07 PM

Change 612401 had a related patch set uploaded (by Ladsgroup; owner: Ladsgroup):
[mediawiki/extensions/Wikibase@master] Move wikibase.api.ValueCaller RL module from lib to view

https://gerrit.wikimedia.org/r/612401

Ladsgroup moved this task from Verification to Peer Review on the Wikibase Extension Decoupling and Registration (Sprint 3) board.Jul 13 2020, 7:23 PM

The above patch is the last thing I can do to make it decoupled without weird gymnastics, there are five more that I don't know if there's a way to decouple them properly:

  • mw.config.values.wbSiteDetails: Build using php code living in lib, heavily used in both client and repo: https://codesearch.wmflabs.org/search/?q=wbSiteDetails&i=nope&files=&repos=
    • We might split the php file into two and copy them?
  • mw.config.values.wbRepo: Same, heavily used everywhere.
  • wikibase basic nonsense code that defines wikibase global object which is used everywhere.
  • wikibase.api.RepoApi: both client and repo depend on it and the obvious solution is to copy-paste it in both places but all of the code lives in a git submodule.
    • Have two identical submodule?
    • Don't give a damn and define it twice while both pointing to the same file, how is it different from status quo?
  • wikibase.Site defined dynamically through a hook in lib. Fun.
    • Copy the hook handler and the code?
Tarrow added a comment.Jul 14 2020, 8:25 AM

It seems like for the wikibase api stuff we should probably take advantage of the fact it is a pseudo-npm module. I'm trying to think how

Tarrow moved this task from Peer Review to Backlog on the Wikibase Extension Decoupling and Registration (Sprint 3) board.Jul 14 2020, 8:28 AM
gerritbot added a comment.Jul 14 2020, 8:44 AM

Change 612401 merged by jenkins-bot:
[mediawiki/extensions/Wikibase@master] Move wikibase.api.ValueCaller RL module from lib to view

https://gerrit.wikimedia.org/r/612401

ReleaseTaggerBot added a project: MW-1.36-notes (1.36.0-wmf.1; 2020-07-21).Jul 14 2020, 9:00 AM
ItamarWMDE added a comment.Jul 14 2020, 12:11 PM
In T256054#6302406, @Ladsgroup wrote:

The above patch is the last thing I can do to make it decoupled without weird gymnastics, there are five more that I don't know if there's a way to decouple them properly:

As they both rely on php code, it seems like the easier option, but there's probably more digging around to do here.

  • wikibase basic nonsense code that defines wikibase global object which is used everywhere.

The fact that it's nonsensical global var bootstrapping means we can probably safely duplicate this file to client. as long as the sub-namespaces are available:

wikibase.sites <-- Defined in WikibaseLib
wikibase.api <-- Defined in WikibaseLib

  • wikibase.api.RepoApi: both client and repo depend on it and the obvious solution is to copy-paste it in both places but all of the code lives in a git submodule.
    • Have two identical submodule?
    • Don't give a damn and define it twice while both pointing to the same file, how is it different from status quo?

IMHO this is a perfect candidate for a JS module to test the monorepo approach with.

  • wikibase.Site defined dynamically through a hook in lib. Fun.
    • Copy the hook handler and the code?

I don't think it is necessary to copy the code, shouldn't we follow ADR 13 in this case and just define the hook both in extension-repo.json and extension-client.json?

Ladsgroup added a comment.Jul 14 2020, 2:14 PM
In T256054#6304050, @ItamarWMDE wrote:
In T256054#6302406, @Ladsgroup wrote:

The above patch is the last thing I can do to make it decoupled without weird gymnastics, there are five more that I don't know if there's a way to decouple them properly:

As they both rely on php code, it seems like the easier option, but there's probably more digging around to do here.

I'm not sure it'll be possible for the second one.

  • wikibase basic nonsense code that defines wikibase global object which is used everywhere.

The fact that it's nonsensical global var bootstrapping means we can probably safely duplicate this file to client. as long as the sub-namespaces are available:

wikibase.sites <-- Defined in WikibaseLib
wikibase.api <-- Defined in WikibaseLib

Yeah, let's do that. I make a patch for this one.

  • wikibase.api.RepoApi: both client and repo depend on it and the obvious solution is to copy-paste it in both places but all of the code lives in a git submodule.
    • Have two identical submodule?
    • Don't give a damn and define it twice while both pointing to the same file, how is it different from status quo?

IMHO this is a perfect candidate for a JS module to test the monorepo approach with.

  • wikibase.Site defined dynamically through a hook in lib. Fun.
    • Copy the hook handler and the code?

I don't think it is necessary to copy the code, shouldn't we follow ADR 13 in this case and just define the hook both in extension-repo.json and extension-client.json?

That's the status quo but the code sits in one place for both classes, meaning they are shared and coupled.

Ladsgroup moved this task from Backlog to Doing on the Wikibase Extension Decoupling and Registration (Sprint 3) board.Jul 14 2020, 2:17 PM
gerritbot added a comment.Jul 14 2020, 2:42 PM

Change 612597 had a related patch set uploaded (by Ladsgroup; owner: Ladsgroup):
[mediawiki/extensions/Wikibase@master] Migrate wikibase.api module to repo and use it directly in client

https://gerrit.wikimedia.org/r/612597

Ladsgroup moved this task from Doing to Peer Review on the Wikibase Extension Decoupling and Registration (Sprint 3) board.Jul 14 2020, 2:44 PM
gerritbot added a comment.Jul 14 2020, 3:31 PM

Change 612615 had a related patch set uploaded (by Ladsgroup; owner: Ladsgroup):
[mediawiki/extensions/Wikibase@master] Migrate 'wikibase' RL module to view

https://gerrit.wikimedia.org/r/612615

gerritbot added a comment.Jul 14 2020, 4:51 PM

Change 612597 merged by jenkins-bot:
[mediawiki/extensions/Wikibase@master] Migrate wikibase.api module to repo and use it directly in client

https://gerrit.wikimedia.org/r/612597

gerritbot added a comment.Jul 14 2020, 4:51 PM

Change 612615 merged by jenkins-bot:
[mediawiki/extensions/Wikibase@master] Migrate 'wikibase' RL module to view

https://gerrit.wikimedia.org/r/612615

Ladsgroup added a comment.Jul 14 2020, 6:50 PM

I have some long-term ideas on how to proceed for mw.config.values.wbSiteDetails and mw.config.values.wbRepo. The problem with these modules is that they are polymorphic (the same config behaves differently in a repo and client, they are pretending to be the same thing but they are not) and they even too outdated to be useful (which repo? commons or wikidata?). I think they need to be deprecated and broken apart. It's way out of scope of this hike and not a small size of work either. We can outline this and leave it for future devs to pick it up.

Ladsgroup added a comment.Jul 14 2020, 9:09 PM

Also I found some more dead code (by removing dead code, you uncover more). Deleting them is not easy for a stupid reason: Their tests are convoluted so for example I can't drop getDataValues because the test for hasDataValues uses it...

amsa@amsa-Latitude-7480:~/workspace$ python unused_js_functions.py ~/Wikibase
/home/amsa/Wikibase/view/lib/wikibase-data-values/src/dataValues.js getDataValues
/home/amsa/Wikibase/view/lib/wikibase-data-values/src/dataValues.js hasDataValue
/home/amsa/Wikibase/view/lib/wikibase-data-model/src/Fingerprint.js hasLabel
/home/amsa/Wikibase/view/lib/wikibase-data-model/src/Fingerprint.js hasDescription
/home/amsa/Wikibase/view/lib/wikibase-data-model/src/Fingerprint.js hasAliases
gerritbot added a comment.Jul 14 2020, 10:18 PM

Change 612671 had a related patch set uploaded (by Ladsgroup; owner: Ladsgroup):
[mediawiki/extensions/Wikibase@master] Removing dead code in client javascript

https://gerrit.wikimedia.org/r/612671

gerritbot added a comment.Jul 15 2020, 10:46 AM

Change 612671 merged by jenkins-bot:
[mediawiki/extensions/Wikibase@master] Removing dead code in client javascript

https://gerrit.wikimedia.org/r/612671

Lucas_Werkmeister_WMDE moved this task from Peer Review to Doing on the Wikibase Extension Decoupling and Registration (Sprint 3) board.Jul 15 2020, 11:25 AM
Ladsgroup removed Ladsgroup as the assignee of this task.Jul 15 2020, 11:43 AM
Ladsgroup moved this task from Doing to Backlog on the Wikibase Extension Decoupling and Registration (Sprint 3) board.

Okay, I don't think we can do much more than this. Three RL modules left out of ~15 and I think we can outline a long-term plan to fix it but not doable in this hike.

Lucas_Werkmeister_WMDE closed subtask T257475: Decouple util.highlightSubstring RL module from client and repo as Resolved.Jul 15 2020, 12:13 PM
Lucas_Werkmeister_WMDE closed subtask T257455: Decouple jquery.wikibase.siteselector RL module from client and repo as Resolved.Jul 15 2020, 12:17 PM
Lucas_Werkmeister_WMDE closed subtask T257476: Decouple jquery.ui.suggester RL module from client and repo as Resolved.
Ladsgroup added a comment.Jul 23 2020, 6:58 PM

Suggestion: Create tickets for deprecating the configs and call this task done. What do you think @Lucas_Werkmeister_WMDE @Tarrow

eranroz mentioned this in T259211: wikibase RepoApi disappeared.Jul 30 2020, 5:15 AM
darthmon_wmde edited projects, added Wikibase Extension Decoupling and Registration (Sprint 4); removed Wikibase Extension Decoupling and Registration (Sprint 3).Aug 4 2020, 9:15 AM
Lucas_Werkmeister_WMDE added a comment.Aug 4 2020, 1:20 PM
In T256054#6330723, @Ladsgroup wrote:

Suggestion: Create tickets for deprecating the configs and call this task done. What do you think @Lucas_Werkmeister_WMDE @Tarrow

Sounds good to me.

Ladsgroup closed this task as Resolved.Aug 7 2020, 7:10 PM
Ladsgroup claimed this task.
Ladsgroup mentioned this in T259914: Deprecate mw.config.values.wbRepo.
Ladsgroup mentioned this in T259915: Deprecate mw.config.values.wbSiteDetails.
Ladsgroup moved this task from Backlog to Done on the Wikibase Extension Decoupling and Registration (Sprint 4) board.

@Tarrow approved the idea on the mattermost, so with T259915: Deprecate mw.config.values.wbSiteDetails and T259914: Deprecate mw.config.values.wbRepo, this is done.

Maintenance_bot moved this task from Incoming to Done on the User-Ladsgroup board.Aug 7 2020, 7:15 PM
santhosh subscribed.Aug 17 2020, 6:28 AM

Changed related to this ticket caused a bug in the Wikidata linking in ContentTranslation - T249458: ContentTranslation is not adding pages sitelinks to wikidata

Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL