Page MenuHomePhabricator
Create Task
Maniphest T258002

Deprecate Skin::makeUrl and remove Skin::makeI18nUrl
Closed, ResolvedPublic
Actions

Description

Not used by any skin or extension from what I can see.

When deprecating/removing these functions be sure to update the bodies of other Skin methods such as makeInternalOrExternalUrl

Details

SubjectRepoBranchLines +/-
Replace usages and deprecate Skin::makeUrlmediawiki/coremaster+26 -18
Remove Skin::makeI18nUrl.mediawiki/coremaster+2 -14
Customize query in gerrit

Related Objects

Event Timeline

Jdlrobson created this task.Jul 14 2020, 11:31 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptJul 14 2020, 11:31 PM
Jdlrobson renamed this task from Deprecate Skin::makeUrl to Deprecate Skin::makeUrl and Skin::makeI18nUrl.Jul 14 2020, 11:33 PM
Jdlrobson updated the task description. (Show Details)
Mainframe98 subscribed.Jul 31 2020, 7:29 AM

Skin::makeI18nUrl was deprecated (in 1.35) for T140664: Achieve predictable MediaWiki routing and cacheable skin data. (rMW9c17d3a93d44: skins: Deprecate getDynamicStylesheetQuery, makeI18nUrl and makeNSUrl).

Jdlrobson renamed this task from Deprecate Skin::makeUrl and Skin::makeI18nUrl to Deprecate Skin::makeUrl and remove Skin::makeI18nUrl.Jul 31 2020, 2:51 PM
Jdlrobson updated the task description. (Show Details)
Ammarpad claimed this task.Aug 1 2020, 11:04 AM
gerritbot added a comment.Aug 12 2020, 10:27 PM

Change 619865 had a related patch set uploaded (by Ammarpad; owner: Ammarpad):
[mediawiki/core@master] Remove Skin::makeI18nUrl.

https://gerrit.wikimedia.org/r/619865

gerritbot added a project: Patch-For-Review.Aug 12 2020, 10:27 PM
gerritbot added a comment.Aug 17 2020, 6:42 PM

Change 619865 merged by jenkins-bot:
[mediawiki/core@master] Remove Skin::makeI18nUrl.

https://gerrit.wikimedia.org/r/619865

ReleaseTaggerBot added a project: MW-1.36-notes (1.36.0-wmf.5; 2020-08-18).Aug 17 2020, 7:00 PM
Maintenance_bot removed a project: Patch-For-Review.Aug 17 2020, 7:10 PM
Jdlrobson updated the task description. (Show Details)Aug 17 2020, 10:20 PM
Jdlrobson updated the task description. (Show Details)
gerritbot added a comment.Aug 25 2020, 10:09 PM

Change 622433 had a related patch set uploaded (by Ammarpad; owner: Ammarpad):
[mediawiki/core@master] Replace usages and deprecate Skin::makeUrl

https://gerrit.wikimedia.org/r/622433

gerritbot added a project: Patch-For-Review.Aug 25 2020, 10:09 PM
gerritbot added a comment.Aug 31 2020, 9:10 PM

Change 622433 merged by jenkins-bot:
[mediawiki/core@master] Replace usages and deprecate Skin::makeUrl

https://gerrit.wikimedia.org/r/622433

Maintenance_bot removed a project: Patch-For-Review.Aug 31 2020, 9:10 PM
ReleaseTaggerBot edited projects, added MW-1.36-notes (1.36.0-wmf.8; 2020-09-08); removed MW-1.36-notes (1.36.0-wmf.5; 2020-08-18).Aug 31 2020, 10:00 PM
Ammarpad closed this task as Resolved.Sep 1 2020, 12:41 AM
Ammarpad updated the task description. (Show Details)
Jdlrobson awarded a token.Sep 1 2020, 4:32 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL