Page MenuHomePhabricator

Parsoid parser test API framework gives video thumbnail URL incorrect when seek options are used
Closed, ResolvedPublic

Description

Parsoid's parsertest mock API doesn't return the seek component for a thumbnail URL, so it is not correct when starttime/endtime/thumbtime are used.

This shows up as a diff between parsertests run against the mock API and those run in integrated mode against mediawiki core set up in 'parsertest configuration'.

Event Timeline

cscott renamed this task from Parsoid video thumbnail URL incorrect when seek options are used to Parsoid parser test API framework gives video thumbnail URL incorrect when seek options are used.Jul 24 2020, 2:58 PM
cscott reopened this task as Open.
cscott updated the task description. (Show Details)

Ah, yes, I see that now. Retitled the bug to indicate that it's a problem w/ the mock API, because I'll need to fix this if I don't want the parsertests to vary when run by core.

Change 616009 had a related patch set uploaded (by C. Scott Ananian; owner: C. Scott Ananian):
[mediawiki/services/parsoid@master] Improve ParserTest mock of TimedMediaHandler properties

https://gerrit.wikimedia.org/r/616009

Change 616009 merged by jenkins-bot:
[mediawiki/services/parsoid@master] Improve ParserTest mock of TimedMediaHandler properties

https://gerrit.wikimedia.org/r/616009

ssastry triaged this task as Medium priority.Aug 5 2020, 9:39 PM
ssastry moved this task from Needs Triage to Testing on the Parsoid board.
Arlolra assigned this task to cscott.